From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F8F43DC4A5 for ; Fri, 27 Mar 2026 09:54:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774605301; cv=none; b=OroHOMwZFda2NaZDNqKKRToqUY/ylxYlC78G6hyNCvFMD5gPA677+e4+RafMto+oWSVoEN+45gMnpxThaHlEmU3/r5vRw5btyvjPJcE1s+iZiv2FvEM5P+Q34uqRdADSEgZ2KRkcAo2invxs1duuPY/lMSktDLFvgECB43/Yav8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774605301; c=relaxed/simple; bh=G/QB1JNOHcc+vsbxLMISXhWfq90+5X/vEx02XOqeVIc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WlkNAgJB/fRCAZic4aaeyywFOdY5EHXA2ZtLyUDl4nzERliPPcIhjQpkQzGArVoq+Su1AkkHp4/relUikdYKZfxGlN1Bck0GSg3K6e42Mp6MxYH/mtYFblOLSIge2B8n6ttvIY9REQwYH84FmI1g6azx8TDx4/bYFUmLa9LafpA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=RpVkrPl7; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="RpVkrPl7" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-439d8df7620so1340125f8f.0 for ; Fri, 27 Mar 2026 02:54:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1774605297; x=1775210097; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1KfOjXOUPA7aUNexnAO30qRyN744gIjbadETuO1mA9w=; b=RpVkrPl7mNmc5lXbaoQqUC8AJGAdPfi9u0W6ih9UsNNmfxSJidW2wl0LE+VDQYEZaW B62lTdwSDBXSNO0iJHP1jo0a13rpKQr0R8m8+v31UumeyRo6E7LpCFAalDVYyWUR+3wQ 99HrsYS1eMEo2FyCM+I/b1x+EUk/3cocAUHMvNUYix82wYiBXyiN3wbx6arvssIOQpAc PFwk4nOIt6jZGJ/VesN0CyCIeVSuIdK7BhzfbFDsjf/2DIeFwqvZr0UGx5eB7HzNmTAG sIgRSMgDjsVLJZNYf8WYpauppwMC/IlUBQnOSdSJmZoMH+i4CcmqOiBL+uLkqTgsX0oD 8lfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774605297; x=1775210097; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1KfOjXOUPA7aUNexnAO30qRyN744gIjbadETuO1mA9w=; b=JtGkzW0FG2A/HSofC5pLU6g7ARgmASrHQxs7Aah6RwvcAdnarRZmT4hNYqKbWDlv5h MCgwU6AFICyOMABhjNOiVA/EgtbZtNtvM1d3rQXcWo++nCIXz9DkXFv/sqqyHBRmkHSc u6HBxfa8oKBw6Oxxw9mJrQfh/A6a7hW7Wznx9pZS9Z8lq03jM0ySjXD8hDg+HXdg8aMR fAKxV6UiFahHT2H5vo/K+RV+bkTtvHEvi3sI4+9M/oalOmoXBOAmbvdOQ26rcRFgCjaz e4V1I9v7x1sAtuj+geARTg+wVewAStl/32lIxrADygIMlw880x+LZ5y2JiryhkOCphCQ aUfg== X-Forwarded-Encrypted: i=1; AJvYcCXd5Nm9BKdAGvqgRP9OgTcr4pD4twqUkLHxIH4Vbs/0sCoYI08AubnAGLj2At+dP1/LBWKlrJCFtSzpa4s=@vger.kernel.org X-Gm-Message-State: AOJu0YwXF7fUeNv0kANLjjbQhuQ1lTfuf2EgCzxJvJvWSWr8NhMTCkUE A0CNszfF4tImhFBG/RPEZi8eMnP+mwZ9AYBd0GSpQQxwnLKw2cPLAu+TlsGuaqA98HM= X-Gm-Gg: ATEYQzyOtC4ZVkz1cz0Xr9/WZT1miR68wAEnfived0SDr1XV4TfFy8Ms4wJLgl8NoOm F3RBhSk2RxlfZEtlFUf8BSLPijzPcDBjlQDmXnIg1ESutcoBbYHSLnQ8YVaIQ+k6KJ3kShjUyPz AlMi1qHkt504QfKma1sTtd9Dv+m1DOHQUCFobwyWRWnzCxIaZh0GotqOWW2pUGjtznzH8azISoU 1ndLSsGoG7GuKc1rIh4q8u9XKlxc6W+P4B19vHvVYxyRQuhQxYjqVgsS7xP6XtCfU3mzPdnhQ7y AeOHTAWxAc4Mfee1Lftr3cNybIGo+H7qsnhfO4XINiggLu95G6UZApB7araiW5Z2FvJakCZNwjL QOrS4EBn9MOPENIi67IAhPPjHfPC20bupoAGn3M8d+4z2SpEOsm2Ede7UpGkxfEtyn/edpz+O3x 5fDt5DiReVm4NdK8WLXMgNDkclcg== X-Received: by 2002:a5d:64e6:0:b0:43b:8fa4:1937 with SMTP id ffacd0b85a97d-43b9e9d5ea1mr2872332f8f.5.1774605296458; Fri, 27 Mar 2026 02:54:56 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b919df7e7sm13463368f8f.26.2026.03.27.02.54.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 02:54:56 -0700 (PDT) Date: Fri, 27 Mar 2026 10:54:54 +0100 From: Petr Mladek To: david.laight.linux@gmail.com Cc: "Rafael J. Wysocki" , Robert Moore , Len Brown , linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev, linux-kernel@vger.kernel.org, Masami Hiramatsu , Rasmus Villemoes , Andy Shevchenko , Steven Rostedt , Sergey Senozhatsky , Andrew Morton Subject: Re: [PATCH next] ACPICA: AML Parser: Remove spurious precision from format used to dump parse trees Message-ID: References: <20260326201830.3938-1-david.laight.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260326201830.3938-1-david.laight.linux@gmail.com> On Thu 2026-03-26 20:18:30, david.laight.linux@gmail.com wrote: > From: David Laight > > The debug code in acpi_ps_delete_parse_tree() uses ("%*.s", level * 4, " ") > to indent traces. > POSIX requires the empty precision be treated as zero, but the kernel treats > is as 'no precision specified'. > Change to ("%*s", level * 4, "") since there is additional whitespace and no > reason to indent by one space when level is zero. > > --- a/drivers/acpi/acpica/pswalk.c > +++ b/drivers/acpi/acpica/pswalk.c > @@ -49,8 +49,7 @@ void acpi_ps_delete_parse_tree(union acpi_parse_object *subtree_root) > > /* This debug option will print the entire parse tree */ > > - acpi_os_printf(" %*.s%s %p", (level * 4), > - " ", > + acpi_os_printf(" %*s%s %p", (level * 4), "", > acpi_ps_get_opcode_name(op-> > common. > aml_opcode), The change has no visible effect. The precision defines how many characters are copied from the given string. It does not matter here because the given string is empty "". The number of added spaces ' ' is defined by the field width parameter (level * 4). Anyway, the change makes sense: Reviewed-by: Petr Mladek Best Regards, Petr