Re: [PATCH v6] staging: media: av7110: fix coding style

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Wed, Mar 25, 2026 at 12:12:44AM +0530, Chethan C wrote:
> Fix indentation and alignment issues reported by checkpatch.pl.
> 
> Rename enums av7110_rec_play_state, av7110_type_rec_play_format,
> and av7110_encoder_command to follow kernel naming style.
> 
> Rename wssData and wssMode to wss_data and wss_mode to avoid
> camelCase identifiers.

TL;DR: one hunk should be not touched (see below).
Otherwise LGTM.

...

> @@ -551,7 +573,7 @@ static ssize_t dvb_aplay(struct av7110 *av7110, const char __user *buf,
>  			if (nonblock)
>  				return count - todo;
>  			if (wait_event_interruptible(av7110->aout.queue,
> -						     (dvb_ringbuffer_free(&av7110->aout) >= 20 * 1024)))
> +			(dvb_ringbuffer_free(&av7110->aout) >= 20 * 1024)))

This change is wrong.

Also one may consider to replace 20*1024 with proper HZ-dependent value.
(But the latter one should be done separately.)

>  				return count - todo;
>  		}

...

> -		av7110->wssData = ((d.data[1] << 8) & 0x3f00) | d.data[0];
> +		av7110->wss_data = ((d.data[1] << 8) & 0x3f00) | d.data[0];

Another side note: This kind of changes can be properly converted to use
get_unaligned_le16() & GENMASK(). But it's another story.

-- 
With Best Regards,
Andy Shevchenko