From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F22341482E8 for ; Fri, 3 Apr 2026 16:33:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775234030; cv=none; b=mgnDouiayPC8qlMwc87bM0LdjnDQEc9GPuUnQ5/9B0kUPHQMb/4lw0GDR22hwa3zB9m0zqqwxaGTUlvRZWzlScjmrV2sgzq+nfoP/eRtBHZ066PNQ4pztumDXf6x4BmsrvwxXagiC3Ob3+EC9o10jYJ8DdsC08roryGuBeBDq4Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775234030; c=relaxed/simple; bh=DS1Rt+7ONewCuR31rtB5/QdLFjYL/Z2H40VVah6e25Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fq9BKQh61puPEwAheWQNBOtEZpaQC2ufRmVPlidHDWNqDE2bN6TIoOrbq8Kj5OlLVUpX/N9T4VR0WZ07oTiI4vo2oYS3eXA9z8uGEo4BAwbh6c7T9Wb/Yshv2Ofs4q4bLPP9eEpe7oObsmEWcjUmBLl1ttPRtfZIAPDTiGnESVs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Wk6NCwYo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Wk6NCwYo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00D5FC4CEF7; Fri, 3 Apr 2026 16:33:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775234029; bh=DS1Rt+7ONewCuR31rtB5/QdLFjYL/Z2H40VVah6e25Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Wk6NCwYoQvDNWYEukm9ThqnRpRt7NMzTpGqTFB/IbvsedOs2jpsGOt9+lFfnlyxUI qfhEuwehnZwRQVAJwpwQ1q2KehxaU2jSTdBwLFr/L/qyqIB9EzEYx8LVkyq1tKZ3Zi s+1Oh+oRLdr0mRx13W+gP+ZXx4BU65LpACuKUx5/JGFiPa+dGwI7E5EHdYOzBVBmy7 z2wZnKcN3gsJhJZZuJ6mPwEUX3j9XlBdBu2D8+U33RuE12A6bPXoXnxKguV879aqXx s47FrKVyrCxBAX9brlDtPvEKQSu0f67Qf2UiznHzpwTdkCd9kN0X3FG08SIv+ZMHgs Q7ZtVYms6FABw== Date: Fri, 3 Apr 2026 17:33:44 +0100 From: "Lorenzo Stoakes (Oracle)" To: Mike Rapoport Cc: Andrew Morton , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , David Hildenbrand , Suren Baghdasaryan , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] tools/testing/selftests: add merge test for partial msealed range Message-ID: References: <20260331073627.50010-1-ljs@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Apr 03, 2026 at 07:08:40PM +0300, Mike Rapoport wrote: > On Tue, Mar 31, 2026 at 08:36:27AM +0100, Lorenzo Stoakes (Oracle) wrote: > > Commit 2697dd8ae721 ("mm/mseal: update VMA end correctly on merge") fixed > > an issue in the loop which iterates through VMAs applying mseal, which was > > triggered by mseal()'ing a range of VMAs where the second was mseal()'d and > > the first mergeable with it, once mseal()'d. > > > > Add a regression test to assert that this behaviour is correct. We place it > > in the merge selftests as this is strictly an issue with merging (via a > > vma_modify() invocation). > > > > It also assert that mseal()'d ranges are correctly merged as you'd expect. > > > > The test is implemented such that it is skipped if mseal() is not > > available on the system. > > > > Signed-off-by: Lorenzo Stoakes (Oracle) > > --- > > v2: > > * Added tools/ based header so __NR_mseal should always be available. > > * However, for completeness, also check to see if defined, and assume ENOSYS if > > not. > > * Thanks to Mike for reporting issues in his build on this test! > > Unfortunately it's not the only one :) Ugh... > > The header inclusion actually causes handle_uprobe_upon_merged_vma() to > fail because of mismatch in definition of__NR_perf_event_open in > and the correct definition from > /usr/include/unistd.h > > With the patch below handle_uprobe_upon_merged_vma() passes again and I > think it's not needed for mseal tests as well. > > diff --git a/tools/testing/selftests/mm/merge.c b/tools/testing/selftests/mm/merge.c > index efcb100fd865..519e5ac02db7 100644 > --- a/tools/testing/selftests/mm/merge.c > +++ b/tools/testing/selftests/mm/merge.c > @@ -2,7 +2,6 @@ > > #define _GNU_SOURCE > #include "kselftest_harness.h" > -#include > #include > #include > #include > Andrew - could you apply this two please? I can respin if needed. Cheers, Lorenzo