mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Biederman <ebiederm@aristanetworks.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Nick Piggin <npiggin@suse.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH mmotm] mm: page_mkwrite change prototype to match fault:  fix sysfs
Date: Sun, 22 Mar 2009 13:40:38 -0700	[thread overview]
Message-ID: <aca0ce8b0903221340s461b4025m752b5ef038224163@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0903221833140.17976@blonde.anvils>

On Sun, Mar 22, 2009 at 11:36 AM, Hugh Dickins <hugh@veritas.com> wrote:
> Fix warnings and return values in sysfs bin_page_mkwrite(), fixing
> fs/sysfs/bin.c: In function `bin_page_mkwrite':
> fs/sysfs/bin.c:250: warning: passing argument 2 of `bb->vm_ops->page_mkwrite' from incompatible pointer type
> fs/sysfs/bin.c: At top level:
> fs/sysfs/bin.c:280: warning: initialization from incompatible pointer type

In general this looks reasonable.  It appears that linux-next has
changed the prototype
of page_mkwrite.    Which is why I did not see this failure mode.

      reply	other threads:[~2009-03-22 20:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-22 18:36 Hugh Dickins
2009-03-22 20:40 ` Eric Biederman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aca0ce8b0903221340s461b4025m752b5ef038224163@mail.gmail.com \
    --to=ebiederm@aristanetworks.com \
    --cc=akpm@linux-foundation.org \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=npiggin@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®