From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752670AbdKHPfP (ORCPT ); Wed, 8 Nov 2017 10:35:15 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:45068 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751987AbdKHPfO (ORCPT ); Wed, 8 Nov 2017 10:35:14 -0500 Subject: Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute To: Juergen Gross , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, linux-kernel@vger.kernel.org, konrad.wilk@oracle.com References: <20171106174842.20276-1-Govinda.Tatti@Oracle.COM> <20171107112123.t6w4v5irbjysmyhe@dhcp-3-128.uk.xensource.com> <54bdfc56-891f-5c78-77c1-29758f8220f4@suse.com> From: Govinda Tatti Organization: Oracle Corporation Message-ID: Date: Wed, 8 Nov 2017 09:34:54 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <54bdfc56-891f-5c78-77c1-29758f8220f4@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/8/2017 9:09 AM, Juergen Gross wrote: > On 08/11/17 16:00, Govinda Tatti wrote: >> Thanks Roger for your review comments. Please see below for my comments. >> >> On 11/7/2017 5:21 AM, Roger Pau Monné wrote: >>> On Mon, Nov 06, 2017 at 12:48:42PM -0500, Govinda Tatti wrote: >>>> +out: >>>> +    if (!err) >>>> +        err = count; >>>> + >>>> +    return err; >>> What's the purpose of returning count here? >> Not sure. Will check with Konrad and address this comment. > You are telling sysfs that you have consumed all input characters. > Thanks Juergen Cheers GOVINDA