From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD5E538F92B for ; Fri, 27 Mar 2026 17:23:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.18 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774632188; cv=fail; b=gpBvHMb7Yv0C9CYflLFGQ+Pi2F31CpYjWTkw7u+HEZLov3r50bOPqtcJ7dDTBCom/u/bIjFq+CP6f7DmXHuF1P6REcS1dhgQu13hchtCX6NcY3V9gRhJ5uNUMQKVuQW2emJmpdMua6Lc4JGDOyVI8ka4T7BYQYpCfvoKoudax+4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774632188; c=relaxed/simple; bh=IGM15/xoG8GUQdbj81DwdB8UsCYcPEjd9izdkiOni+4=; h=Date:From:To:CC:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=hGuggQhI64Zpcg8VTqOScysZHi2+HL6E/VXNaPmQ7LjfjS0Ujg7Ci+jTlbsBWTqZJqoRFIvYkuezjuFx0ivvbkdhfEdYSTEie6/OtvdVpyN+Ipdav5HMfCAhTImZJm57WYJIuPZSuWf9JlV7awf92Sy2h9VxnvIO2Citoq6EXYo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=N7J+dHQ0; arc=fail smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="N7J+dHQ0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774632186; x=1806168186; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=IGM15/xoG8GUQdbj81DwdB8UsCYcPEjd9izdkiOni+4=; b=N7J+dHQ0QPJj+uDcap2tG5VDv6tLS6Cw1+apJd38+1APwURXDYrgdQI+ YHc2AfLEbXa2fCVOMiMd0gi80YKyXKzn2i/1e+81AcZMDsCcJUnwLLgoe xY9E0rlcsFcbWUM5M3i+J6B3vfx+hwRFlwSMulDPT0KrkN7Y2pQXzOEG+ +t+MTLA6IGRGMTKuH4TuexXMuPfyaCIJ8/PBxFN6Obbk04VFu5GkHPNqw 6ZxGm2n28ht/01Aect1LQtSrdgP4hJwKxo+/lCAs40+8xPn3146VxDX6t aUceStTWeBdfpiyxkRa0NKtfQ0VwGd5qK5KSpj0QCwmDNgQh2qI56Zkxu g==; X-CSE-ConnectionGUID: ZWzNiL3lRDKgBZ8VWGibiQ== X-CSE-MsgGUID: hbCAiXXtQDOe6GbuJLTnvg== X-IronPort-AV: E=McAfee;i="6800,10657,11742"; a="74894571" X-IronPort-AV: E=Sophos;i="6.23,144,1770624000"; d="scan'208";a="74894571" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2026 10:23:05 -0700 X-CSE-ConnectionGUID: 6dRrmHofQA28jeuYc5IPcA== X-CSE-MsgGUID: Sd9+3ORvTdefomMLe+rlRQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,144,1770624000"; d="scan'208";a="248407677" Received: from fmsmsx903.amr.corp.intel.com ([10.18.126.92]) by fmviesa002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2026 10:23:06 -0700 Received: from FMSMSX901.amr.corp.intel.com (10.18.126.90) by fmsmsx903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 27 Mar 2026 10:23:05 -0700 Received: from fmsedg901.ED.cps.intel.com (10.1.192.143) by FMSMSX901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Fri, 27 Mar 2026 10:23:05 -0700 Received: from SN4PR2101CU001.outbound.protection.outlook.com (40.93.195.70) by edgegateway.intel.com (192.55.55.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 27 Mar 2026 10:23:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UpC5rXlAZv9861Bkkgo8w2c1LALfYMdZmcThUTrSYGyiP0ferYfB050kSHyzudbvptemD5ZuVDLyZk7m3VGUyHuUz3QuucHbH/+CKPd2t+Gt6Ykvnvk9BQ8YmXXN+luK2agTBTSRSaKhIqe4jNBvkCVW67WXiRnamSnLBalBv/f/itnBFPGNbqdIP0XScWOMEvx3NEXQ+AxjHUri03VPCGMX57FWkZBSZH5g1E985PyqK4DAvO7RnGXbsiEVhvcjp+mDO3mFbwC3naMmj1DaAeaQHnWNM8PJwwa3jSecrjhs6CP01QOOGVGbTeITHkudp6tJmdsyfVs387cU2Enf8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QGzbraoKTVrEDOzOp2v/Psk8XvZjS1YBOM8MjWVmZZo=; b=FPOxQ9HMut3uwI05k7cHnVBj9bFEQJLzum78uXWazGb/FAM5Yibe748zKuvwaWt6aRiwpfTULj014XlbhrekQQdBkEE89oXyFR5BV+T6PgfbEI6SoJEK3i5jMZdqpia1Vg0IpLmdzb/kev0ES1KZTiOvJ9M61uYghJBSK+B8TGyTGTk7U4UbBzczEIJL69WD5H0f5CrPQkiNyXJ6+NcC0I2h4Vqnik7212SC5OvO+KMlM4Cd/0+CemReZVfIkNtlinG7TFrpy15xXQhEDk6O9K1CtFIj+PRWl+EU9SPYlCgu2rntj/zZmbb3dXx7NcWFd9+g1i3EzUZGAEJXDeqoPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from BL0PR11MB3282.namprd11.prod.outlook.com (2603:10b6:208:6a::32) by SJ2PR11MB8449.namprd11.prod.outlook.com (2603:10b6:a03:56f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.8; Fri, 27 Mar 2026 17:22:59 +0000 Received: from BL0PR11MB3282.namprd11.prod.outlook.com ([fe80::5050:537c:f8b:6a19]) by BL0PR11MB3282.namprd11.prod.outlook.com ([fe80::5050:537c:f8b:6a19%4]) with mapi id 15.20.9769.006; Fri, 27 Mar 2026 17:22:58 +0000 Date: Fri, 27 Mar 2026 18:22:50 +0100 From: Maciej Wieczor-Retman To: Pawan Gupta CC: Maciej Wieczor-Retman , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v12 3/4] x86/cpu: Do a sanity check on required feature bits Message-ID: References: <76b7b70ef4b900b968b632e295ebb84fcbc986a5.1774623092.git.m.wieczorretman@pm.me> <20260327171033.dklme72frkemb7bf@desk> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260327171033.dklme72frkemb7bf@desk> X-ClientProxiedBy: DB7PR05CA0020.eurprd05.prod.outlook.com (2603:10a6:10:36::33) To BL0PR11MB3282.namprd11.prod.outlook.com (2603:10b6:208:6a::32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR11MB3282:EE_|SJ2PR11MB8449:EE_ X-MS-Office365-Filtering-Correlation-Id: 5ea716a5-b7a7-49a5-4230-08de8c257db2 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|366016|22082099003|56012099003|18002099003; X-Microsoft-Antispam-Message-Info: EJNh/pwO5zKC6HbyA7IiVx7nZQy1xfFrL72spElcM67NB7oqP9LSUC4own0bHMMfuEYJRj9yKkaYjaie0YnYvnlxiRqcuzLLFbLa2IbsdBDonHAiULMc2l0b33twzecX68XSxYYWf7D0QSYnWdHGG3a697WvNjrzhjRZsnneiSdKUssz+EHFX0x6YKdrH0m9wOTUQEAVwQ6WBbn8EcmfVMbCX1+DM4INDhrqMn19ma9fDJWgJxK7jcjR5CNaedlXywPaFwFSniqex2fht6h1lGFtEObaFUctUHJJ8VKPRDv0k1Zoa66/EVr3rJF086y9exo6Y9q16xobhYalaAFvwAZz0JFixokAzfwI5zI94rGuflXCKgRn+TgMZSX3va+50NiQouY4dfeA7RueZYEkx6MmYZ5kpNnOPuo57xBEtj7rjHFuSiv9CV1thoDSBaP6EnxFjKIJ95KyVtB7tuWaniACrRS6nDgKUSF3T/tsCDv/WiKRBRQX1iG0usZNu5luPCl/hBvcAbXf+pnYO5EKHUOXhgSRTVoFMhAhLpmtD/1eFvJAMqHFYc/j9NCUJvClKoHsk/pNyD2bNspQGyoIDBiHbAc7Lcz76QCQGwz3+yekRopl3Bhe+n9OH1n4TfzZHVRVNW83zdT68D1kHYmEc+c904gRGSq6K8ZQJ7dncG2jqiuR8JU7O2FT7tTS+qXtWJ8HYKhVQn5SfndABfcffKzoYtBIFBICI6VD1dFugcM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR11MB3282.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(366016)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?bymo6Tf59HcTRXsLaUTlhqAk8a40BL1vEdxu8IZDONDy7OY1EMLiEePdFC?= =?iso-8859-1?Q?paA2YCyklYJbx2kX/OEziXMb4cvDH0ELdt3UuFAbEw6UhcTeDSM9vUIw+L?= =?iso-8859-1?Q?qFeTJKolN2yo/ui/MpP+l4Sq3IAU+ZHp2Qthy2QZ12XH4AqPLWsJJfbS8I?= =?iso-8859-1?Q?xRPcWoOuxWXAggbqG+plFpBdi9E9nI1OsVP6d6OEuKpO/XARDJqE9TNyQd?= =?iso-8859-1?Q?s8nRRSH0MliKYdn+5SXC0zWdVnzBRnVxQ0Pw1RhV6uWo+BiW50PfuknvJb?= =?iso-8859-1?Q?hdHMjbJnDty1C7jubF7Zoa+jVkm1dc1+1teZXvujhn0sCwXdq0qe51mC7n?= =?iso-8859-1?Q?hCG7WgwDN6Z/vg0kdZw9y52MPzAXkEeWkI9LQC5JS5BcE207E3fZrTlZDW?= =?iso-8859-1?Q?r+rM4/7WIhOIK1iL6YxBJU35F58c/9KXc7F/utr5Wq/3tYHyBQssNlT4pg?= =?iso-8859-1?Q?6kPbUNzIruSYWBRf1LdoIEY0Ak5FOw8cRi/TlL9QvFi7L+7QMHI0N0iwkl?= =?iso-8859-1?Q?p6gxK+Vk6J3jZsG8AlvieR4SlVYiYEsIoeWWjpydH2aIAraBYUzjde8h2f?= =?iso-8859-1?Q?LPdYU/5M1IlKIlLWEPY6PuxZ1UGwL12xU+wCfF4KHeGmvI/+v/DX+SMcWH?= =?iso-8859-1?Q?nyKB7oVWrK/cSrwa9GMRSsmfRsnACOH718U7cI1gue8pJIIsR6LkFB6Lix?= =?iso-8859-1?Q?oQIVXv4pEAqrljCmbmzPbnET0V7FxPGfr/iSGZ8DP1p82hErvXVXiYq6pa?= =?iso-8859-1?Q?4gRWGpTwdvt5Y20KBuZvoLoAV98I0Gn9mNEEmDqts5eOGjflnqdsMhkjkR?= =?iso-8859-1?Q?BTM+eeAodumX2XyunFNdZFW5DpGLuXHRNCfkYXCj9bFXg43pj2zSDVLVCN?= =?iso-8859-1?Q?ZSi/eW6diNtsfLxk5rFHUuUv4ChX1AOvdeIeBjoMnZC1GYR+AKbu2owNXO?= =?iso-8859-1?Q?CNHV2MHv/hLDX7PLlppkqarx/sqzPud998GCZkUVkxfthlpbogu+oTJXbV?= =?iso-8859-1?Q?EeS184c/znScYe4fp2Jjq+G1oOe9JjeB7fqWOeykR0JWgV+IUjLZTlbXtN?= =?iso-8859-1?Q?XnclUx1BiZOxp5kh8AxNtHfWJNkXTY+jBC+IHZ3uPEaP/yqWPclNI52wAI?= =?iso-8859-1?Q?EyeQA0XGpNiQX1Baw4NMPgjfz9V/o3DEiQdWS5KbxfwyEzatzycWHcdRJr?= =?iso-8859-1?Q?+adujCp97o3WxnG6k83ai4S1HknsWKifOUen1E9dIHVlIT82X+9b4uY6ep?= =?iso-8859-1?Q?EMS2nPZue1v4Nd9fiZwSJTsLkXuoVUwcuKxFXTgWGtpzFieVQgdC6P2kwE?= =?iso-8859-1?Q?YB3RKccM3yQB1Re6WA09zFBVdT85Dgs5kwGH4cZoCH84jOH5STo3jXE5rR?= =?iso-8859-1?Q?VX2I2u9v9NcuqlDQOznOVW59HmAj6xPLulTvcrz1BlxUoT3ZeoyU6QZTan?= =?iso-8859-1?Q?4+GvwfHA6EV4oam8FSCDyRgupEVmudtJWBR9/UECwxWK8NxLyRw10sPL4c?= =?iso-8859-1?Q?6um3uVijyHxvDXT/to3804L1r6pPe/nB61YiBVJyCii5fHYnwskBO6MJ3E?= =?iso-8859-1?Q?p32IrTPzq0D5a6Jg65trOwg5jUQPdsVKy4VjhXhc1yq8oAhC1WLADri7E5?= =?iso-8859-1?Q?0obiDQSXIF65DsbFyg2Na4wRRpo7vpJ6a73/Yp2E//avcAAgf3rscNziif?= =?iso-8859-1?Q?2dtoe6EiB8BnyL1vhYtE+cIRlWItR84WDtDc+INpI30B6FaaoNc1jiTCTl?= =?iso-8859-1?Q?Yx6SiWLhobFO+vkwfxjr4onRASOO/D2eh51g76eUqkHgT7NBHd2H5iKcKB?= =?iso-8859-1?Q?0Rf+W2o4O8V8k8Jn44fBoKhxiVNEEIn2e7TxF1Ogj9dqxznNNZMv?= X-Exchange-RoutingPolicyChecked: tWhHcQEQQK1NLhJuSrSGDRReDh0V8inEX81p4rICmGe4MwR+Bd+zdH9ozwD3XzrpyZDHjSCGKPRwFLtt5RoDqyH5XTehtwEMeGihzK61H+IDl+vozfT9NnBduMP8yqxli53HQTycS8RveZ7eA7lLCzJJqHiZcwm93fzplaEk+x8PffG+A8idzTEWOrh/vZK7K60FW2t+33SVtpZKQDJlvjQp+ACMiHxCkJy6QemRCmylgnt1948241HPsA8AXUt9sCLc7jtVKZ7PLz2N8osStv+JBubbM+FTjdo7jav8CEi0hJGcYEdk1hMaRJm+bQH2SnpQ2lz1UFD9Fq3wUg5dQw== X-MS-Exchange-CrossTenant-Network-Message-Id: 5ea716a5-b7a7-49a5-4230-08de8c257db2 X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3282.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2026 17:22:58.4902 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J6mX0ltUiVuRD4ZUNeGYO8gpYYymK3sDPB3h1cgymhqqsjJu6cxLJbXapLoFs/DHvkkZc93OSyfPf3esElPaITak5Z10XxWOCqZOtmgAa8o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8449 X-OriginatorOrg: intel.com On 2026-03-27 at 10:10:33 -0700, Pawan Gupta wrote: >On Fri, Mar 27, 2026 at 03:10:58PM +0000, Maciej Wieczor-Retman wrote: >> +static void verify_required_features(const struct cpuinfo_x86 *c) >> +{ >> + u32 required_features[NCAPINTS + 1] = REQUIRED_MASK_INIT; >> + char cap_buf[X86_NAMELESS_FEAT_BUFLEN]; >> + int i, error = 0; >> + >> + for_each_set_bit(i, (unsigned long *)required_features, NCAPINTS * 32) { >> + if (test_bit(i, (unsigned long *)c->x86_capability)) > >This can be simplified to: > > if (test_cpu_cap(c, i)) > Oh, right, thanks! I'll correct that for v13. -- Kind regards Maciej Wieczór-Retman