From: "luobin (L)" <luobin9@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<luoxianjun@huawei.com>, <yin.yinshi@huawei.com>,
<cloud.wangxiaoyun@huawei.com>
Subject: Re: [PATCH net-next v5] hinic: add set_channels ethtool_ops support
Date: Tue, 2 Jun 2020 08:31:28 +0800 [thread overview]
Message-ID: <acb398e4-ffde-2753-03ca-cbed8933daff@huawei.com> (raw)
In-Reply-To: <20200601.105339.1821963108388271707.davem@davemloft.net>
On 2020/6/2 1:53, David Miller wrote:
> From: Luo bin <luobin9@huawei.com>
> Date: Mon, 1 Jun 2020 18:57:48 +0800
>
>> @@ -470,6 +470,11 @@ netdev_tx_t hinic_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
>> struct hinic_txq *txq;
>> struct hinic_qp *qp;
>>
>> + if (unlikely(!netif_carrier_ok(netdev))) {
>> + dev_kfree_skb_any(skb);
>> + return NETDEV_TX_OK;
>> + }
> As stated by another reviewer, this change is unrelated to adding
> set_channels support. Please remove it from this patch.
Will fix. Thanks.
> .
prev parent reply other threads:[~2020-06-02 0:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 10:57 Luo bin
2020-06-01 17:53 ` David Miller
2020-06-02 0:31 ` luobin (L) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acb398e4-ffde-2753-03ca-cbed8933daff@huawei.com \
--to=luobin9@huawei.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=luoxianjun@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=yin.yinshi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®