From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B65D517BA5 for ; Thu, 28 Nov 2024 09:10:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732785033; cv=none; b=qO6CeouVLz2i/9jfIcDBYJA4rTC8c1z7H52hPJS7ocdlAkxf1c2dfD74PSJQtTJEoM1CytsQcgLJ+VGla8Z1OfSaOLWPD0VxcCMpm0V9RQs5nr+hb9yh8tQpqxC7KSjwpyGhTYvsFTb1zjjBFQr92q7rEq8YCT8AmtAbf/2F57U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732785033; c=relaxed/simple; bh=1qvWRKNboNmu51AxojQ5Qj4X9MnAEEhEsvcOe+PFzl8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MgjgrA8LjKap5x58CCx1flpZbp4juxDpjk/C66+FtkmmwjBRubpt4LQnGwu6/fZzNph32bhpwOZdTAAVPiY1dP6gIPPK6iKSy1X+7NDHJdtq3EpPrTqu4EQnQZMI0nTgN1ug1Cuq0Mb3VBnjaz2VM/7lixhC0pbGBI2VKluIzag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=L/1cCBFR; arc=none smtp.client-ip=209.85.208.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="L/1cCBFR" Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2ffa78204fcso280461fa.0 for ; Thu, 28 Nov 2024 01:10:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1732785030; x=1733389830; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Mfj/AobFLMhgE1cIWyFSrn5uWbVuXPFzxVqiYuk7vew=; b=L/1cCBFR2FtmHdasWv05bxiEb/BfD8CC+XgFoUJouLppSCuII3770hI/R+mtVVhI/C 5dOl+ifdMQs56DlwfnwV6fQxJf+g8JALden//8KV1OMr65yIitBd3lWA7RZZUgKRVak6 Wvq2f8fkYL+6E/wxOlcAcZT0xZ8wCQZ1S0JiyU2mWMz6FrsS5I62JyhzJqgDzsPn5awJ FFgZwHaZ3rcPZo7dDW9cpFHat9s5Tog3tX4yTYPpbSu0UCgJvkjqUNFceTVSXgnXaC81 hvRLci0aW8Nkr6xtglb5mEtW73AAmY0ps9/mA8TvTK5lb/6NKWmRB1oMqa5te9eRNyCP tljw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732785030; x=1733389830; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Mfj/AobFLMhgE1cIWyFSrn5uWbVuXPFzxVqiYuk7vew=; b=uZ/TiOzcYvhro1a7eV6WDWAgrbnWisFGnLTqirPE+VRrge1mVcygm/LLZ6PP5XGcNr NJ2bX+KPKHtBn/2BaAFctEywlnoJmB307GwqqHmSQf9oxfOEcnVRAtwE2xXSr77Ug/S3 78FGTNU74eXWa6dLiOK2fDFPrdPn906chAW84iUbglEMhfabvQa+MXv914tkkO5OJJAO N1BRfLDue1OFMrxqp7JesD+IiWDXsfTmzZ4Jlh9llarxfmhUnttBY9rPwAiEfmbiSi2k Qpm8lFgrOyJANojDRAUU49Z9jRCGsJ/ALh+qwrHfZ4plNn1K9/+F1h0kApIzt0vOQwIZ sfYQ== X-Forwarded-Encrypted: i=1; AJvYcCWQ+2mWN7uI0o0tSGmfDCBEAl6oXPCUeZU25E50p3SKmMD8ytbQCWmQrTinjFDwVpBs1y021nb5EUXZEfs=@vger.kernel.org X-Gm-Message-State: AOJu0YyJTNfrT8N303VvPb2/ywh6ugbgicb2l5yJYKHp2pL8oXrStMq+ wibaLOptWgQdQcLuCmPzOFO+NoVCnrI15zOwWYTgm9Gdhr0vNORBc+PYUwI32iE= X-Gm-Gg: ASbGncsD4OOitwCLHUdS3rLw+SxC0RlaCMZ10H4a5n75/eTxBOLUvdQ4sThxZdSGfN1 hkl+JFOp4myiH+To/B/924zxavU2BzW39vzEpqwKoVYjzOzwpW+2DEaKG/HvqIla2JTA3KQbf61 jN1ihMYxhUmBElT+0IUSd9R2+avP6BS9GLyfP7MFW4TQhsBkIVSYBEEKeldieQT0IZrrhZLw3Kh d8e9DJpdbCC1hdgbOzxSr2SFQyoylFqRN7PdvJka4eFtNLaTptePJCpJCKUmSkocPgqX89KinhI WIeeLMRGZELtjRhA7bpFpT0aM1hB X-Google-Smtp-Source: AGHT+IH0bl8SdTIeN9JDYq+vH2q816+b4x6RwU31gSdNCIs8qjdn3XBYa1+adMS2nm5uya1S5PmfZA== X-Received: by 2002:a05:6512:2212:b0:53d:d049:8743 with SMTP id 2adb3069b0e04-53df00ff9f5mr830506e87.9.1732785029864; Thu, 28 Nov 2024 01:10:29 -0800 (PST) Received: from [192.168.1.4] (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53df6496be6sm117511e87.221.2024.11.28.01.10.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Nov 2024 01:10:28 -0800 (PST) Message-ID: Date: Thu, 28 Nov 2024 11:10:26 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] media: qcom: camss: fix VFE pm domain off Content-Language: en-US To: Yassine Oudjana , =?UTF-8?B?QmFybmFiw6FzIEN6w6ltw6Fu?= , Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Konrad Dybcio , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Vladimir Zapolskiy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/27/24 12:01, Yassine Oudjana wrote: > On 22/11/2024 5:06 am, Barnabás Czémán wrote: >> Fix NULL pointer check before device_link_del >> is called. The intention is clear, but the context of the change is completely lost. >> Fixes: eb73facec2c2 ("media: qcom: camss: Use common VFE pm_domain_on/pm_domain_off where applicable") It's invalid, the change is not a fix. >> Signed-off-by: Barnabás Czémán >> --- >> drivers/media/platform/qcom/camss/camss-vfe.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >> --- >> base-commit: decc701f41d07481893fdea942c0ac6b226e84cd >> change-id: 20241122-vfe_pm_domain_off-c57008e54167 >> >> Best regards, >> >> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c >> index 80a62ba11295042802cbaec617fb87c492ea6a55..1bf1473331f63b9ab106d21ea263c84d851c8a31 100644 >> --- a/drivers/media/platform/qcom/camss/camss-vfe.c >> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c >> @@ -595,7 +595,7 @@ void vfe_isr_reset_ack(struct vfe_device *vfe) >> */ >> void vfe_pm_domain_off(struct vfe_device *vfe) >> { >> - if (!vfe->genpd) >> + if (!vfe->genpd_link) >> return; >> >> device_link_del(vfe->genpd_link); > > Tested-by: Yassine Oudjana > The change is useless and it shall be dropped. -- Best wishes, Vladimir