mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFT][PATCH] regulator: max14577: Revert "regulator: max14577: Add proper module aliases strings"
Date: Fri, 17 Sep 2021 09:30:34 +0200	[thread overview]
Message-ID: <acb72aa2-4211-4c2f-1176-82d533ddf8b5@samsung.com> (raw)
In-Reply-To: <20210916144102.120980-1-krzysztof.kozlowski@canonical.com>

Hi Krzysztof,

On 16.09.2021 16:41, Krzysztof Kozlowski wrote:
> This reverts commit 0da6736ecd10b45e535b100acd58df2db4c099d8.
>
> The MODULE_DEVICE_TABLE already creates proper alias.  Having another
> MODULE_ALIAS causes the alias to be duplicated:
>
>    $ modinfo max14577-regulator.ko
>
>    alias:          platform:max77836-regulator
>    alias:          platform:max14577-regulator
>    description:    Maxim 14577/77836 regulator driver
>    alias:          platform:max77836-regulator
>    alias:          platform:max14577-regulator
>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Fixes: 0da6736ecd10 ("regulator: max14577: Add proper module aliases strings")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>
> ---
>
> Not tested. Please test/comment.  This is an RFT also because reverted
> commit said to fix autoloading issue which I even reviewed... but really
> it should not be needed - alias gets duplicated.
> ---

Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>

Indeed, that patch was useless and excessive. It must be some leftover 
from my initial modules tests, which for good reasons was not submitted 
in the initial series in Feb 2020. Sorry for the noise.

>   drivers/regulator/max14577-regulator.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/regulator/max14577-regulator.c b/drivers/regulator/max14577-regulator.c
> index 1d78b455cc48..e34face736f4 100644
> --- a/drivers/regulator/max14577-regulator.c
> +++ b/drivers/regulator/max14577-regulator.c
> @@ -269,5 +269,3 @@ module_exit(max14577_regulator_exit);
>   MODULE_AUTHOR("Krzysztof Kozlowski <krzk@kernel.org>");
>   MODULE_DESCRIPTION("Maxim 14577/77836 regulator driver");
>   MODULE_LICENSE("GPL");
> -MODULE_ALIAS("platform:max14577-regulator");
> -MODULE_ALIAS("platform:max77836-regulator");

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland


  reply	other threads:[~2021-09-17  7:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210916144119eucas1p1ef79e9742c3d37d0d896f152b4252a0b@eucas1p1.samsung.com>
2021-09-16 14:41 ` Krzysztof Kozlowski
2021-09-17  7:30   ` Marek Szyprowski [this message]
2021-09-17 14:03   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acb72aa2-4211-4c2f-1176-82d533ddf8b5@samsung.com \
    --to=m.szyprowski@samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=broonie@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®