From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1320D285068 for ; Wed, 19 Aug 2026 23:07:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.13 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787180852; cv=fail; b=aWxEgvFpptulP/a6I6wdOq4NuK+dUPMvY7YGi8q2aEVRlxIqDpz+3v2xkgd3d746zaGWR6lkkV6kuaqhsaFOz0ZYf1O/4x96FH18KuHecCIzahtpEeID1DRxpAKxUVGxBAgoR87B7MzK4cMqkM6T2S6T/WaoY7vj1vVb1ktkGbw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787180852; c=relaxed/simple; bh=EofindoYaYeODXMBM6ZucgqOUEc8Whnpt/KC0IUPC3g=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=Cg/leBy/M9NQhOhec6oauk93EmluIhSMY+WhmnN9CTGkV6caHy/C33R0G9ZgttI8UWEop0URsGJbVTxv5tuU8kFi7qM6hm8+91D/P7CJPVnOV/5ivIr14GYn4i/8uMYkQAynvHo3UDiGfcDb76hdyOYDKOeYrTjTSkN6lWZyhzU= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=UGYVSOrO; arc=fail smtp.client-ip=198.175.65.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="UGYVSOrO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1787180852; x=1818716852; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=EofindoYaYeODXMBM6ZucgqOUEc8Whnpt/KC0IUPC3g=; b=UGYVSOrOwM9qXc4sZsqGkvRm59V9FFET6jKKxXWu1RM4cK8jHaqWIZb2 XT29l0mX6KurNvxJo6a5hkGQ5etQFymx0Cb2z0bNfwGfuUTPcnWk5exlu vpFg0rXtou0tlMM7Ub+i84fe8ugqYwolhF1j17swChaFgqmAVZXwAUvjz JuL6V/BkkQYmr/Kzgvti0AObMdPPMGjjgUKjT0Adu4FrSTXEYxD6QWT/b sOeO8iDMl69b4tb6JFjgXcrLJJhbXLZeFZLxvQ2uWLAv7LHm5Z4F5i4C/ NHavW6gnmjbQUL0/rEY/aii1k4MfKHEX2j3DaG/II3Hj0Nx21zs5KMbkS A==; X-CSE-ConnectionGUID: RSF4LANNQV2w0GEXzuM/XA== X-CSE-MsgGUID: HM088y5ITxiMDQPXjqMcRw== X-IronPort-AV: E=McAfee;i="6800,10657,11880"; a="98870082" X-IronPort-AV: E=Sophos;i="6.25,232,1779174000"; d="scan'208";a="98870082" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2026 16:07:31 -0700 X-CSE-ConnectionGUID: AItet5pSQPeB2PMWbhcG/g== X-CSE-MsgGUID: jIQXEUemQZ6yOJ1tavLsKQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,232,1779174000"; d="scan'208";a="295626519" Received: from fmsmsx903.amr.corp.intel.com ([10.18.126.92]) by orviesa002.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2026 16:07:30 -0700 Received: from FMSMSX903.amr.corp.intel.com (10.18.126.92) by fmsmsx903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Wed, 19 Aug 2026 16:07:29 -0700 Received: from fmsedg901.ED.cps.intel.com (10.1.192.143) by FMSMSX903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Wed, 19 Aug 2026 16:07:29 -0700 Received: from BYAPR05CU005.outbound.protection.outlook.com (52.101.85.38) by edgegateway.intel.com (192.55.55.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Wed, 19 Aug 2026 16:07:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=R11wY7m1+PPs6iauPtSLNYyd3qa0XLnJkZP9PQMgl/h6/vWwXehYlYP5Ix16+cP/4wDZJkaT82dfiF9p2F9bEltj5mp/NNpzIdig+9jLW6OQnuQl1RI0EsZ0aPXslZfzxTBV206c148dBFabBB66nt9o90PsOAXx3rzfImWNyhZ+dc4XjrSkOaRy6S0zOLomfhmd2ugBiqaQ+h0W7t0u4PD8YvwyF2+a9DWzgOJJfEqw0JLDsAkoE/8I3CcP3YeeV1gz69mgbs7CR6y+6JnKtImkYlMgQQbQQDwPL90MsMG7TOkVypL+qX2o1rxYCAQvHJJ5I5vt2Rxw47elfyCTAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xyR8nw/5IFqk22FcNHQ6JsV2PmkJ9MD5k8is9nW0osM=; b=kYLiTTzBpyPntqPSHn79NuZzoCqKUSUVMGIx36d3AKC7ZePKyMQjguz5BUr435BmV3FkUWKHSUTO6DkP1P+7s7H7TJNKYAwVi1C4+YjxPwM/yqF/b4XZfwozCCAf957e7LuyxnC6O8PonGmx3EojdHvHv0yJkQxln2pWKRsFODZnCF7AWI5nJI5t2xjejTT+vchjg2YAdIgvpSk8jequYkYCg1k3V96uAPpzyEBqhCuIHE6+lk1OcBrwkQ+NyLE45Zpmk1ZL9PcEW8KbPfPoekbRdyAnvLk8ZOZ23wRWOUEJC+IDjlVriiyFXV6+EYdLMTJjQ+cNQlThTWBB7K+13g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ2PR11MB8370.namprd11.prod.outlook.com (2603:10b6:a03:540::20) by DS0PR11MB7901.namprd11.prod.outlook.com (2603:10b6:8:f4::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.8; Wed, 19 Aug 2026 23:07:20 +0000 Received: from SJ2PR11MB8370.namprd11.prod.outlook.com ([fe80::b6cf:ce77:3cdf:7cc]) by SJ2PR11MB8370.namprd11.prod.outlook.com ([fe80::b6cf:ce77:3cdf:7cc%5]) with mapi id 15.21.0339.007; Wed, 19 Aug 2026 23:07:20 +0000 Message-ID: Date: Wed, 19 Aug 2026 16:07:17 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 6/9] x86/resctrl: Refactor the monitor read function To: Chen Yu , CC: , , , , , , , , , References: Content-Language: en-US From: Reinette Chatre In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR03CA0332.namprd03.prod.outlook.com (2603:10b6:303:dc::7) To SJ2PR11MB8370.namprd11.prod.outlook.com (2603:10b6:a03:540::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR11MB8370:EE_|DS0PR11MB7901:EE_ X-MS-Office365-Filtering-Correlation-Id: 5bf037e7-957c-45a0-e777-08defe469e4b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|7416014|376014|1800799024|56012099006|10067099003|4143699003|11063799006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: tT2avfrMNUsfcAJAj9kbqGCcxdrvo0/y8ORVM6tNgxrxgCr1dydPdAljb54umR0/dd06HHtfOUFKQUzxF90Sb7t4dIa+FVBruBFzzICMychAvO6E9n0NPfCwmZ02OqoIRZoVkrm9MAvWwtl6UZ5Xlmtzlsnxh0sGn/WNDBDLUaa9UkjmWP5FdGnfkaGvPBE1NyXfOp2SptQRRFAf6UD+TtxVSLHuIqErTFsytdCGhYPGkoe4+uCl+cU0m+W9KhIdAPkzX5YISQsl5X10TXv8xKIROHLYQT4NzMIdja+bcdiWYbYR7OMvsJeg9E0IbxczIKxgFv96nRxQW9O23pC6aSYvniTe1LH4G6+9LPv7lQtr5z/lk4RI8tRG416gEuKSmB8guiz0HeIG2pVeYyMVo6sGr976664lPanjjDSGFL5GAPhm/+BDKe7wMgkcPIBPrGP9Wl8CKVCXr9UP7Wir8c2Kbth/atcQI4SoVO7lH6AbqWcvic9vYPnCPLkM8Kij3QGXWaauYw+w/4BFbMUGC8OL57YCtZf2jcipOd3i5YXQShZo+ATYZFnULNT6RkJWPmnLejVyX2n+BuMRkK9x49hpaav06QNsFxIkmAlL6R4KTpqZcsRZ2Pp3WxJuEC74uVN9vTXZnWXbrExmfoMsQJ7CPl7dnxp9b8HLoH1QfAo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR11MB8370.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(7416014)(376014)(1800799024)(56012099006)(10067099003)(4143699003)(11063799006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmJBUXArYjUyQjVkcVlmdlhNOXdOVk1WZ3RqYmYvTnUvK0o5ZlRDZXNHYk1M?= =?utf-8?B?OUFzVjlJOFN5Z2I2U0ppTGppQXVqUEl3T1QvZTMwNTZKYUhCZndqcnJqWGdx?= =?utf-8?B?SU5NTVJ0dTV4Y2tJLzNNZlhSbTVYMHRxaFhIRXArSUZNWmg5QkpjTVh4YWd6?= =?utf-8?B?aUxud0tnWUFLaW1FcUlWS2x0VEorSzJvTjc0eEpjRVpZQkF6eEFKNzlxSjdu?= =?utf-8?B?Z2FDM2UzdUs4TEkveGpjZWMrbVJFYiszQjUzM0ZrMmoyY0lWTE94VjFQQTIx?= =?utf-8?B?N21mRzJyMGhKeHNBT0xRcWJyUlh2ZmJCNEx0enovS0MzcWVsZUpsM01wOGVL?= =?utf-8?B?bHBJMCtrVGFJWWRselBWeitTbzB6QlhDUHZUOHNkS2hMN3Z6TndiRU1rUlh2?= =?utf-8?B?VVlqd3pyRmtRbkFJTENnbjhRaGtPeVdrWk56Q2QxWUxYRmpoRjQ1V1JqWlM4?= =?utf-8?B?bmlzNldoWVBhUm1kV3ZqTWpJdEpSTW1kenFPdHNpYTNxbmdrM0t6OHU1TldP?= =?utf-8?B?L3Y1QlZodmFYeVhiQTZZQ05tdVlYTk5NOUM2RWFQcldGVjNsbkhTWTZRSXhS?= =?utf-8?B?RFpzdmkvNVBySW5Xb0lxYVlVSC9LNGZsTW05K1k5VTE0ZnltV1ZTaGlGMmhV?= =?utf-8?B?ekhYU29jZ0pEWWFZbnhkVTdadDJBYW9kZ3RJUWQvY1l4c1pqdVRQODZjRFNI?= =?utf-8?B?YWcyL1JKTklTQVRYb2NIaVROTGxMc3FyNklJMGpveG9pUlh6VjFSdGJCdmlO?= =?utf-8?B?Y3R1c1RkTytCbWZGVWR6WnVlWlgrbGs0MDVOeXdqRXR6V2dSYnhlOFNqRGts?= =?utf-8?B?M2FaRklpRGlqbG9zRzFOTlIwU00xYndmOERZZVYreCtxVE5CdFU2aUtOZWxt?= =?utf-8?B?bURVYzk0UTlSR0poODBOZ3MzL1Y4Ym5HbnBWb0JEaEV5cHlZQkpKQUFadUg5?= =?utf-8?B?UEkzR1cwTFFHRjE2UDVsN3l0MW9RWUI1MDMyWWFJY1IydzBIaWRCM1FmOU8x?= =?utf-8?B?cVJld2s0b2dXNmZpOHdpazZVVlNEdHp2TlhYQTFEOFNXYTl6WEZDTFp4VU1S?= =?utf-8?B?Vit6TVI1MC9lMnZtWjg2U2VESU55MXp2ZGZxWGVJOGljRWpKZ000dkFCL0p6?= =?utf-8?B?YTJseVR2QlJNaXRWcStpUThqYkRmVSswT1BHcjBPUmc0L3BteEtTTEpYS3hZ?= =?utf-8?B?b24zc2xoandRSzNDUCt3Sk1zMjdYS2dIV0RTT2hSZ3BPS2JGRkZSdGFqMUhj?= =?utf-8?B?VVhZM0twUWJyTnA2REhIS2ZKRzJsMFRRYzdkVWtYSm5NRE5GRyt2clVnM05R?= =?utf-8?B?S201cU9EemZ2SFFremFUSVlDYWZ0TURrNjhsS3VBOW1sQVJKcExyYmx5U0Vh?= =?utf-8?B?Wm5DNURaUTdFZ0FjbTRPY0xvb1prOHdyamJrRzAvbHpWckNnMmhjeVUvVjRv?= =?utf-8?B?aFVZRUk1N1dJMXVmZmduNXNWRUlXQlRYYm5iS0xqOHdvanNoSEFOMXFjRVhr?= =?utf-8?B?ZFdSWUh1WElHbWlGaFpoalVpcDkzUXZtYThyeDloaGlNcXhyWGphYXY1SnFo?= =?utf-8?B?S2ZZempmeG9kYllabUprQUhPTDh5UDZXejlqUlNOd0RHSy8vM2VUR0lUUnFZ?= =?utf-8?B?STZjQlh1SlA3djk5Qm9IemtwRHBadlRrZzdWV2s5Ym43SjF1VmpiY0l5c3Qv?= =?utf-8?B?YmlZMkw3TkllUTNOZGxjU3llL2w1NDIyREFKaUNSaFV5V0dYQVBYeEROMEd0?= =?utf-8?B?NE9KcGhETWUvSGhSNHpnaUNFY2Y0MldlQzhLU256N1hlb1hzM3FiY3Zxa1M1?= =?utf-8?B?MXJURm1TUzZuMytPSDBvL3p2WXc0UzRxYUdkVlRlaU5lc0VjVkhVNUt6cjIw?= =?utf-8?B?RkdwcjNqYnVkZWRHN3pudmNSKzd5MnkzNHB2UzRwcktkRnh6dkNGayt6ZzJ2?= =?utf-8?B?RGNHT2todHdCZmljTTRTUGtEVndSZFlCaGtNaTl6ZGtJaHloVnNLVTZKb011?= =?utf-8?B?MnVmcElvdEwrbEJUVzg2Z3M3T2o3czhEdGhHeXNtaHNuRU1XaGJBTHhCallB?= =?utf-8?B?MUc1K1V3ajZuZ1FpVjRqaE5Scm9ZbmVlcFpMWmliRHpqSU8rNUxESHhPSmZG?= =?utf-8?B?UUVlMUYxV2NPZ3VSci9yZFdxa1BYWGRuQjQzVlVsQlpxNzRlanE1akNTT29N?= =?utf-8?B?bWZWR2dTWlR6ZHJVNzZyM2RoRjZWM29PMm8zRVFXbGx0cEdFRmJqSlJvS0d6?= =?utf-8?B?WmhTOXJIUFhLdDFhZlJyYk9lNXJNUFpPdFNqaG8xbGN5ZFpGVU81TDhRUnM1?= =?utf-8?B?RXFaemJzRStIVks2RDY0eklHcGpDd2RkK2h1OGFrRGU2R2RMQ3orZmk0OGNo?= =?utf-8?Q?T28RIlTkHwD/IE6U=3D?= X-Exchange-RoutingPolicyChecked: a2LrYETa+zfwA+UBbEf2UROBfNDnD0FsDYGTG1DzyvYh9tWfGpBVznnKu7cpcA338lHCi/Qoe3abTqtV9/Bul6vYFm/FYOfn842Rh6Bl70CaWfx9HqvcuyHwyydxA+vlEYKOoOdgTETpjcZtiasw0RKRROz28vAr4jXO3PsmTbwOyHeqKnsjZY1e6PykOO0QKNcVM9DL0cMRnmc8wLR8wKi8lWlRi0gPwR+/ht2j2GF64Riqf7zxcLQZl3kj3lwOOqGTobsQd3idUMrwaVxoNcV4m8igvYBc9YOgcqCc4ob0eKK1DXSrzDAvDeYho3o4V/urhJZIeKEu+66PFmYbTA== X-MS-Exchange-CrossTenant-Network-Message-Id: 5bf037e7-957c-45a0-e777-08defe469e4b X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB8370.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2026 23:07:19.1661 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4PbQWyIEj8oAtOW85rPVW9N5jhw5X4ZZx48HJF8QB1FfRb4uBDCvY3+HV4AAEt0iw4wVP3b9tf2xM/9WIggQHCgQBHoHFsFo6RitX2maCgM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7901 X-OriginatorOrg: intel.com Hi Chenyu, On 7/25/26 2:23 AM, Chen Yu wrote: > diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/resctrl/monitor.c > index 569894d6e5c8..786828a0a3c2 100644 > --- a/arch/x86/kernel/cpu/resctrl/monitor.c > +++ b/arch/x86/kernel/cpu/resctrl/monitor.c > @@ -239,9 +239,9 @@ static u64 get_corrected_val(struct rdt_resource *r, struct rdt_l3_mon_domain *d > return chunks * hw_res->mon_scale; > } > > -int resctrl_arch_rmid_read(struct rdt_resource *r, struct rdt_domain_hdr *hdr, > - u32 unused, u32 rmid, enum resctrl_event_id eventid, > - void *arch_priv, u64 *val, void *ignored) > +static int arch_l3_read_event(struct rdt_domain_hdr *hdr, u32 rmid, > + enum resctrl_event_id eventid, u64 *val, > + struct rdt_resource *r) Could you please keep the same parameter order as original resctrl_arch_rmid_read()? Reinette