From: Miaohe Lin <linmiaohe@huawei.com>
To: Sean Christopherson <seanjc@google.com>
Cc: <pbonzini@redhat.com>, <tglx@linutronix.de>, <mingo@redhat.com>,
<bp@alien8.de>, <dave.hansen@linux.intel.com>, <x86@kernel.org>,
<hpa@zytor.com>, <kvm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kvm: x86: mmu: fix memoryleak in kvm_mmu_vendor_module_init()
Date: Thu, 25 Aug 2022 09:43:25 +0800 [thread overview]
Message-ID: <acc676e3-8dde-89c3-a031-67c3487c8f35@huawei.com> (raw)
In-Reply-To: <YwZHYZFj5Q8NzZha@google.com>
On 2022/8/24 23:44, Sean Christopherson wrote:
> Nit for future patches, please use
>
> KVM: x86/mmu:
>
> for the scope.
Will take care of it.
>
> On Tue, Aug 23, 2022, Miaohe Lin wrote:
>> When register_shrinker() fails, we forgot to release the percpu counter
>> kvm_total_used_mmu_pages leading to memoryleak. Fix this issue by calling
>> percpu_counter_destroy() when register_shrinker() fails.
>>
>> Fixes: ab271bd4dfd5 ("x86: kvm: propagate register_shrinker return code")
>> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
>> ---
>
> Reviewed-by: Sean Christopherson <seanjc@google.com>
Many thanks for your review.
Thanks,
Miaohe Lin
next prev parent reply other threads:[~2022-08-25 1:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 6:32 Miaohe Lin
2022-08-24 15:44 ` Sean Christopherson
2022-08-25 1:43 ` Miaohe Lin [this message]
2022-08-30 21:40 ` Sean Christopherson
2022-08-30 22:42 ` Huang, Kai
2022-08-30 22:52 ` Sean Christopherson
2022-08-31 1:07 ` Huang, Kai
2022-08-31 1:58 ` Miaohe Lin
2022-08-31 1:53 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acc676e3-8dde-89c3-a031-67c3487c8f35@huawei.com \
--to=linmiaohe@huawei.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®