From: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
To: Stephen Boyd <sboyd@kernel.org>, "Rafael J. Wysocki" <rafael@kernel.org>
Cc: linux-clk <linux-clk@vger.kernel.org>,
Vijendar.Mukunda@amd.com,
Alex Deucher <Alexander.Deucher@amd.com>,
Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com,
Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCH v2 RESEND 2/5] drivers: acpi: acpi_apd: Remove unused device property "is-rv"
Date: Mon, 8 Nov 2021 13:36:56 +0530 [thread overview]
Message-ID: <acc78695-9156-7f39-619f-75434bcb3a1f@amd.com> (raw)
In-Reply-To: <20211105222221.8AF8C60E93@mail.kernel.org>
On 11/6/2021 3:52 AM, Stephen Boyd wrote:
> [CAUTION: External Email]
>
> Quoting Rafael J. Wysocki (2021-11-05 08:02:26)
>> On Fri, Oct 29, 2021 at 8:33 AM Ajit Kumar Pandey
>> <AjitKumar.Pandey@amd.com> wrote:
>>>
>>> Initially "is-rv" device property is added for 48MHz fixed clock
>>> support on Raven or RV architecture. It's unused now as we moved
>>> to clock config based selection to extend such support on others
>>> architecture. This change removed unused code from acpi driver.
>>>
>>> Signed-off-by: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
>>
>> Is this and the [3/5] applicable without the [1/5]?
>>
>> If so, I can pick them up once they are approved by some other AMD
>> folks, preferably Mario.
>
> I'm still lost why we're putting this decision to have some clk or not
> into Kconfig.
>
I agree it's kind of weird to select clock based on Kconfig but only
reason to put Kconfig based selection is that this clk support required
on some older platforms where BIOS or bootloader change isn't feasible.
We have only one consumer for this 48MHzclk i.e audio drivers and idea
is that this config shouldn't be user-selectable one and automatically
select from audio machine driver which uses this clk.
next prev parent reply other threads:[~2021-11-08 8:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211029063228.578909-1-AjitKumar.Pandey@amd.com>
2021-10-29 6:32 ` [PATCH v2 RESEND 1/5] x86: clk: Add config option to enable 48MHz fixed fch clk Ajit Kumar Pandey
2021-10-29 6:32 ` [PATCH v2 RESEND 2/5] drivers: acpi: acpi_apd: Remove unused device property "is-rv" Ajit Kumar Pandey
2021-11-05 15:02 ` Rafael J. Wysocki
[not found] ` <20211105222221.8AF8C60E93@mail.kernel.org>
2021-11-08 8:06 ` Ajit Kumar Pandey [this message]
2021-11-12 21:18 ` Limonciello, Mario
2021-10-29 6:32 ` [PATCH v2 RESEND 3/5] ACPI: APD: Add a fmw property clk-name Ajit Kumar Pandey
2021-10-29 6:32 ` [PATCH v2 RESEND 4/5] clk: x86: Use dynamic con_id string during clk registration Ajit Kumar Pandey
2021-10-29 6:32 ` [PATCH v2 RESEND 5/5] clk: x86: Fix clk_gate_flags for RV_CLK_GATE Ajit Kumar Pandey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acc78695-9156-7f39-619f-75434bcb3a1f@amd.com \
--to=ajitkumar.pandey@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=rafael@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®