From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 884F01C3F31 for ; Sat, 28 Mar 2026 00:29:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774657746; cv=none; b=fkmc+kE3aiY70T1xAK6zyImx06wCoaAOTp2VJOE2H2lJnwDpN+WrZUV5rR9lbAGhOWJLS7HwZ1mpUFpuijEBOb1jr1SjgwKadJBKFW8C8AT7bahO8yz7ABmccX9M+kqHYq2BHCq0HgDkcoc1dWO8QJtB+VIZYwzre8mEnERBIjA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774657746; c=relaxed/simple; bh=HMkoE9Vc40bmNBT1wEnVRNiQM3G3Zy83w4vNBU4ViNk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hcZKJf2W19QCE378OEwbGyhZMZoRaBe3DZA91+sGGknF+O/2m0oc587CDSr5J5zd4rawwsNOIhSmB0GzU70Kp3jxbuCr1fir+vx7V7czPO0B/upFkji2VyTj/Q5Y1eO2ip7n/gp6n/I96QdLIGvh330FTAHtnYsxr4pyReFRJ1k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=T6UtwRUC; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=XK10MpHL; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="T6UtwRUC"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="XK10MpHL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774657743; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pVak1OQdFi+KSbDm2i0b5emN8NsmFfdL0DbczgHqixQ=; b=T6UtwRUC6XO7boxQ62mrGZokTnDnW1Wt0ZaEIbUJzsOuasjmy4lrx29PFhEBdYK6qSIzFc PU9S4TJICaIxyAeED9+NZqkPOALhcbLg5oCpqrWHqUXZH68nCdWE84XX2rC4ARYFeSrwdE BeLAK2KPkG35Kuyu0CBTY0FtOOljDJI= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-680-ba5H_gKKPO6YARsfvRIT6Q-1; Fri, 27 Mar 2026 20:29:01 -0400 X-MC-Unique: ba5H_gKKPO6YARsfvRIT6Q-1 X-Mimecast-MFC-AGG-ID: ba5H_gKKPO6YARsfvRIT6Q_1774657741 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2b0b57e192bso21731555ad.1 for ; Fri, 27 Mar 2026 17:29:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774657739; x=1775262539; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pVak1OQdFi+KSbDm2i0b5emN8NsmFfdL0DbczgHqixQ=; b=XK10MpHLHEBK4Ckuu112Y5I1ZB2BGD/wDSxiisQwx8JArVAT7gY59wghXCbTUGHEQ/ nJm2FAWApDvp076D+BsQMbxUr5wi9U3T0/nxZ4HwVgo38ZRmJYdBkJ5scJWaxZ5YOd52 cPZrtVLuIKJoOX1f+fqBmhBuaLxW0H3ch5T2UT7kMd4ZnK0hlUmn2e0ZvoCwP11DE9yw xomGIepjJP9HNi6JrUpR+2Ndyx2MQrpcaPzVYc/onEtGrQf3kmtbxjUr3gBpFID41AKe L/G4EBtIMH2ytDuSyTqht6uNqpp1EGd5hMkBcDjQI+tzEEO6/kcbqTdw6FO3SR/SnTPL 7RlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774657739; x=1775262539; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pVak1OQdFi+KSbDm2i0b5emN8NsmFfdL0DbczgHqixQ=; b=Ss7mIXGs7ifE+0Gu459/fwaB5i6TIjTY3wop8nE1G2vYv5dE27INc+3LDxMlZTpCuM N3dWTfcg76gJvpEQkKb3q1qtws1e9S3qrzEvEEn/rLozrvHYn9/nbXqnD4L6wPRvrygP +H1pYK8Vr3Kf4h0SP9KOkKy4HKBuTaFebUYHhddUV+7losOo7ATrbVq/FeE5KrPmuPSx 1R1wUyk/qI1VIeKBlSpPP370HPRwY5Junomh+wnoEGq81LE0FOok3RMwPanKgHHiIFtk b5+G/N8KVdIFBISCqnVbSuK0zcWR0tndjnTz89q4FxfVNXqquZ45T7lPWGZrh3JwQOoI 6VpQ== X-Forwarded-Encrypted: i=1; AJvYcCUgDEYOo0OMMOJ4eaGeDMHZdjpNKOBI7QGT9BXrDB4ErFeulW3EqnNzvARsxwNIEYVEyBXLc+IpwSdVico=@vger.kernel.org X-Gm-Message-State: AOJu0YwYe7JoX1mGXuLEZgTHczvDUUX8tEE3lsO/mwhtHvFps1IK427X hr7aETCMfNEEolC0sjp9vJiqsyJgnYdwqB+Gsig6trQpjFJaTRdoIBOMQfgpdkK7qfyA7Gj4Wkc EuHey7JyMAEmy1cTF2tUMj8upjvRjCcMV08sDnoSsuS4sOnQ/bvmI2D8vxdQuHue8f5T1tpQjxT QO X-Gm-Gg: ATEYQzxaWadshOIzRtLr1w+Bqr5vvtXt8/XxoLFBxNYdO/W1XIlfnYnAWx70Hz51aGE X7WqvjTj9SQQRetw6H6CZwfXxwYqxgonmIDfHVOeAbSENYoz3kXi3gQXXEBsUMlemPPyQ4wuElR AazNfcSLHrrVD4d/fjZeUtzpLS07k6kAcLzdClUBuvgD381EKNWKsgjNJcmkYP0sw2U9fYSiZHP guKXPm3YWTlN0mc48B1hH1ODOgkeyC7RnX+Jwd/2W2Pz193FSr4XA1J1YRS8uSJ4I22Qh3d2e9W MZfoy4rPfQSkxPbyQXH8WAp781cK1mjGF6ICeoXdtNGnBNPoDiIbKA/t/jld+omgZttLSRa9gul ful+SIPFVTjneajG4Bw== X-Received: by 2002:a17:903:3c30:b0:2b2:43ca:3486 with SMTP id d9443c01a7336-2b243ca38b7mr2412955ad.46.1774657739500; Fri, 27 Mar 2026 17:28:59 -0700 (PDT) X-Received: by 2002:a17:903:3c30:b0:2b2:43ca:3486 with SMTP id d9443c01a7336-2b243ca38b7mr2412725ad.46.1774657739017; Fri, 27 Mar 2026 17:28:59 -0700 (PDT) Received: from redhat.com ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b242642956sm5490615ad.6.2026.03.27.17.28.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 17:28:57 -0700 (PDT) Date: Sat, 28 Mar 2026 08:28:55 +0800 From: Li Wang To: Andrew Morton Cc: rppt@kernel.org, david@kernel.org, ljs@kernel.org, Liam.Howlett@oracle.com, vbabka@kernel.org, surenb@google.com, mhocko@suse.com, shuah@kernel.org, aubaker@redhat.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] selftests/mm: skip hugetlb_dio tests when DIO alignment is incompatible Message-ID: References: <20260327120305.58653-1-liwang@redhat.com> <20260327121350.858a127fa49ed6e1eb4a40a7@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260327121350.858a127fa49ed6e1eb4a40a7@linux-foundation.org> On Fri, Mar 27, 2026 at 12:13:50PM -0700, Andrew Morton wrote: > On Fri, 27 Mar 2026 20:03:05 +0800 Li Wang wrote: > > > hugetlb_dio test uses sub-page offsets (pagesize / 2) to verify that > > hugepages used as DIO user buffers are correctly unpinned at completion. > > > > However, on filesystems with a logical block size larger than half the > > page size (e.g., 4K-sector block devices), these unaligned DIO writes > > are rejected with -EINVAL, causing the test to fail unexpectedly. > > > > Add get_dio_alignment() to query the filesystem's required DIO alignment > > via statx(STATX_DIOALIGN) and pass it to run_dio_using_hugetlb(). Skip > > individual test cases whose write length is not a multiple of the > > alignment, so that aligned cases are still tested. > > > > === Reproduce Steps === > > > > # dd if=/dev/zero of=/tmp/test.img bs=1M count=512 > > # losetup --sector-size 4096 /dev/loop0 /tmp/test.img > > # mkfs.xfs /dev/loop0 > > # mkdir -p /mnt/dio_test > > # mount /dev/loop0 /mnt/dio_test > > > > // Modify test to open /mnt/dio_test and rebuild it: > > - fd = open("/tmp", O_TMPFILE | O_RDWR | O_DIRECT, 0664); > > + fd = open("/mnt/dio_test", O_TMPFILE | O_RDWR | O_DIRECT, 0664); > > > > # getconf PAGESIZE > > 4096 > > > > # echo 100 >/proc/sys/vm/nr_hugepages > > > > # ./hugetlb_dio > > TAP version 13 > > 1..4 > > # No. Free pages before allocation : 100 > > # No. Free pages after munmap : 100 > > ok 1 free huge pages from 0-12288 > > Bail out! Error writing to file > > : Invalid argument (22) > > # Planned tests != run tests (4 != 1) > > # Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0 > > > > ... > > > > v2: > > - Pass dio_align as a parameter to run_dio_using_hugetlb() > > instead of generally page_size/2 alignment check. > > > > Whee, AI review has decided that pre glibc-2.36 is a problem (last time > it was pre-2.37). Ok, will handle this build issue with old glibc. > And it's forgotten the previous fs-doesnt-support-DIO issues. Did you > alter that? [Sorry, forgot to mention in change logs] Yes, I added O_DIRECT flag back to the first open(). Then it'd skip into a failure on filesystems that doesn't support O_DIRECT. Also, statx on FS doesn't support DIO will set stx_dio_offset_align to 0, which may led a division by zero issue, I added a zero check. } else if ((stx.stx_mask & STATX_DIOALIGN) && stx.stx_dio_offset_align) { > The get_dio_alignment-before-ksft_print_header thing seems legit. +1 And, before sending v3, I would leave this patch for more days to see if others comment. -- Regards, Li Wang