From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34E191EDA2A for ; Tue, 22 Apr 2025 23:57:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745366257; cv=none; b=E+CE8EptqGd0iTPhoKzwtM0Vfkg7aJk/7ADzBRefbM12ZBUPa/AEC9jLCyCJ37jfHAD/5X4gZdg3rm5VcpEIO1ePujoxLFib0J6ombwxuthuHuSdzpfx2Nf975LYwbSArTPrtEwWitWyw0Oy5sLyNFmZwQZ4Gk36uW26iLc9I1o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745366257; c=relaxed/simple; bh=FmAgiHjOXbqJcln/OIgUaR1I0UCojgC0IjHOSrAKSkA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gbGwfLpJlQu1mbWh8ikFrAQZroMSfx9ZuJ71umtcUG/CsspQssljatvIoEYlw96Psi/+tJS8y8GRaKIcgP4gsqmtBZl6oI0TJzbC4yrMZadh8J5ZaiQGLmSynhigKDmNYuvBBTmdStHIqx2TfRKNrlqpkel/V10g2jFgQIm9j0s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NedBK0c6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NedBK0c6" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53MKpdjD021600 for ; Tue, 22 Apr 2025 23:57:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= H1IjI6zQkO1wJMxEGjiNO1XXndei6SHSNKx61xlsx+Y=; b=NedBK0c6t854p9eh CdZtrysS/hZcRtPXQSH4e/OocOoDDEuRwwwNNw9cKY3DwCW9eus4vDD697uKJhHH qzFbBpAMzOFKTXBtQ2cpYxlNvlDBPT9uTeB4oMXPE0dPxIfGmOm4FpKKOQGCTLV7 lEJ++ol5DgDTCPx0w89mhnetm+jfpA68nGOGoxHrsHMEsMMzgzjP+6eIZ7ykaF90 6z4lYqS6ext37V32U9h6BlcnNCwo/DkVEwzvrJP+D0deDUE74JTSRnzTLXZSzer6 CnCYg9tWA0y303ceyy1h+g8uyX9uXyh1wHdAVdX9ZAgW7KPCezLRtpQCHgGkioT1 MHmQ4A== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 466jh38b0q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 22 Apr 2025 23:57:35 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7c54788bdf7so23754685a.2 for ; Tue, 22 Apr 2025 16:57:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745366254; x=1745971054; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=H1IjI6zQkO1wJMxEGjiNO1XXndei6SHSNKx61xlsx+Y=; b=bHJbH0SNLoC0bOTSCepkoFox3QVgH+CCdGpwddsC5Oh1fxBHORKHC5CMx0rAgKEhIf Fb8d6RI/hTGUgDgUkyY8rhVphdmnR4fKFvYzABf+QCzEPZOqREBbVqZuu+FiLSA0dI+0 8W7DlEaTgtaWaZQiWfaoQ5v625TTeKoEYsGN75UtQpfXWA4leXLmQ6TWwkIT4ZteQkU7 mOgLisIa8LmkX1+E5/4WCi3KwrhROg/HQKdH41GkOVKUnsjJvri5ODC8CB+yPCa2bqpq lio5+dJEOnhrLGMxom9mMAx3JAhHZ0Q5nv3ZIByOdw9P3PViyvx0bkEk6CDvQCy3Gdbj DRUA== X-Forwarded-Encrypted: i=1; AJvYcCU/44i5Cykna5HXGsn2NlOfU+UkcON7BvwGoGhaH3wp7+eKr0Zj2Rf/sW1p2huEPGSY3wEtjZPG0bfK7HQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwtFV3fkpcIkTdX+T9ZuGAfjuFbuY0W6DBjqVI6CT+xUknHW6sJ DnN3gkaa/UGTelR+5WgiIRKctk7HSYxhJsdgt+o8pPDKBPIv6mzdBOVOnxpYNzl18i0HfSC1CDk SbrQYYypAVxfOCOmGmT2tomXBemsA0o/4b2h8CXaDlQcnSLkJ6oFI3EFCBAYaT6g= X-Gm-Gg: ASbGncsfemrzVIuZNLYIWU9f1TQAm9mf+QDjhea97qyQPMDyRmz0Z9eav+lBTNhXIWw CduWVW5YWssUjFAYzeZNS5qJivFLUCXXJz3SOqhfr+B58zOVUoNhg9nlGDKMBUw6jpQkpD7OEWW IQ5LeNSUFfSb4J4mniFYCESKiWB6QwPOOGkkl8t0LzhDy4o3e+/Qa3K9cmej+m+dItIcxZLQiqk kSofdCJc6o2r7XkxqTzF8LTvkb+ecpbm/tOH+C8UTx0K31X8uxv3h6o+XDVmY3G7FZq37Jm8GyO 0GH7DU9UQ1NbBpG2Bm79rI4eXT3dxUMtEsLdDm1WIcS4M9HLmMnFfAexLZvHqENYfWA= X-Received: by 2002:a05:620a:430b:b0:7c5:6fee:246f with SMTP id af79cd13be357-7c94d231186mr76783785a.1.1745366253948; Tue, 22 Apr 2025 16:57:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFEwDHPfh+3S2avLrO37FcmKZFcnMLRvAj2FgPUvuV/KU+OjhRg4HtBNyxuqy6ggiQpB23oJw== X-Received: by 2002:a05:620a:430b:b0:7c5:6fee:246f with SMTP id af79cd13be357-7c94d231186mr76781285a.1.1745366253511; Tue, 22 Apr 2025 16:57:33 -0700 (PDT) Received: from [192.168.65.141] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acb6eefd8e3sm723131566b.98.2025.04.22.16.57.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Apr 2025 16:57:32 -0700 (PDT) Message-ID: Date: Wed, 23 Apr 2025 01:57:28 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] drm/msm/a6xx: Get HBB dynamically, if available To: Rob Clark , Akhil P Oommen Cc: Connor Abbott , Konrad Dybcio , Bjorn Andersson , Kees Cook , "Gustavo A. R. Silva" , Sean Paul , Abhinav Kumar , Dmitry Baryshkov , David Airlie , Simona Vetter , Dmitry Baryshkov , Marijn Suijten , linux-kernel , linux-arm-msm , linux-hardening@vger.kernel.org, dri-devel , freedreno@lists.freedesktop.org, Konrad Dybcio References: <20250410-topic-smem_dramc-v2-0-dead15264714@oss.qualcomm.com> <20250410-topic-smem_dramc-v2-3-dead15264714@oss.qualcomm.com> <20911703-ab4e-4eb2-8611-294730a06d2f@quicinc.com> <1282bf58-e431-4a07-97e5-628437e7ce5f@quicinc.com> <16845de2-a40a-4e3d-b3aa-c91e7072b57f@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDIyMDE3OSBTYWx0ZWRfXxt0TQdmzgAbI jaZ+qagqI76bfZXckmb8d67Y55+ByrONKrbqL2d3o6VftVd1QRNobTF+FebTlqUwV0IGsXvKBhM 55eEO88+6q9SHAJQfWAM0MZ1nmB9H4NDHfsiNHiyLi+h/v1PUnvgWdDwqTi81q4zAwXDu3Op2Ky f/sFytlWTFZXwWj+vooRlfw0PwgA+iQUSo95LqWpnir75vY9PDc0XMIkpz+jvgGhY8Us5pef2ii wGXZo8h/baygFjFKKSaVd/lEiRljFj3OEpUc65xNt8HCDcRHc5OwD6mngYEA8be85l+ST+arGf1 xOFdpb8AnSBkh2yz0eRp13czoQXsBIWXpbyxDy2CihDcnuy2GoAR3UTbpgWEH4HmbiE0wuSo93q kHCEwioIchBjmDun1slZdMWWJN8zvMMLOrSuXk5mz79aLDI2nQRgKcC6RaFwZYz8JV5yk1hz X-Authority-Analysis: v=2.4 cv=bs1MBFai c=1 sm=1 tr=0 ts=68082cef cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=bi7NrT-7VlQDZNL6n6kA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: gqerLVAD2fmy6UDSUjbzTU7RinZ4Hqg1 X-Proofpoint-GUID: gqerLVAD2fmy6UDSUjbzTU7RinZ4Hqg1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-22_11,2025-04-22_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 suspectscore=0 mlxlogscore=999 mlxscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 impostorscore=0 malwarescore=0 clxscore=1015 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2504220179 On 4/21/25 10:13 PM, Rob Clark wrote: > On Fri, Apr 18, 2025 at 9:00 AM Akhil P Oommen wrote: >> >> On 4/18/2025 6:40 AM, Connor Abbott wrote: >>> On Thu, Apr 17, 2025, 1:50 PM Akhil P Oommen wrote: >>>> >>>> On 4/17/2025 9:02 PM, Connor Abbott wrote: >>>>> On Thu, Apr 17, 2025 at 3:45 AM Akhil P Oommen wrote: >>>>>> >>>>>> On 4/10/2025 11:13 PM, Konrad Dybcio wrote: >>>>>>> From: Konrad Dybcio >>>>>>> >>>>>>> The Highest Bank address Bit value can change based on memory type used. >>>>>>> >>>>>>> Attempt to retrieve it dynamically, and fall back to a reasonable >>>>>>> default (the one used prior to this change) on error. >>>>>>> >>>>>>> Signed-off-by: Konrad Dybcio >>>>>>> --- >>>>>>> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 15 ++++++++++++++- >>>>>>> 1 file changed, 14 insertions(+), 1 deletion(-) >>>>>>> >>>>>>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >>>>>>> index 06465bc2d0b4b128cddfcfcaf1fe4252632b6777..a6232b382bd16319f20ae5f8f5e57f38ecc62d9f 100644 >>>>>>> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >>>>>>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >>>>>>> @@ -13,6 +13,7 @@ >>>>>>> #include >>>>>>> #include >>>>>>> #include >>>>>>> +#include >>>>>>> >>>>>>> #define GPU_PAS_ID 13 >>>>>>> >>>>>>> @@ -587,6 +588,8 @@ static void a6xx_set_cp_protect(struct msm_gpu *gpu) >>>>>>> >>>>>>> static void a6xx_calc_ubwc_config(struct adreno_gpu *gpu) >>>>>>> { >>>>>>> + int hbb; >>>>>>> + >>>>>>> gpu->ubwc_config.rgb565_predicator = 0; >>>>>>> gpu->ubwc_config.uavflagprd_inv = 0; >>>>>>> gpu->ubwc_config.min_acc_len = 0; >>>>>>> @@ -635,7 +638,6 @@ static void a6xx_calc_ubwc_config(struct adreno_gpu *gpu) >>>>>>> adreno_is_a690(gpu) || >>>>>>> adreno_is_a730(gpu) || >>>>>>> adreno_is_a740_family(gpu)) { >>>>>>> - /* TODO: get ddr type from bootloader and use 2 for LPDDR4 */ >>>>>>> gpu->ubwc_config.highest_bank_bit = 16; >>>>>>> gpu->ubwc_config.amsbc = 1; >>>>>>> gpu->ubwc_config.rgb565_predicator = 1; >>>>>>> @@ -664,6 +666,13 @@ static void a6xx_calc_ubwc_config(struct adreno_gpu *gpu) >>>>>>> gpu->ubwc_config.highest_bank_bit = 14; >>>>>>> gpu->ubwc_config.min_acc_len = 1; >>>>>>> } >>>>>>> + >>>>>>> + /* Attempt to retrieve the data from SMEM, keep the above defaults in case of error */ >>>>>>> + hbb = qcom_smem_dram_get_hbb(); >>>>>>> + if (hbb < 0) >>>>>>> + return; >>>>>>> + >>>>>>> + gpu->ubwc_config.highest_bank_bit = hbb; >>>>>> >>>>>> I am worried about blindly relying on SMEM data directly for HBB for >>>>>> legacy chipsets. There is no guarantee it is accurate on every chipset >>>>>> and every version of firmware. Also, until recently, this value was >>>>>> hardcoded in Mesa which matched the value in KMD. >>>>> >>>>> To be clear about this, from the moment we introduced host image >>>>> copies in Mesa we added support for querying the HBB from the kernel, >>>>> explicitly so that we could do what this series does without Mesa ever >>>>> breaking. Mesa will never assume the HBB unless the kernel is too old >>>>> to support querying it. So don't let Mesa be the thing that stops us >>>>> here. >>>> >>>> Thanks for clarifying about Mesa. I still don't trust a data source that >>>> is unused in production. >>> >>> Fair enough, I'm not going to argue with that part. Just wanted to >>> clear up any confusion about Mesa. >>> >>> Although, IIRC kgsl did set different values for a650 depending on >>> memory type... do you know what source that used? >> >> KGSL relies on an undocumented devicetree node populated by bootloader >> to detect ddrtype and calculates the HBB value based on that. > > Would it be reasonable to use the smem value, but if we find the > undocumented dt property, WARN_ON() if it's value disagrees with smem? > > That would at least give some confidence, or justified un-confidence > about the smem values The aforementioned value is populated based on the data that this driver reads out, and only on the same range of platforms that this driver happens to cater to Konrad