From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932553AbcJULit (ORCPT <rfc822;w@1wt.eu>);
        Fri, 21 Oct 2016 07:38:49 -0400
Received: from mout.kundenserver.de ([212.227.126.187]:63868 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755270AbcJULil (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 21 Oct 2016 07:38:41 -0400
Subject: Re: [PATCH v3 net-next 8/8] net: qualcomm: add QCA7000 UART driver
To: David Miller <davem@davemloft.net>
References: <1476790054-27174-1-git-send-email-stefan.wahren@i2se.com>
 <1476790054-27174-9-git-send-email-stefan.wahren@i2se.com>
 <20161018.143025.284251297276702898.davem@davemloft.net>
Cc: gregkh@linuxfoundation.org, jslaby@suse.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
From: Stefan Wahren <stefan.wahren@i2se.com>
Message-ID: <acda56ec-75c2-9753-710e-d69b36f88095@i2se.com>
Date: Fri, 21 Oct 2016 13:38:17 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20161018.143025.284251297276702898.davem@davemloft.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:IqBqUE4Y0Ch8ekYjLBLdv8j3P5bjIVsGdgnw4uKoPdZz6WmMJvj
 h2SoPLq+0XFQ4vOJT8vRaxiYV+Yxoj5r5alXgZKerCLciZIFoys5aHYl65j2fQp6LwZln+V
 IkyzA8a4bpGwg5qYczurq/Tqysu+0LtSU/O8aUpUzQ9MoGXW6e2QL4H2x4nyfYV43RpxmTs
 UOugQSqhnhH4alX2LkuxA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:/qdCQeP+seo=:MqZfACYmplrcnKKm49Lx5Q
 Qr/LVUIuw7dOWbhUJrhT7ODy23fXoVmJKalr+z46YIGzgTkrRy9DvxIUhKvMWSdP2ycfHDxv7
 +qVHFgmAfq3iJUH9f2rnbyAw4/gV0BTiwCL5XfIt55IZq40mB0Eh4l2haq8mMkmzK1RdyMQvy
 6C8ykh7w264RqAwDmpQD1riTXPpx5GF9t/R4J4HofmnAHSMk/sxm1FFsQsCycaJjVHjHaopkq
 U+bFMIF0JCF6uroovo6LUP1ITNv7rhEnsbMTKd+JxNTkBfCerKx6W77eA/e+ffSm178Uav5Fh
 CNsbhJ0xbyyXbgp9BXbUWWI+Sr02Ht8VfK3/Ms4JsUilX/2iieABN1TtBVXJsYxubLZYtnYdl
 Snmd8+0g4mCJg+AEmnrpxMn/uYCAgh+9G0rS3m8GF5oNp40ZkEj7ZCulNbNNNBRsFHKlDfMPl
 I+GnWvegt5DXIhUagm3qe4+wMMe9fX22IJ1ggxllDEqov2W51hEb+F3RVa5J4WD5JDBHc+G9G
 Ci1WmgVPXxwKcSHEr3P3BJwaRecy1BTJ/OzDVGhykBEDYTNOP13pfW7P0SvqQ8Jy0fFVjza6z
 9J/DzelIPfWtD497F9RjOT9hTgaj831XJkdQX6iIoFuBaG1EkbebQAnr6GWlnb7hH5/l2JBd9
 KBauMoQ8GWoDA6glRibp51iR4ferIlEaUsoVL6sANYM3mEQxkhogRvkq3gvG2prN7MFGp7ASq
 NrOFedzAlnw1penR
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 18.10.2016 um 20:30 schrieb David Miller:
> From: Stefan Wahren <stefan.wahren@i2se.com>
> Date: Tue, 18 Oct 2016 13:27:34 +0200
>
>> +void
>> +qca_tty_receive(struct tty_struct *tty, const unsigned char *cp, char *fp,
>> +		int count)
>> +{
>> +	struct qcauart *qca = tty->disc_data;
>> +	struct net_device_stats *n_stats = &qca->net_dev->stats;
>> +	int dropped = 0;
> Please order local variable declarations from longest to shortest line.

Even if the current second init depends on the first one?