From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751536AbdCRLZb (ORCPT ); Sat, 18 Mar 2017 07:25:31 -0400 Received: from mx2.suse.de ([195.135.220.15]:39942 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751208AbdCRLZa (ORCPT ); Sat, 18 Mar 2017 07:25:30 -0400 Subject: Re: [PATCH v1 2/3] blk-mq: comment on races related with timeout handler To: Ming Lei , Jens Axboe , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Christoph Hellwig References: <20170317095711.5819-1-tom.leiming@gmail.com> <20170317095711.5819-3-tom.leiming@gmail.com> Cc: Yi Zhang , Bart Van Assche From: Hannes Reinecke Message-ID: Date: Sat, 18 Mar 2017 12:25:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170317095711.5819-3-tom.leiming@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/17/2017 10:57 AM, Ming Lei wrote: > This patch adds comment on two races related with > timeout handler: > > - requeue from queue busy vs. timeout > - rq free & reallocation vs. timeout > > Both the races themselves and current solution aren't > explicit enough, so add comments on them. > > Cc: Bart Van Assche > Signed-off-by: Ming Lei > --- > block/blk-mq.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)