From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56953C433FE for ; Thu, 14 Apr 2022 09:42:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240661AbiDNJoe (ORCPT ); Thu, 14 Apr 2022 05:44:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231321AbiDNJoc (ORCPT ); Thu, 14 Apr 2022 05:44:32 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0128718349; Thu, 14 Apr 2022 02:42:09 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B224921618; Thu, 14 Apr 2022 09:42:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1649929327; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xhIDvCKjfyFxJfvLw8YkmEsEs0zMe7xZBlVmf1UZvqc=; b=nWYLi6h3qRmu62qtpkfGuq7ABIO9ie/jO+FTUGkmm2jz8vHj2w5rhlVyB4Le99PDWR3FC/ RUzqsC6LbAjMzixr+DI/wM3McEFQkzpDljVea2RcUjaNKr+ftoZgZRrKZQI8Avd9/JRoZE qM8aKwrqcth6rMFZWvunRPL2AWwft88= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1649929327; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xhIDvCKjfyFxJfvLw8YkmEsEs0zMe7xZBlVmf1UZvqc=; b=gxOv7XA1s08yF06K7CRDDLSNiIcGAhlG2Mj5R37M08QywYdcPKGr/+TsYZ3mzAACTPZ/PN sbqcIijHZ0HTvIDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 852C513A86; Thu, 14 Apr 2022 09:42:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id lI+HH2/sV2JoaQAAMHmgww (envelope-from ); Thu, 14 Apr 2022 09:42:07 +0000 Message-ID: Date: Thu, 14 Apr 2022 11:42:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] scripts: dummy-tools, add pahole Content-Language: en-US To: Masahiro Yamada Cc: Linux Kernel Mailing List , Michal Marek , Nick Desaulniers , Linux Kbuild mailing list References: <20220414091419.7654-1-jslaby@suse.cz> From: Jiri Slaby In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14. 04. 22, 11:33, Masahiro Yamada wrote: > On Thu, Apr 14, 2022 at 6:14 PM Jiri Slaby wrote: >> >> CONFIG_PAHOLE_VERSION is a part of a config since the commit below. And >> when multiple people update the config, this value constantly changes. >> Even if they use dummy scripts. >> >> To fix this: >> * add a pahole dummy script returning v99.99 -> 9999 >> * call it in Makefile taking CROSS_COMPILE into account. >> >> The latter happens only if $(CROSS_COMPILE)pahole really exists. This is >> because a cross pahole likely exists only in dummy tools now, not in >> real cross tools. > > > I do not think this is the right thing to do. > > (As I said somewhere, I am opposed to checking pahole version in Kconfig). If you ask me, I am all for removal as this causes pain. But it's there, so I cannot do anything about that. > Also, $(CROSS_COMPILE)pahole looks insane. > > You can create a dummy pahole in your local system. > > $ echo 'echo v99.99' > $HOME/bin/dummy-pahole > $ chmod +x $HOME/bin/dummy-pahole > $ make CROSS_COMPILE=scripts/dummy-tools PAHOLE=dummy-pahole menuconfig Well, the question is how do I that for every kernel developer in SUSE? thanks, -- js suse labs