From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E24B2C4332F for ; Mon, 25 Oct 2021 14:22:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C722060F46 for ; Mon, 25 Oct 2021 14:22:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233502AbhJYOYj (ORCPT ); Mon, 25 Oct 2021 10:24:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44010 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233493AbhJYOYg (ORCPT ); Mon, 25 Oct 2021 10:24:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635171734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HpaqUtGVB++dG0RuCTiBEYznGy9v/KDIt/5yYlz7/xg=; b=AWDyRtmXaPlPbYzj8fAN5bBexxIM6tuTRoW6wwZGk+WGblmxKtG5MyTVuWylZenb9CA0CL i3pU9wOQo2Tirj2iPAchWCF5sByL4bwwPAHxREgMydhUAgJL4u0zMm8U0923aU6Y6Dtp1H x+tl8/aF8EeAZhDeHJmG5ZMxHB0IO/c= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-48-NILMiXqlMfigrGEAzqvmYA-1; Mon, 25 Oct 2021 10:22:13 -0400 X-MC-Unique: NILMiXqlMfigrGEAzqvmYA-1 Received: by mail-wr1-f70.google.com with SMTP id i3-20020a5d5223000000b00167f0515e90so2757365wra.4 for ; Mon, 25 Oct 2021 07:22:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=HpaqUtGVB++dG0RuCTiBEYznGy9v/KDIt/5yYlz7/xg=; b=vQbuWgJJOO6AiCIhbu8DfiBFh7mmJUEa7dY8kXEIigugBx+5SaKkysHm+UCMHGiLHI rxy4dz0ugGKm1rdBNzZqteJdkyf9JJwyqeOv5Npvx+v/d6qsLDIyp2Rn9raoiru7AGrL mWUTCng+Dd6q1L/pGmE+6vq6xRUrly3xuDTu4DVEkum97qPY2aXLbOQfDBLo67tRZics HJZtknNbZnAHSpMU+eXFihRAZPkuEn7D14GUaHKHcB7Cd8tbCPBVuDAyJU8z6X8RTqYP PTM8CdJatjdkAup2p+ykRq6Ih5k8zW0+WO/VOzTf7eTDu0EyDkvq0rifkbrbDD7pzY24 YZxg== X-Gm-Message-State: AOAM532si50eSTZm4ewl4IQ55GOi3h44qZJfKq7gTticUFrrtqPIAEVJ kGEJhNAopR3cLf2TbpJU6mPloYflAvfdhy14VmZ/9LbpSAf5f0AX9NpLtAPPwBOo/rpWDR4cML+ FpBIbewmxiAMVvJC+c6SJf91D X-Received: by 2002:adf:ef8f:: with SMTP id d15mr23887309wro.72.1635171731940; Mon, 25 Oct 2021 07:22:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzadqpNa9sRFm6T5pRsCXL5a0VdPZvR+Z2HC9JjGJpxIRL6ejj2cNhckiUN6d6SszWigGu00w== X-Received: by 2002:adf:ef8f:: with SMTP id d15mr23887262wro.72.1635171731758; Mon, 25 Oct 2021 07:22:11 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id v6sm2568505wrx.17.2021.10.25.07.22.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Oct 2021 07:22:10 -0700 (PDT) Message-ID: Date: Mon, 25 Oct 2021 16:22:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v2 37/43] KVM: SVM: Unconditionally mark AVIC as running on vCPU load (with APICv) Content-Language: en-US To: Sean Christopherson , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , Oliver Upton , Jing Zhang References: <20211009021236.4122790-1-seanjc@google.com> <20211009021236.4122790-38-seanjc@google.com> From: Paolo Bonzini In-Reply-To: <20211009021236.4122790-38-seanjc@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/10/21 04:12, Sean Christopherson wrote: > + /* TODO: Document why the unblocking path checks for updates. */ Is that a riddle or what? :) Paolo > + if (kvm_vcpu_is_blocking(vcpu) && > + kvm_check_request(KVM_REQ_APICV_UPDATE, vcpu)) { > + kvm_vcpu_update_apicv(vcpu); > + > + if (!kvm_vcpu_apicv_active(vcpu)) > + return; > + } > +