From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F8901D1F5B for ; Wed, 4 Sep 2024 11:43:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725450236; cv=none; b=nqlG8msPmQ8pSoYrQo6AYAND810mKI5cHY1TxXiTSujCLXFvUCJnImkV9ccKfghd+slD274n2P72u+/4dqBc0t8g+hXfLzBNvVY/vYkPO4UIs8mrboynti95vJxb7SSNoaPKjXhWjLIJDlYsO+GGqxVQlyhEgJK2t3DKQy0vD94= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725450236; c=relaxed/simple; bh=TcvvGUzUyW7y66QoYl9NDBgaKlbsu4UGU0sFU9wFjBw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=G65CVJ0YGndjcGCGKUxrNIHHnuR5IKJv7+vd7DeGh9bE2i6AsKGBigjsqlFDT4YDcEahIUiQKSq2u+Q0fl/cn2oRcj75FMuZ5/eOd1yYpo9C7MlyRdA0OrHwf/mNcyikcjNaHgXb37exf5BUJYVtR05OroIDGqTUW/UWa1SxbHU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mK2HEZW8; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mK2HEZW8" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a86a69bfcdaso37163966b.0 for ; Wed, 04 Sep 2024 04:43:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1725450233; x=1726055033; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=/59KpQl/ENj5YnZpXPnbSALUPXSSb5VrZ9vlG/9vrBQ=; b=mK2HEZW8wQpgglhp2jtn0eLt4O97fC84gi4uifiInt4nv/a/7+swAKhtGyhjZjZsoZ c2LCN7R+SQddz89FhnDxoqofTAgzG41Ll0DsQwcIcfTbRQ19itpRQBcjwUfCOx7pMciX j9QqGFUq9wcPZEhN1tjwQOr4Qwq4bc9VJ2TdganfUa37WnY0/Fw3T/0Nou4nZNJTxW/b qLBX4WhUYfqVkPDKCHBfsEtR7EsbFPJA6/Aktt0BwbhZ5cHXiqEHLLx5Uw6U9GSu7Tuy 5frmeN2+DxBMZgvyfx/IflBocPsZFKsiqNiznhDPEtgFSIQrBRtP/F/v5fWT58szTqI5 zLuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725450233; x=1726055033; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/59KpQl/ENj5YnZpXPnbSALUPXSSb5VrZ9vlG/9vrBQ=; b=OqT0RmKJpvQoWtAwVoCq48R9f+1v+B192a+LZtvw5SvVDV/7ouWOYNFWkB6KWsVVkX 1RRdHNmxAYo062HRFYtDTkT317OGvAMtAll5veTnOLWXX+7KI2sy/rOolAO3P+VHLzuR aqEjqkRW2qUnXydT67t3shjsNg1zBkk2Bl5xlAJXmXDm1jkDpmrjVyo61G87evDrbsjW jQoXUBeiaN5N1Clw91dhJUlWvhlR/NGQRE4gAW1WH0X6LTjhG9hYRS5NRrTWuKRvqNdD omEi14BJ28wo1BxR8JPvdswhgQ5FAY2i7T8ihBkFsjxDLrpsFtkBvFz5CXo7341Oq/oS Q3hQ== X-Forwarded-Encrypted: i=1; AJvYcCUfoHW9MFRpWlRXIbUMUYO/FIOq/AfGtrghgqynhsi/yweg60Ie6VtPimQQGr2eM6KLoHW1vz7SFGOXfRI=@vger.kernel.org X-Gm-Message-State: AOJu0Yypm+Tg24kLkeJPTUhNwsJv29xaaAHLpxoBCHCK+VVX5LxCyShi KHvhdBeZlXlQTkJ2XJB/jgbGL5LNABH85RGvU98XjXnmBuLi11/wyZuA4HydRvg= X-Google-Smtp-Source: AGHT+IGaWHDAbUbWROpXtvL3TzWtVqhkdhe/CfKY06N3Rz/z/TeQIlpyigCEhXFcyZnadufk631/bg== X-Received: by 2002:a17:907:eac:b0:a79:a1b8:257b with SMTP id a640c23a62f3a-a89a3958e1dmr522577966b.10.1725450232555; Wed, 04 Sep 2024 04:43:52 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.82]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8a1900d4fcsm266703266b.144.2024.09.04.04.43.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Sep 2024 04:43:51 -0700 (PDT) Message-ID: Date: Wed, 4 Sep 2024 13:43:50 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] soundwire: stream: fix programming slave ports for non-continous port maps To: "Liao, Bard" , "Liao, Bard" , Vinod Koul , Pierre-Louis Bossart Cc: "Kale, Sanyog R" , Shreyas NC , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" References: <20240729140157.326450-1-krzysztof.kozlowski@linaro.org> <095d7119-8221-450a-9616-2df6a0df4c77@linux.intel.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 03/09/2024 17:17, Liao, Bard wrote: >>> >>> then dpn_prop[0].num = 1 and dpn_prop[1].num = 3. And we need to go >>> >>> throuth dpn_prop[0] and dpn_prop[1] instead of dpn_prop[1] and >> dpn_prop[3]. >>> >> >> What are the source or sink ports in your case? Maybe you just generate >> wrong mask? > > I checked my mask is 0xa when I do aplay and it matches the sink_ports of > the rt722 codec. > >> >> It's not only my patch which uses for_each_set_bit(). sysfs_slave_dpn >> does the same. > > What sysfs_slave_dpn does is > i = 0; > for_each_set_bit(bit, &mask, 32) { > if (bit == N) { > return sprintf(buf, format_string, > dpn[i].field); > } > i++; > } > It uses a variable "i" to represent the array index of dpn[i]. > But, it is for_each_set_bit(i, &mask, 32) in your patch and the variable "i" > which represents each bit of the mask is used as the index of dpn_prop[i]. > > Again, the point is that the bits of mask is not the index of the dpn_prop[] > array. Yes, you are right. I think I cannot achieve my initial goal of using same dpn array with different indices. My patch should be reverted, I believe. I'll send a revert, sorry for the mess. Best regards, Krzysztof