From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Jason Yan <yanaijie@huawei.com>
Cc: axboe@kernel.dk, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: return true in ata_is_host_link()
Date: Mon, 1 Jun 2020 15:33:52 +0200 [thread overview]
Message-ID: <aceddd6f-0cb1-2fea-039d-767b7e50cf16@samsung.com> (raw)
In-Reply-To: <20200507110637.37341-1-yanaijie@huawei.com>
On 5/7/20 1:06 PM, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> include/linux/libata.h:1446:8-9: WARNING: return of 0/1 in function
> 'ata_is_host_link' with return type bool
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> include/linux/libata.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/libata.h b/include/linux/libata.h
> index 8bf5e59a7859..e05a8ed2e31e 100644
> --- a/include/linux/libata.h
> +++ b/include/linux/libata.h
> @@ -1443,7 +1443,7 @@ static inline bool sata_pmp_attached(struct ata_port *ap)
>
> static inline bool ata_is_host_link(const struct ata_link *link)
> {
> - return 1;
> + return true;
> }
> #endif /* CONFIG_SATA_PMP */
>
prev parent reply other threads:[~2020-06-01 13:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200507110752eucas1p21e8a1d127642c53440fe64c4a770e3f7@eucas1p2.samsung.com>
2020-05-07 11:06 ` Jason Yan
2020-06-01 13:33 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aceddd6f-0cb1-2fea-039d-767b7e50cf16@samsung.com \
--to=b.zolnierkie@samsung.com \
--cc=axboe@kernel.dk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®