From: Hans Zhang <18255117159@163.com>
To: lpieralisi@kernel.org
Cc: kw@linux.com, manivannan.sadhasivam@linaro.org, robh@kernel.org,
bhelgaas@google.com, bwawrzyn@cisco.com, cassel@kernel.org,
wojciech.jasko-EXT@continental-corporation.com, a-verma1@ti.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
rockswang7@gmail.com
Subject: Re: [PATCH] PCI: cadence: Fix sending message with data or without data
Date: Fri, 7 Feb 2025 18:58:54 +0800 [thread overview]
Message-ID: <acf18b4c-8ad5-48ea-9767-5383b138ca74@163.com> (raw)
In-Reply-To: <20250207103101.31287-1-18255117159@163.com>
On 2025/2/7 18:31, Hans Zhang wrote:
> From: "hans.zhang" <hans.zhang@cixtech.com>
I'm so sorry, guys.
The correct email address should be: Hans Zhang <18255117159@163.com>
> View from cdns document cdn_pcie_gen4_hpa_axi_ips_ug_v1.04.pdf.
> In section 9.1.7.1 AXI Subordinate to PCIe Address Translation
> Registers below:
>
> axi_s_awaddr bits 16 is 1 for MSG with data and 0 for MSG without data.
>
> Signed-off-by: hans.zhang <hans.zhang@cixtech.com>
The correct Signed-off should be: Hans Zhang <18255117159@163.com>
> ---
> drivers/pci/controller/cadence/pcie-cadence-ep.c | 3 +--
> drivers/pci/controller/cadence/pcie-cadence.h | 2 +-
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
>
> base-commit: bb066fe812d6fb3a9d01c073d9f1e2fd5a63403b
>
> diff --git a/drivers/pci/controller/cadence/pcie-cadence-ep.c b/drivers/pci/controller/cadence/pcie-cadence-ep.c
> index e0cc4560dfde..0bf4cde34f51 100644
> --- a/drivers/pci/controller/cadence/pcie-cadence-ep.c
> +++ b/drivers/pci/controller/cadence/pcie-cadence-ep.c
> @@ -352,8 +352,7 @@ static void cdns_pcie_ep_assert_intx(struct cdns_pcie_ep *ep, u8 fn, u8 intx,
> spin_unlock_irqrestore(&ep->lock, flags);
>
> offset = CDNS_PCIE_NORMAL_MSG_ROUTING(MSG_ROUTING_LOCAL) |
> - CDNS_PCIE_NORMAL_MSG_CODE(msg_code) |
> - CDNS_PCIE_MSG_NO_DATA;
> + CDNS_PCIE_NORMAL_MSG_CODE(msg_code);
> writel(0, ep->irq_cpu_addr + offset);
> }
>
> diff --git a/drivers/pci/controller/cadence/pcie-cadence.h b/drivers/pci/controller/cadence/pcie-cadence.h
> index f5eeff834ec1..39ee9945c903 100644
> --- a/drivers/pci/controller/cadence/pcie-cadence.h
> +++ b/drivers/pci/controller/cadence/pcie-cadence.h
> @@ -246,7 +246,7 @@ struct cdns_pcie_rp_ib_bar {
> #define CDNS_PCIE_NORMAL_MSG_CODE_MASK GENMASK(15, 8)
> #define CDNS_PCIE_NORMAL_MSG_CODE(code) \
> (((code) << 8) & CDNS_PCIE_NORMAL_MSG_CODE_MASK)
> -#define CDNS_PCIE_MSG_NO_DATA BIT(16)
> +#define CDNS_PCIE_MSG_DATA BIT(16)
>
> struct cdns_pcie;
>
prev parent reply other threads:[~2025-02-07 10:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 10:31 Hans Zhang
2025-02-07 10:58 ` Hans Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acf18b4c-8ad5-48ea-9767-5383b138ca74@163.com \
--to=18255117159@163.com \
--cc=a-verma1@ti.com \
--cc=bhelgaas@google.com \
--cc=bwawrzyn@cisco.com \
--cc=cassel@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=rockswang7@gmail.com \
--cc=wojciech.jasko-EXT@continental-corporation.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®