From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F26A43ACA7C for ; Thu, 9 Jul 2026 05:58:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.118.77.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783576709; cv=none; b=WYv371xfEq6pBdsEfKSFY2sEvn7s9ZFU3CpU4IiB9/S4PD3Ma9lRE/utWowQR1qrj8w9OQZkIWBc4InNh9x7A7CKFzv/DJMkoGUYx6sAe+rzcwrRyFUWscgRyk0m0XbxHQd5PbiKClCw0svzuIOpSDba2aPSjPCKP3DBWiWtkw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783576709; c=relaxed/simple; bh=e1uy12abMe0K1zcXLEGpML2PGqx8SdmUx1cVh7Cgp+4=; h=Message-ID:Date:MIME-Version:Subject:To:From:In-Reply-To: Content-Type:References; b=giT/dcntoQ0ZiEplL5zb1GY5ftvmToHF8ILMrqqk9CRaI9uVzuGM/pQxlTkjw/wnSlEJ1ijKTMjC9VOcOBFZjj44NpKNZDQN6fBfs/5Oex0MfBDx5GbwZdC7BtSDgktqp35R+Q50EmUHQMducrcJrWbPh+ulCTMZT2l+/u7AokU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=MP0U9dVq; arc=none smtp.client-ip=210.118.77.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="MP0U9dVq" Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20260709055826euoutp01f788dc527de58b0c22978f583bcaa1c1~AiZCC_Zf63035730357euoutp01F for ; Thu, 9 Jul 2026 05:58:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20260709055826euoutp01f788dc527de58b0c22978f583bcaa1c1~AiZCC_Zf63035730357euoutp01F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1783576706; bh=e/20LB1X5B9UIAsWQg9CIMjdnP2NH0A5ph1HNBiUb2s=; h=Date:Subject:To:From:In-Reply-To:References:From; b=MP0U9dVqd0CJ/AKGfokoSH+HtUqi77fLsv4ooUnMLRLkEVW0tt+jXfl0yWdmIpUGJ upEbXGDcCEnIU3YNrDZOzEG6Ltio6vHC9XqOye7xjt/+hljjXUwGfgPAdr/JC2J8Zv e8Ia4MK+cczbiSWiElCe1dyDhZnBlpujrqV4VtvE= Received: from eusmtip2.samsung.com (unknown [203.254.199.222]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20260709055825eucas1p1ef36374810c89ada4c37e20ca5d1ad95~AiZBu4Rxl0814308143eucas1p1K; Thu, 9 Jul 2026 05:58:25 +0000 (GMT) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20260709055825eusmtip2279b9fd8bc2ef0e07e96e965ed7a6765~AiZBBEbra0301703017eusmtip2S; Thu, 9 Jul 2026 05:58:25 +0000 (GMT) Message-ID: Date: Thu, 9 Jul 2026 07:58:24 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Betterbird (Windows) Subject: Re: [PATCH 1/5] ARM: dma-mapping: Treat bitmap size as allocation failure To: Yury Norov , Russell King , Jason Gunthorpe , Danilo Krummrich , Leon Romanovsky , "Matthew Wilcox (Oracle)" , Douglas Anderson , Kees Cook , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Language: en-US From: Marek Szyprowski In-Reply-To: <20260709020312.133977-2-ynorov@nvidia.com> Content-Transfer-Encoding: 7bit X-CMS-MailID: 20260709055825eucas1p1ef36374810c89ada4c37e20ca5d1ad95 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20260709020326eucas1p26246ea775b0aaf1f799ac14a3a691c2d X-EPHeader: CA X-CMS-RootMailID: 20260709020326eucas1p26246ea775b0aaf1f799ac14a3a691c2d References: <20260709020312.133977-1-ynorov@nvidia.com> <20260709020312.133977-2-ynorov@nvidia.com> On 09.07.2026 04:03, Yury Norov wrote: > bitmap_find_next_zero_area() uses an out-of-range return value to > indicate failure. Check for values greater than or equal to the bitmap > size so the caller does not depend on the exact failure sentinel. > > Signed-off-by: Yury Norov Acked-by: Marek Szyprowski > --- > arch/arm/mm/dma-mapping.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c > index f9bc53b60f99..7761099dde9e 100644 > --- a/arch/arm/mm/dma-mapping.c > +++ b/arch/arm/mm/dma-mapping.c > @@ -773,7 +773,7 @@ static inline dma_addr_t __alloc_iova(struct dma_iommu_mapping *mapping, > start = bitmap_find_next_zero_area(mapping->bitmaps[i], > mapping->bits, 0, count, align); > > - if (start > mapping->bits) > + if (start >= mapping->bits) > continue; > > bitmap_set(mapping->bitmaps[i], start, count); > @@ -794,7 +794,7 @@ static inline dma_addr_t __alloc_iova(struct dma_iommu_mapping *mapping, > start = bitmap_find_next_zero_area(mapping->bitmaps[i], > mapping->bits, 0, count, align); > > - if (start > mapping->bits) { > + if (start >= mapping->bits) { > spin_unlock_irqrestore(&mapping->lock, flags); > return DMA_MAPPING_ERROR; > } Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland