From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0586FC77B7C for ; Mon, 29 May 2023 00:37:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230518AbjE2Aha (ORCPT ); Sun, 28 May 2023 20:37:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbjE2Ah2 (ORCPT ); Sun, 28 May 2023 20:37:28 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 585F0B9 for ; Sun, 28 May 2023 17:37:26 -0700 (PDT) Received: from dggpemm500006.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4QTxM44DJyz18Lc8; Mon, 29 May 2023 08:32:48 +0800 (CST) Received: from [10.174.178.55] (10.174.178.55) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 29 May 2023 08:37:23 +0800 Subject: Re: [PATCH 5/6] kexec: add helper __crash_shrink_memory() To: kernel test robot , Eric Biederman , Baoquan He , , CC: , , Michael Holzheu , Andrew Morton , Linux Memory Management List , Amerigo Wang References: <20230527123439.772-6-thunder.leizhen@huawei.com> <202305280717.Pw06aLkz-lkp@intel.com> From: "Leizhen (ThunderTown)" Message-ID: Date: Mon, 29 May 2023 08:37:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <202305280717.Pw06aLkz-lkp@intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.55] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/5/28 8:08, kernel test robot wrote: > Hi Zhen, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on akpm-mm/mm-everything] > [also build test WARNING on linus/master v6.4-rc3 next-20230525] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Zhen-Lei/kexec-fix-a-memory-leak-in-crash_shrink_memory/20230527-203821 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > patch link: https://lore.kernel.org/r/20230527123439.772-6-thunder.leizhen%40huawei.com > patch subject: [PATCH 5/6] kexec: add helper __crash_shrink_memory() > config: riscv-randconfig-r042-20230526 (https://download.01.org/0day-ci/archive/20230528/202305280717.Pw06aLkz-lkp@intel.com/config) > compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 4faf3aaf28226a4e950c103a14f6fc1d1fdabb1b) > reproduce (this is a W=1 build): > mkdir -p ~/bin > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install riscv cross compiling tool for clang build > # apt-get install binutils-riscv64-linux-gnu > # https://github.com/intel-lab-lkp/linux/commit/dea97cef503d26e05d0e11818ae44176056ddf64 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Zhen-Lei/kexec-fix-a-memory-leak-in-crash_shrink_memory/20230527-203821 > git checkout dea97cef503d26e05d0e11818ae44176056ddf64 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=riscv olddefconfig > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202305280717.Pw06aLkz-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > >>> kernel/kexec_core.c:1108:5: warning: no previous prototype for function '__crash_shrink_memory' [-Wmissing-prototypes] > int __crash_shrink_memory(struct resource *old_res, unsigned long new_size) > ^ > kernel/kexec_core.c:1108:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > int __crash_shrink_memory(struct resource *old_res, unsigned long new_size) > ^ > static > 1 warning generated. Yes, thanks, a 'static' should be added. > > > vim +/__crash_shrink_memory +1108 kernel/kexec_core.c > > 1107 >> 1108 int __crash_shrink_memory(struct resource *old_res, unsigned long new_size) > 1109 { > 1110 struct resource *ram_res; > 1111 > 1112 ram_res = kzalloc(sizeof(*ram_res), GFP_KERNEL); > 1113 if (!ram_res) > 1114 return -ENOMEM; > 1115 > 1116 ram_res->start = old_res->start + new_size; > 1117 ram_res->end = old_res->end; > 1118 ram_res->flags = IORESOURCE_BUSY | IORESOURCE_SYSTEM_RAM; > 1119 ram_res->name = "System RAM"; > 1120 > 1121 if (!new_size) { > 1122 release_resource(old_res); > 1123 old_res->start = 0; > 1124 old_res->end = 0; > 1125 } else { > 1126 crashk_res.end = ram_res->start - 1; > 1127 } > 1128 > 1129 crash_free_reserved_phys_range(ram_res->start, ram_res->end); > 1130 insert_resource(&iomem_resource, ram_res); > 1131 > 1132 return 0; > 1133 } > 1134 > -- Regards, Zhen Lei