From: Jiping Ma <Jiping.Ma2@windriver.com>
To: Rob Herring <robh@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dtc: also check <yaml.h> for libyaml
Date: Tue, 9 Jun 2020 09:00:37 +0800 [thread overview]
Message-ID: <acfc88fc-2a7e-19fe-3dc4-37a03ddabcf9@windriver.com> (raw)
In-Reply-To: <CAL_JsqKLfSE5tPEPi1=erqBzCF9fceKKDe4qBkywB4O_JhbjGg@mail.gmail.com>
On 06/09/2020 03:09 AM, Rob Herring wrote:
> On Mon, Jun 8, 2020 at 2:42 AM Jiping Ma <jiping.ma2@windriver.com> wrote:
>> yamltree.c includes <yaml.h>, If /usr/include/yaml.h does not exist,
>> it fails to build.
> Does this patch fix your issue?:
>
> https://lore.kernel.org/linux-devicetree/20200505100319.741454-1-masahiroy@kernel.org/
No, it did not fix the issue.
$ pkg-config --cflags yaml-0.1
$ pkg-config yaml-0.1 --libs
-L/buildarea/jma1/wr-19-0518/19.45/sysroots/aarch64-wrs-linux/usr/lib64
-lyaml
>
>
>> Signed-off-by: Jiping Ma <jiping.ma2@windriver.com>
>> ---
>> scripts/dtc/Makefile | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/scripts/dtc/Makefile b/scripts/dtc/Makefile
>> index b5a5b1c..b49dfea 100644
>> --- a/scripts/dtc/Makefile
>> +++ b/scripts/dtc/Makefile
>> @@ -18,9 +18,13 @@ $(error dtc needs libyaml for DT schema validation support. \
>> endif
>> HOST_EXTRACFLAGS += -DNO_YAML
>> else
>> +ifeq ($(wildcard /usr/include/yaml.h),)
>> +HOST_EXTRACFLAGS += -DNO_YAML
>> +else
>> dtc-objs += yamltree.o
>> HOSTLDLIBS_dtc := $(shell pkg-config yaml-0.1 --libs)
>> endif
>> +endif
>>
>> # Generated files need one more search path to include headers in source tree
>> HOSTCFLAGS_dtc-lexer.lex.o := -I $(srctree)/$(src)
>> --
>> 1.9.1
>>
next prev parent reply other threads:[~2020-06-09 1:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 8:41 Jiping Ma
2020-06-08 19:09 ` Rob Herring
2020-06-09 1:00 ` Jiping Ma [this message]
2020-06-09 2:43 ` Masahiro Yamada
2020-06-09 2:52 ` Masahiro Yamada
2020-06-09 3:07 ` Jiping Ma
2020-06-10 0:28 ` Masahiro Yamada
2020-06-10 1:12 ` Jiping Ma
2020-06-10 1:31 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acfc88fc-2a7e-19fe-3dc4-37a03ddabcf9@windriver.com \
--to=jiping.ma2@windriver.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®