From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f173.google.com (mail-dy1-f173.google.com [74.125.82.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DECD61DEFE8 for ; Sun, 29 Mar 2026 14:25:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774794318; cv=none; b=osOmhVgtLJo5jGGAYoEHPd6z2MSFwlmS2xZvZbNq6jrPoKShWZrG+3TGuO/Lbi7oWMUSAb2fPY4y2lD/j0oj0rcQ7kQIdA1PEzu4jxTJ5SdI4dkdbmUfYz1z6hvgx6yuiWvCyhshBT98lDbbXj1KzqptmXYLH8xhmP43hxLI700= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774794318; c=relaxed/simple; bh=k0MR+sEg7BG98cHvppZlvtZ+mvBFLKhJ9cJteQsw1cs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VlElLzsvMv+eoA4aQF7XoJtCkC+X9tBKSTJlBY6dFug0pJJKtTnLZPvjAGezannOYB9+DrRFmK3OBbKeOyVQ6LHXjc4kbdHvOCuntrfVUREtRXPvz61SnLeRR7uVhvYP4a7Q3JPyTUUZjeFS5J7DaK6eQ1Cr3ecGEjobYj56k/0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=otYB9V4B; arc=none smtp.client-ip=74.125.82.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="otYB9V4B" Received: by mail-dy1-f173.google.com with SMTP id 5a478bee46e88-2ba9c484e5eso3166339eec.1 for ; Sun, 29 Mar 2026 07:25:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774794316; x=1775399116; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=K7jZAm3dfhoBdqrOFQ8/Yd7Si3TepRvXWt/kcVJ4rT8=; b=otYB9V4Bpus1+9+Dc3ghJnUXQfMyf1YqQn7KNkj4u55wgUEM1zEhFV+HKBYd2LVppT zFDzJ9K5JesdPJ7x+LxMGH6NZxkB/Bk6zJ01xboXZoqfZHhbgkPPKJoJIzBmNBba6q3f PMdwcC5dc0vVmJBRkDdL2Ab3kiRvSx0RlnMA5PBdLr6C0hg2c47lKanNSAVYKIJq/3zj P2echT29rN7trYoRvb9bihz/ZmKQ2iokVH/D/u5FN6h6WK7k8AsM5jM48XoR4+6G1qGV EunX32H5qJO1SmVbR3OYewJAb/p8WQRABKveoM1FpjohEa1+rubHr5Vwbas8ptXcriMm E5kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774794316; x=1775399116; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K7jZAm3dfhoBdqrOFQ8/Yd7Si3TepRvXWt/kcVJ4rT8=; b=egFF7SilAESW9jQoW5b0KO5NIRI7tsT1wnE4sQgj5vLCJfZk975hjIlUt7/iEqCdY1 eLEUQQ66xI/r3Qa16X0EdITi2mLRSI+v36VsXV9rN74vAMrVIJSiAUAt+myKSfr2f9zB gGtYqz6yw1Wy+PEh1+kZoMan5XVg7kJFwDZDD+2DVDtJpLWxfruKxoXXNHix+MIqt+PZ Vy9APeABSP9ekFQOIy9QhKfYM2FAV+c1hfvH4/paaHYzC9k+Q/no6z98HRaxBli10fHw v6V4B+MTJzNan5BIQYIvqQwArl4MwJd3ZSYf7QmQjSMpRAXivhT2ZeFc1K4jVvQSVQ4J HKIA== X-Forwarded-Encrypted: i=1; AJvYcCV+20E5SO1kdTA+1/WxxAgryoGx3g71kXQSHvbr+OMHLfCzn9IKGDt4A7OHrpsfzYfqUoqKK0qZAkJV2is=@vger.kernel.org X-Gm-Message-State: AOJu0Ywx0Ir/NfiW/Sn71CrkQPR+hwSUpswuwNh/jWrx+iGzMnJR8k1O GJHGTy1gjMvOJC2T0Y+kvbOw/Q5YxBPyf4BJN1nDVPI/sVzyph88iWZnQ1IXRQ== X-Gm-Gg: ATEYQzwbtvP/L4H+lK1GPnxquvgPqG3i6s4av80wWRoOq+P16v6/eTtYcqncT631JzF DbUWZBn9JpVXQl7Blhy86JgFFpTF5KE7+A0AGR9Ku8cBtbV9oHNuLnOQeqUVggM//DLGVKjvLiS whxE4ZlIKhwbfLQn4l1mOtiZ22lSIEDVi+yEGFCk3x5pk+yYTYKjs+X+Akiz3kcMrM57sspJVZ3 eHV4UqrXV57oPV5bj9bQrz0Mq/qUZl3CtxTIHR+TKmf9lvRpfVSAjkeyt7o6VyMeQLVBheqIy/3 HN32yHs4W06V7iSqgblFi9634A8hqAC1yAtrQsSRK82lQjzhEm1yuEfLRTTwLoTryjgl/G6cNPs kxig8gzuIuTrPjVDcFL1U5JObFsYHxX7/HDsUsdODBjBpYPQW/DVtx46U8w3c9Vuxw/L2ooB9+v vvvEBlL83bQz8z6xmKRfe/HQTDRl3JyXM= X-Received: by 2002:a05:7300:d705:b0:2be:2acf:4098 with SMTP id 5a478bee46e88-2c185e7fb82mr4580049eec.31.1774794315783; Sun, 29 Mar 2026 07:25:15 -0700 (PDT) Received: from localhost ([2804:30c:979:9b00:9cc3:5a7a:e884:2060]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c3c796d895sm4457793eec.28.2026.03.29.07.25.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2026 07:25:14 -0700 (PDT) Date: Sun, 29 Mar 2026 11:25:56 -0300 From: Marcelo Schmitt To: charles-antoine.couret@mind.be Cc: broonie@kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2 v2] spi: add SPI_MOSI_IDLE_LOW support from device tree Message-ID: References: <20260329125725.2984756-1-charles-antoine.couret@mind.be> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260329125725.2984756-1-charles-antoine.couret@mind.be> Hello Charles-Antoine, On 03/29, charles-antoine.couret@mind.be wrote: > From: Charles-Antoine Couret > > This flag was introduced but was not added as device tree property which is > limiting the possibility to use this flag on real devices. I'm not seeing why a device tree property is needed for SPI idle modes. For idling high, the configuration is requested through spi_setup(). It should work in similar way for idling low. See spi-summary.rst. If believe a dt property is needed despite the spi_setup() interface, can you elaborate on why? > > This flag can be configured as done for other flags. > > Signed-off-by: Charles-Antoine Couret > --- > drivers/spi/spi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c > index 9b1125556d29..489a64e20305 100644 > --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > @@ -2363,6 +2363,8 @@ static int of_spi_parse_dt(struct spi_controller *ctlr, struct spi_device *spi, > spi->mode |= SPI_LSB_FIRST; > if (of_property_read_bool(nc, "spi-cs-high")) > spi->mode |= SPI_CS_HIGH; > + if (of_property_read_bool(nc, "spi-mosi-idle-low")) > + spi->mode |= SPI_MOSI_IDLE_LOW; > > /* Device DUAL/QUAD mode */ > > -- > 2.53.0 > > With best regards, Marcelo