From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF435285CA4; Sun, 29 Mar 2026 11:50:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774785007; cv=none; b=nj+oRifpt/GaYLocEvKfSe+qUzdq/jG4IDKFdRaThuuf07yGUUadGbsHdn6iLDOB5OnSALVghTWn4X+h4zfgRo/FF3+vkEke5KUWu8rguXbJJ5aa9oKMVyw6GumDchqogTDq9FWlCqtuoHVuo7DeyOj/F1je2+fm5qF3LqWk4NA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774785007; c=relaxed/simple; bh=O7l6ak4xT7cXmqRnv4fc6BGKQgIBxzW99MT7EQs0/sc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BUZU1MSQtethxdTryzGQOWkKkYayIWKZT/STWYow/pvsce3ckSDa96IKwVl08J6ytfEPVnPCTzPMuyu0JQvqY7eWzuMyKbnXBd7nG6Jqnr5F4mLJJFaE1V0OobO6UVMwmZIp88nFEQlHiTRpEVBihdMYb0n9RqUuYt48Qp6kdw8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=C3sKWJtV; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="C3sKWJtV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774785006; x=1806321006; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=O7l6ak4xT7cXmqRnv4fc6BGKQgIBxzW99MT7EQs0/sc=; b=C3sKWJtVnwXpL1lypRdAdR76iOjSwgmq6+ngKXFCIMiTjBV/ADwQqbsx shQuta1if3nYaFCbMUYAe/FyKo+nQjR4lXczSAmALCF4heNpWJy+PsUot nUSmgSzeL79t4RuenlYYdR0IsBU5AYwtsrynLHGoHWqMFbntxNbxZsDYP 3Zx/MjivojYyn7A6zy7TRn+qxY7eysdnwx+cT3cQ6YRsCHdfA8EZEc/4t vrZMrb86RDmJsOzxDHO8z2/CS8TfUenVl7Ccr5276zcPpSpXWgbGiFBDJ XrnNkccsytElNMHJtfkMniXff8uWBxkriP3PU51qBIfNXNj6Q47HuYOSS A==; X-CSE-ConnectionGUID: AcJzY4M0RiexTzjd4y7+iQ== X-CSE-MsgGUID: VNpS4k7eTVCHgAo+EYzCGQ== X-IronPort-AV: E=McAfee;i="6800,10657,11742"; a="75505198" X-IronPort-AV: E=Sophos;i="6.23,148,1770624000"; d="scan'208";a="75505198" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2026 04:50:05 -0700 X-CSE-ConnectionGUID: Eac3bGOiSs+hvqllPRxdgg== X-CSE-MsgGUID: 6JZe9bwLTSGA9q6CN5UDzA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,148,1770624000"; d="scan'208";a="225675186" Received: from klitkey1-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.29]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2026 04:50:02 -0700 Date: Sun, 29 Mar 2026 14:49:59 +0300 From: Andy Shevchenko To: Bartosz Golaszewski , Heikki Krogerus Cc: Aaro Koskinen , Janusz Krzysztofik , Arnd Bergmann , Bartosz Golaszewski , Tony Lindgren , Russell King , Dmitry Torokhov , Hans de Goede , Linux-OMAP , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kevin Hilman Subject: Re: [RFT PATCH v3] ARM: omap1: enable real software node lookup of GPIOs on Nokia 770 Message-ID: References: <20260212112508.73500-1-bartosz.golaszewski@oss.qualcomm.com> <2fb42d16-887a-4564-8e50-c9d6db564c4e@app.fastmail.com> <7h1phxpzml.fsf@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo +Cc: Heikki, the author of the code in question. On Fri, Mar 27, 2026 at 06:23:29PM +0100, Bartosz Golaszewski wrote: > On Fri, Mar 27, 2026 at 5:59 PM Aaro Koskinen wrote: > > On Fri, Mar 27, 2026 at 03:22:12PM +0100, Bartosz Golaszewski wrote: > > > Hmm, I'm wondering if there's a race with consumers already requesting > > > the GPIOs after the controller device is registered but before the > > > software node is added. I'll send a version with software nodes being > > > registered first, then passes as firmware nodes to the platform device > > > API before the device is registered. > > > > It crashes early, I was able to get an UART log from OSK (another > > 16xx board): > > > > [ 1.001525] Register r12 information: 2-page vmalloc region starting at 0xc2808000 allocated at kernel_clone+0xa4/0x20c > > [ 1.013092] Process swapper/0 (pid: 1, stack limit = 0x(ptrval)) > > [ 1.019500] Stack: (0xc2809ed0 to 0xc280a000) > > [ 1.024230] 9ec0: c072d000 c0529474 c06b3aa0 c050a3cc > > [ 1.032958] 9ee0: c072d000 c085c000 00000002 c052582c c050a324 c072d000 00000000 c0503160 > > [ 1.041687] 9f00: 00002710 00000000 c04da8f8 c0060900 c2809f64 ffffffff 00010000 946f70b5 > > [ 1.050384] 9f20: 00000062 c0816120 00000002 c052582c c0525848 c072d000 c04da8f8 c0060a18 > > [ 1.059112] 9f40: c2809f64 c2809f64 00000000 946f70b5 00000062 c0816120 00000002 c052582c > > [ 1.067810] 9f60: c052584c c072d000 c04da8f8 c050352c 00000002 00000002 00000000 c0502400 > > [ 1.076507] 9f80: c2809f7c 00000000 c03f86f4 00000000 00000000 00000000 00000000 00000000 > > [ 1.085205] 9fa0: 00000000 c03f8704 00000000 c000850c 00000000 00000000 00000000 00000000 > > [ 1.093902] 9fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 > > [ 1.102600] 9fe0: 00000000 00000000 00000000 00000000 00000013 00000000 00000000 00000000 > > [ 1.111206] Call trace: > > [ 1.111328] software_node_to_swnode from device_add_software_node+0x20/0x80 > > [ 1.121704] device_add_software_node from omap16xx_gpio_init+0xa8/0xe4 > > [ 1.128997] omap16xx_gpio_init from do_one_initcall+0x68/0x1f4 > > [ 1.135620] do_one_initcall from kernel_init_freeable+0x1ec/0x240 > > [ 1.142517] kernel_init_freeable from kernel_init+0x10/0x108 > > [ 1.148864] kernel_init from ret_from_fork+0x14/0x28 > > [ 1.154357] Exception stack(0xc2809fb0 to 0xc2809ff8) > > [ 1.159820] 9fa0: 00000000 00000000 00000000 00000000 > > [ 1.168518] 9fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 > > [ 1.177185] 9fe0: 00000000 00000000 00000000 00000000 00000013 00000000 > > [ 1.184295] Code: e3500000 012fff1e e59f3034 e5932000 (e5923000) > > [ 1.191040] ---[ end trace 0000000000000000 ]--- > > [ 1.196350] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b > > [ 1.204559] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b ]--- > > Thanks. This makes sense. Both omap16xx_gpio_init() and > software_node_init() run as postcore_initcall() so if the order is not > right, it will fail. > > Cc'ing Andy who's a reviewer for software nodes. Andy: is there any > reason to run software_node_init() as a postcore initcall? It only > allocates the kset, can we move it to core_initcall() by any chance? Good question. I don't know why it's chosen like this. Let ask Heikki, who is the author of the code. -- With Best Regards, Andy Shevchenko