From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EC093B47E7 for ; Mon, 30 Mar 2026 09:35:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774863320; cv=none; b=nLxrxC87FKoiHBYT82qkNzPr9NJUMVemMFr/YQvJ5wSlkAQseo6F1r+Mw+5VaEaOiNeGRCJXUhuf2cdoTBdd/YJevGhjBgPGip4T7pvpKXxnwchHyelTGvIA9ro99+gmn3zQoubhDKEBFd6GKzpkifaI+fNcH0v3Z6wFMf050rQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774863320; c=relaxed/simple; bh=oqL8KTAVeI89MSUR/JDMV5gcYvqcwOuXTzWifCo5Goc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KvVqfxTXEHGYEV2iWgq3Iuv7ckJCWvpfU+tWLweJT8rGPQZFItec+NdSS3GyF0dbR/JlNjfZ9ylzbQfVjyLzMzLk2FTElMreYHAyStGVAKBehxV9yGd1ZA0hvY6Q/37jWJeSJusQJpbuN92tq+mI4Tio6cT0bBqlrulk4teX0M8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nZlev8jf; arc=none smtp.client-ip=209.85.208.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nZlev8jf" Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-38b3ee785a5so35632371fa.1 for ; Mon, 30 Mar 2026 02:35:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774863317; x=1775468117; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2CeYbJA2Y2YytuXwRpPBoi6eaTAmSPql9/G5DPRWijE=; b=nZlev8jfo6qKQ9oIqEoImzoiKr0DVqmHvG1dhR7TwP80aovsVa5ZwoxYwj0vEwzeTQ JuzRPhMC8qdydnpMU0hGm3IsFnji5K6hpAuqLbGDPXPs08+oqPoXoJLo2j8BcwozBIam acuepxvMXAvsnwoiMA66dpvaT40B/LnGFQhcfKA2Rrc5oeErlOC9e/4JGvlrPYQWxG7T NycNqgreZhawtdljA5LXJMuz1XvXibVXMoKg6RdBlXEp9Pyjmlhmc5YEON6TxhTdCYn2 Bz+s9VcowDAZCRKl7gOu4JGik7r2C8Tv7T5XLmujTIg5xeRaQ7CKu5ITY7E7X1B+x1G9 4Qow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774863317; x=1775468117; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2CeYbJA2Y2YytuXwRpPBoi6eaTAmSPql9/G5DPRWijE=; b=Jtk2GW4aaDBuebgmHqbIAXN/CQhk6fzDptxzo0vN4uZ/2/RhWPfLptQuFrwPOU7qw2 Z8XuPNH4JiydQI+JPFzgUsScikzCQIFXdpvekPvX7mXt2tfUyWu67jrf1UWTCUPnIVRp msgg4DZWWgW1MA47M9Hk1zOGLGLa+qbdv+llon+nPGVTNl0aIjISNug1IoUP7Q/X/drZ dSCv7/ojXDazRfncO+DNj4iNdBJIHaur7pDMumHkXUOpHiTHs7bphY7PvZMg/5sff9Gc CSegLY8QVY0opnUXCRam5LsLmuzxBcH1bPk6aR0JeJyCzMYHk+muJYSFxwDwcmaNMTrb 5nOA== X-Forwarded-Encrypted: i=1; AJvYcCXvfgBmzNcaurfGk1o2w83DHuUIJCivcqlpqUWBnYGOlqVO3kyn3YOKFjGJHqBFk4LlFhZJgryg1R4FB2I=@vger.kernel.org X-Gm-Message-State: AOJu0YymSC9gYIDFt/nmep+6vtYGX0ty4XBu/MjTW+G0KF8Ukcj5ilwR daS5pS8gzV6iZ/vgcWO4zQIuE+K05BfUg5wuJBWc+nwFvEgdiWfOIDe9 X-Gm-Gg: ATEYQzxjsv6oecIHQG4zhXNRi04Ynk5+gGEMno7JZcRZ8VbiJVOjVSagXTdbOnoGG7/ XbpU0xPHbRVl/CmttC23c2gCbl3IrPcA7iNUONxDH/SY9xHlp1H+DdaMIJVR9xwLRgXNEYZAfsL lYS7mUI0AV6FVvxZcOwlpzXBn6/xDyqPeVAqxUHMd7ix4GQDI5FL+eqMah1iNDBmjVwLfOQTIbm 2YlibUgnPNQDkihDUlgkSkYIGAYytFuk8OlzBG09FbyjopM5MV2MW1QcIXi/pBr1AWRxE2iUFEu EVaOpd84BKWiCMsTubIJ694U232S32WDFBIQZYk9gdp5QmSQnpRCziOpvOJYTZc/6DwKDMVrC11 Mr65xSbu5me8Dydj+0bbeh4l/PRzltugqfYr/SfSahFuGe0CCRlM3MS0/ELN3UeBAF5pwg2TaBM nUHbHkRAQqxVBL/LcIrvQdZrg7tSu+Eg== X-Received: by 2002:a05:651c:1b12:b0:38b:f0f0:e39b with SMTP id 38308e7fff4ca-38c75c5ef7emr39088441fa.10.1774863316974; Mon, 30 Mar 2026 02:35:16 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38c836d463bsm15395231fa.4.2026.03.30.02.35.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 02:35:16 -0700 (PDT) Date: Mon, 30 Mar 2026 12:35:13 +0300 From: Dan Carpenter To: Mashiro Chen Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] staging: rtl8723bs: fix logic bug in WRITEEF4BYTE macro Message-ID: References: <20260328142709.330401-1-mashiro.chen@mailbox.org> <20260328142709.330401-2-mashiro.chen@mailbox.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260328142709.330401-2-mashiro.chen@mailbox.org> On Sat, Mar 28, 2026 at 10:27:06PM +0800, Mashiro Chen wrote: > The WRITEEF4BYTE macro incorrectly used EF2BYTE for > 4-byte memory writes. Fix it to use EF4BYTE instead. > > Signed-off-by: Mashiro Chen > --- > drivers/staging/rtl8723bs/include/basic_types.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/include/basic_types.h b/drivers/staging/rtl8723bs/include/basic_types.h > index 8adb95f9f..99b12c724 100644 > --- a/drivers/staging/rtl8723bs/include/basic_types.h > +++ b/drivers/staging/rtl8723bs/include/basic_types.h > @@ -64,7 +64,7 @@ > > #define WRITEEF4BYTE(_ptr, _val) \ This macro is never used so just delete it instead. regards, dan carpenter > do { \ > - (*((u32 *)(_ptr))) = EF2BYTE(_val); \ > + (*((u32 *)(_ptr))) = EF4BYTE(_val); \ > } while (0) > > /* > -- > 2.53.0 >