From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B150249EB for ; Mon, 30 Mar 2026 01:14:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774833283; cv=none; b=JRBqwBGiBdWMzMChf41w4vhm/OR99eRk7C6CWGFW4WtTMvRnj1N75kgF8wCTP9FY7PffP7WiBQNL2dX1oozkCsLBbLE14+heQs9mA6Ob78ZmLt8Sr165v2ThNoBSwP2WMXiRO7bmc9tNYgakdpi0F7ZeYNz4Djj0Ex29tUVTNeY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774833283; c=relaxed/simple; bh=/7Ah5Z1SHMv8GNRrUzsyDmEAabM4k91FZBwln3xVPjo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=g41500fkd6dPpK+K1HC8ZWgiBeXpZpH02uzKl+qsfIbFKgzEZi3BGHpyKmA5OV/P3V6zLpbIxvp6rl+CkvySVCHycQyu/zcDJol4DPg0/h9BZsFv9lxmYrHYxINS4d+Bokflfv1u4SSsSE9Ffbd0qEa0apEqyg8PgU+YWfseQog= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IYiJrErn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IYiJrErn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79F4DC116C6; Mon, 30 Mar 2026 01:14:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774833282; bh=/7Ah5Z1SHMv8GNRrUzsyDmEAabM4k91FZBwln3xVPjo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IYiJrErnEQtj4VKVHg9arGLvc5YcEblwezF0skuNGBch+e+dPjfRzy2zGe/vKAE8n oBb2fhlNZcR2TBRYJEz0+Wm5I96MNdyRxpy/idA5zk4qt5LuO7uWYaTBSlk0ZOP+Fv V45XM3qLh8wPrVYSjNDL1eVBPyzCYQ4Xh+YVCG82SRrEMNdx3iAOpsjI/LlUBR4D+4 V+yTRtkCDD/WGA4Y84PwmO30LPadgjoFeTPdm505StBqZzNYrkaPum9Mv90LSzaCf1 VOVnKXMwNImqT6rdsH4uYXqyIhNiIBH466qgL4O4JOAYU03YH/oEEjvOMNqBoOj9Hc 7myEjjq3zafag== Date: Mon, 30 Mar 2026 10:14:40 +0900 From: "Harry Yoo (Oracle)" To: Qi Zheng Cc: hannes@cmpxchg.org, hughd@google.com, mhocko@suse.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, david@kernel.org, ljs@kernel.org, ziy@nvidia.com, yosry.ahmed@linux.dev, imran.f.khan@oracle.com, kamalesh.babulal@oracle.com, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, chenridong@huaweicloud.com, mkoutny@suse.com, akpm@linux-foundation.org, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com, lance.yang@linux.dev, bhe@redhat.com, usamaarif642@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Qi Zheng Subject: Re: [PATCH v3 1/3] mm: memcontrol: correct the type of stats_updates to unsigned long Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Mar 27, 2026 at 06:16:28PM +0800, Qi Zheng wrote: > From: Qi Zheng > > The memcg_rstat_updated() tracks updates for vmstats_percpu->state > and lruvec_stats_percpu->state. Since these state values are of type long, > change the val parameter passed to memcg_rstat_updated() to long as well. > > Correspondingly, change the type of stats_updates in struct > memcg_vmstats_percpu and struct memcg_vmstats from unsigned int and > atomic_t to unsigned long and atomic_long_t respectively to prevent > potential overflow when handling large state updates during the > reparenting of LRU folios. > > Signed-off-by: Qi Zheng > Reviewed-by: Lorenzo Stoakes (Oracle) > --- Looks good to me, Reviewed-by: Harry Yoo (Oracle) -- Cheers, Harry / Hyeonggon