From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E66763D5250 for ; Mon, 30 Mar 2026 13:44:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774878244; cv=none; b=EPfVvY/ylDMMh+EWpY6+2o4QH9i9Hbad3v4AkZbJ3ZE1hYmH+4E1Zv6kkYcX8GIQsr1oZ34yW2I4tzrRUtquNsa6wiXmiOh7JrM3mcEeYf5o6adiatkFTUpiOS/B2istQ4E1dBBv/kaxvsuYiiUbcIrK6VKpB4EyfILaTRs0qhA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774878244; c=relaxed/simple; bh=xAkSICz3YbYbLRx33yS/PX4Q5TGmnFPmB+CxO/HhMQg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Au0ef7cOrrjJRz52OMbeLa4GWnXcDS6rV+moOSvFJB2Zj0Lt3CRJqaJBibu54MsuM5KL9GjcdPm3EdI9Q8G49ejzSn1iaBNl1vLQed+p0sX5a2Nr3ZEuFOmsB+oWeU2YIZ5OlHsMHmqcM55p33wdu8Ymtks/zMdNFQx4fLRSQC4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=ggQ/nLNz; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="ggQ/nLNz" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-43cfce3a195so651989f8f.2 for ; Mon, 30 Mar 2026 06:44:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1774878240; x=1775483040; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=X3ZGzJVCnNmeNCqoUl4L/iCu0K897W7KXdQ1Y7sD5VE=; b=ggQ/nLNz/QC5rGkzz6kNlzqhwiOa1yc880L9DRaJFWmXEjoX/cIg5JxKDinY1C8G4U geP0HGQbZRb+091DObiY4kquf9Au+omFv0E9kuOQ5FPjgYA8CKmY7b0ISz1kEw+igbed ofHN5Q74SCGQSmKW6Qfg2FQjIx8onHyCT5HE8nWKzuIz0FBbL7hbfy81kPufWyBY4FH6 6qtl9VBv9cMHRSSk4XJvTK05Az7cwh3DIKAmd3KCsdf9qWUKLb+OQXO547CccLhQIWYI GQc+IaMlmKlcY/zBVT6U+sd5XEp8p0CvEF9TvXDS03bh2KzhUPBpOnN3HVdZ7fnsc103 H/3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774878240; x=1775483040; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X3ZGzJVCnNmeNCqoUl4L/iCu0K897W7KXdQ1Y7sD5VE=; b=EbMys+pfxt/5ucXSlEltt5GhVldiUDfYFg7XO6iMtTLfiIYK+y322RyjQLCu+Wk3eu uUMLzkt4FLHvN9t+24LcLgcrglaBLOBH7gZ9lk2Vqmf/H+EGZn4CgeQYEHHW7n5I91RI Z4MpBxhUQQHj/z2lZHwZ42toi2ev27IHJhf5oVIOU6iLWhxqT5kBziWRFliDRpzHB37H RzzmIl9SmFzrmMGYSLg96pf6kRcKV1F9YC+SICasZz567HJ21oqkuaqFWv5owxQTVU7j +s2zobmLIBUws9PwY/DhsLSWcDM4bxTl07F0KQZNnoxdB4bB5JARf2m6r+uqgQP8B1fJ 9Crw== X-Forwarded-Encrypted: i=1; AJvYcCXfS9LK5cAL3FvM1HkAnsXO9w0xuGvV6gMynyZsGJ2n53to9vlRPA0NDzWUlwsOmNzpWKucxxn9CQGzotI=@vger.kernel.org X-Gm-Message-State: AOJu0YwLrAY8HIQThaEHS6jF7sbk6hhr95edkb/c8ByDumkRGoGK7xVE IrENnGOYrZEiLrsbHFTwjENTjCRDe5BcyxeSjkycQHdJUCY5NNYeQrLYBo3JQfLtM5Y= X-Gm-Gg: ATEYQzxbSI/7oudoYlhu5y4H8TzSyHibTLA/tIrDe2Cn2oLB4ixUZfAxoDQpHO3fZ4Y aSmG/s4Y1CV8b4a8FltqZSXrc3yihgN+Lo2RxbRSvefc0UhRfX+gwwHl0O43ccTjYsxygVbb8cg zqsFZzLr/5rMDCndCA/vX4ljRZLpYiZB20XAcBq+y4qdsRJsMOMUAGM8wYSjFbTQbhPYk6mgb5B Zaa0R5LMv1M2n5EpBr1nwlZfmfiw7Ei94QGgXPIO0rM4IPr6FN4H2r8zFUIauwva6lAclKFJa/T yk0WBPIvswKBw+s0xcnquaOUJfPLVV+WbcytF67ttqSAfp9bRu+Xp1smbFhz04272bb7TBaf0tH cnj+kLwb+3luFTX7AE1oVr8muTN77mM1Y+GeSxu7L3eCsLLu18ZG8IWC5rE9rhaagOJPmil1dpl nv/OF99N/QRxrFgUm3aGIaeO8syA== X-Received: by 2002:a05:6000:2505:b0:43b:962b:5314 with SMTP id ffacd0b85a97d-43b9e9e8f39mr21060657f8f.19.1774878240171; Mon, 30 Mar 2026 06:44:00 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf21ebef9sm20099592f8f.13.2026.03.30.06.43.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 06:43:59 -0700 (PDT) Date: Mon, 30 Mar 2026 15:43:57 +0200 From: Petr Mladek To: Joe Lawrence Cc: Pablo Hugen , live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, jpoimboe@kernel.org, jikos@kernel.org, mbenes@suse.cz, shuah@kernel.org Subject: Re: [PATCH] selftests/livepatch: add test for module function patching Message-ID: References: <20260320201135.1203992-1-phugen@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu 2026-03-26 16:41:02, Joe Lawrence wrote: > On Thu, Mar 26, 2026 at 03:34:36PM +0100, Petr Mladek wrote: > > On Fri 2026-03-20 17:11:17, Pablo Hugen wrote: > > > From: Pablo Alessandro Santos Hugen > > > > > > Add a target module and livepatch pair that verify module function > > > patching via a proc entry. Two test cases cover both the > > > klp_enable_patch path (target loaded before livepatch) and the > > > klp_module_coming path (livepatch loaded before target). > > > > Summary: > > > > IMHO, this patch is perfectly fine as is if we accept that it will get > > eventually obsoleted by my patchset (hopefully in a year or two). > > > > On the other hand, this patch would deserve some clean up, > > (helper functions, don't die in the middle of the test) if > > you planned to work on more tests. It would help to maintain > > the tests. > > > > Right, I think this was a good intro patch for Pablo and that the > revised execution flow would be a great follow on series, if he is > interested. How about that? JFYI, I have committed the patch into livepatching.git, branch for-7.1/module-function-test. Best Regards, Petr