From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA61724728F for ; Mon, 30 Mar 2026 14:01:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774879266; cv=none; b=YxBkIt5PWf/aIPC0ptHkhca7tRTke6cBDjuCNKwvrSi/qoZJJSu8/GyDIttWZbsyjA0y6qoLdJqncduCWnJsZkBfmEkH8BxVag708ana53Uf4KydFQqYeFUB1EOxvbdtbuadb9xSpGcyOhc6fweTGhmQzW+wfACl8gZLBMn3HQE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774879266; c=relaxed/simple; bh=jGgT/3rTdeUbhNP2zJ2pnMoaRL2ZF8nq8eTl3fmk27E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nBYCrVxzhnHf0JqLjUXFi3PRjxNgpNaIbTCWp4MjyYrAQtgm+3RrMoAS6N2qtpOp6vI0ULN+0E7ZLBdfVcyZaC53+SSDBcTVcD7XRTpapMzUsaxFcX/oF3okXmzG83r0cw05nvr+/kSv5I9gENNqThkq8FFp6H6C73RL06PFaJU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ehsIyQ4B; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Op/KPA60; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ehsIyQ4B"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Op/KPA60" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774879263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TjJ2Y/EaW9ZRd5xfuXbZy9/P3SaiBo72fJu0KfHXgEE=; b=ehsIyQ4Bh1BDOPVxpzdXJwDqlRgff4JbfpEhCj4MjKBR5NLYhEKuhrcOurb9TPvL1KdbJr dmBCdQowHmU8cTcouLzHIqzezZQPoUjovsSUCJG2m3zoYpn36myNQN3fIEYBOdCV1B/CxR it8/txscVhN7sQWFBkjz7x0zHtc5jXM= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-15-_umVJlaPPX-2MAhVSEdNtQ-1; Mon, 30 Mar 2026 10:01:01 -0400 X-MC-Unique: _umVJlaPPX-2MAhVSEdNtQ-1 X-Mimecast-MFC-AGG-ID: _umVJlaPPX-2MAhVSEdNtQ_1774879260 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-43d03bad787so584348f8f.1 for ; Mon, 30 Mar 2026 07:01:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774879260; x=1775484060; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TjJ2Y/EaW9ZRd5xfuXbZy9/P3SaiBo72fJu0KfHXgEE=; b=Op/KPA609X9fBT4XzMEm2wD+nxX5Y2UIFclP83EeNuVGKo6EJ3rx/P4yr+keb8qPGM n7reb1gU2dsmo2wsUDic5nZ2Vvck9wUZB45O7bUoYeDjycAU33cycRd3STElGmqZoElF oRuEKBe4p4aKLOvtx5nh25MgMwbRagKa1g+xMh3cOK0K93Zd36lc3YHw6S946jbOjiMM 4Q1LjfNQNc37LySCrjyvSrwtQABf4XAapy9IhYJikPqh6pSF31pJ0l0Jxyf/JdxSQ18S HLIRZ/MfStB+IsajrsBdbTaclKI0NSHfzMgexjcSlU+OZboOYMwbPzyNHxnGqr/ReZHc RZYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774879260; x=1775484060; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TjJ2Y/EaW9ZRd5xfuXbZy9/P3SaiBo72fJu0KfHXgEE=; b=dOZHxwFwNlEwcDONJHWWJ18p4mzSlhfiG73JYNFYUy7G3BhgH3NOEZa522SopKeIIy BKYaGjOo7WxubecA7fSf3ZwXingrn1PYojIjvHaY8oIol+gKiVNNqP3IE2Q0kmVSCquQ Hxa3CGs+D8jMqpxRr0gRswxq7RJ9W1Wqvff1RZX/3hjBgsDJwcmHSDR2XJZ8xpdXS353 xElmJOha4gAXg0uO/ZUhOY5w4ukjNW1RKKFBb8hwjH7/rsUmVTNxGwqzki+lnu6vsk9Z N401TkBnefSeZR8G0oeMgv0n0muIofXVc1VLk9u2jxCH142kv5jy3l4n1xCVB3JbuAEX Mjcg== X-Gm-Message-State: AOJu0Yw2gc20MvmHJOtfTCCbvrBBkDQy/wuhqnO0bZr0JUfUna1GFx81 XTwIHt6xtRXTMksln/bJbl3+cliqnikobeydrNb9rocZjslS+LalY6wtudFxZqKatELuoS4+ssW X+EGliq1ayqMbWRBXma9DPv8YrRh2g2y/9dq67/lKtXTsV0ypmOMNWYAA9qO0ZQxhzyAEG4YmJQ == X-Gm-Gg: ATEYQzxLhcDT0jZ2jrCP47cO3WU14wg1BU8ldVr8xiTE6Fr/257rUTN+poptKq+3Osa iN1zxf1xGdtmzPI2O0ePiiZt8nsbMUpNxM782Hm6a/YOOwt8ukuVPIITbfTztvFgX9gVEm1pUq0 sm002ywlJY/5e32+uX0+77J3FIyvANMXiJK4f4pjrvOFh//BZOE63iDpUYpFUplyLkAW3mW9fiT k1ZZ1V89XjRwKpyVO2HKSsSka6p8DMQ+rgnM16vVQfO18VhvbfBIAs5xPYFTOnjfNytxL3didZC RHSsseZ+okVe1zGj1Oxb73KKoLlUmagsM5QlGC2hMFgBG3lf1Lhupbses8ldS9zv4Q7cg45U5+e +fOBELwjLcqfStpek0W/6+Gmd2Wime+c1oJkMKMDXN9YzpI+xMv4= X-Received: by 2002:a05:6000:2006:b0:43b:86ce:27a1 with SMTP id ffacd0b85a97d-43b9e9ea409mr22953005f8f.17.1774879259708; Mon, 30 Mar 2026 07:00:59 -0700 (PDT) X-Received: by 2002:a05:6000:2006:b0:43b:86ce:27a1 with SMTP id ffacd0b85a97d-43b9e9ea409mr22952931f8f.17.1774879259122; Mon, 30 Mar 2026 07:00:59 -0700 (PDT) Received: from jlelli-thinkpadt14gen4.remote.csb ([151.29.82.96]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf245f87esm18518016f8f.22.2026.03.30.07.00.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 07:00:58 -0700 (PDT) Date: Mon, 30 Mar 2026 16:00:56 +0200 From: Juri Lelli To: Phil Auld Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Gabriele Monaco Subject: Re: [PATCH] sched: Fix tracepoint called from set_tsk_need_resched() more Message-ID: References: <20260129160527.238267-1-pauld@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260129160527.238267-1-pauld@redhat.com> On 29/01/26 11:05, Phil Auld wrote: > This raw tracepoint is added to set_tsk_need_resched() which introduces > two symbols which were then exported GPL-only. While generally better > to add new symbols GPL-only, set_tsk_need_resched() is called from places > that are exported without that restriction. This includes things like > wake_up_process(). Export these new symbols without the added restriction. > > Fixes: 8d737320166b ("sched: Fix build for modules using set_tsk_need_resched()") > Fixes: 6c125b85f3c8 ("sched: Export hidden tracepoints to modules") > Fixes: adcc3bfa8806 ("sched: Adapt sched tracepoints for RV task model") > > Signed-off-by: Phil Auld Apologies for being so late in looking at this, but it sounds good to me. Reviewed-by: Juri Lelli Best, Juri