From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 474373815D3 for ; Mon, 30 Mar 2026 16:01:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774886520; cv=none; b=OCYDLEMwSECTd/AmciSxyYQvyqfPSmwbpYmBSGcDEQXYbx6Y0tujm8Jrj6arUT2aWBMX670lyXm+5z0o0bW9J6KQAsmExrX8zXo2qxGDBsG5RY3ZUMjpJMVURvrbyKCtfH02y/kUEcaggGmPX890u/yyfdyP1HADg4rRi+jfeEo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774886520; c=relaxed/simple; bh=4KAUMl3CukRLqfBbtMt0jYU1kk9Q0OpThfVpfHn4t4A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NGFabpy0POb76Jd3RI3x7//SKMw1XUzQND575qZu19ROF5dPwhDkzk6TD9Y3JT6sLQOuJB1QEDCedSwYR8sU3icJ7CamHtV7EH8NxFqJPBEzevTiUw5HVgfHnQSxZXGcqADFljMd+IIqNtDr230lhdjmjMXYfKDSUDTxs12Q42M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bZI3w8Pi; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bZI3w8Pi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774886518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=A61V9NUjB9y+KTxABrS5J5Rmozg5YI3T1/IJKQit0fs=; b=bZI3w8PiEjVIr0244PxD9fRKAvxtquoXvq4OIirYAiuDyT4aUTF8ea1RDgbMT14fMHSIgY SHVP9VbWLbbLL6ipQIFEdZvClwhwYZSQE5m25cE+vBexzQzaixkXXIkL3wBw7y6mCZV+eg fCWh65KgH+4m64TU+5XHVXJtelz837k= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-597-5Z7tjCrJN46EF5vKHO2H2Q-1; Mon, 30 Mar 2026 12:01:54 -0400 X-MC-Unique: 5Z7tjCrJN46EF5vKHO2H2Q-1 X-Mimecast-MFC-AGG-ID: 5Z7tjCrJN46EF5vKHO2H2Q_1774886513 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5442518005BA; Mon, 30 Mar 2026 16:01:53 +0000 (UTC) Received: from 192.168.0.12 (unknown [10.22.65.57]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id CAC4A30001A2; Mon, 30 Mar 2026 16:01:49 +0000 (UTC) Date: Mon, 30 Mar 2026 13:01:48 -0300 From: Wander Lairson Costa To: Tomas Glozar Cc: Steven Rostedt , John Kacur , Luis Goncalves , Crystal Wood , Costa Shulyupin , LKML , linux-trace-kernel Subject: Re: [PATCH] rtla: Fix build without libbpf header Message-ID: References: <20260330091207.16184-1-tglozar@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260330091207.16184-1-tglozar@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 On Mon, Mar 30, 2026 at 11:12:07AM +0200, Tomas Glozar wrote: > rtla supports building without libbpf. However, BPF actions > patchset [1] adds an include of bpf/libbpf.h into timerlat_bpf.h, > which breaks build on systems that don't have libbpf headers > installed. > > This is a leftover from a draft version of the patchset where > timerlat_bpf_set_action() (which takes a struct bpf_program * argument) > was defined in the header. timerlat_bpf.c already includes bpf/libbpf.h > via timerlat.skel.h when libbpf is present. > > Remove the redundant include to fix build on systems without libbpf > headers. > > [1] https://lore.kernel.org/linux-trace-kernel/20251126144205.331954-1-tglozar@redhat.com/T/ > > Reported-by: Steven Rostedt (Google) > Closes: https://lore.kernel.org/linux-trace-kernel/20260329122202.65a8b575@robin/ > Fixes: 8cd0f08ac72e ("rtla/timerlat: Support tail call from BPF program") > Signed-off-by: Tomas Glozar > --- > tools/tracing/rtla/src/timerlat_bpf.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tools/tracing/rtla/src/timerlat_bpf.h b/tools/tracing/rtla/src/timerlat_bpf.h > index 169abeaf4363..f7c5675737fe 100644 > --- a/tools/tracing/rtla/src/timerlat_bpf.h > +++ b/tools/tracing/rtla/src/timerlat_bpf.h > @@ -12,7 +12,6 @@ enum summary_field { > }; > > #ifndef __bpf__ > -#include > #ifdef HAVE_BPF_SKEL > int timerlat_bpf_init(struct timerlat_params *params); > int timerlat_bpf_attach(void); > -- > 2.53.0 > Reviewed-by: Wander Lairson Costa