From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A08883A0B1D for ; Mon, 30 Mar 2026 16:45:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774889139; cv=none; b=WhUcnja4d90WFze/qSacEfHyw9bP7aRHchcepzmaSYwH0fzrMu/6OZkFHORcqPkuzgYS724M9531L6z3efY8l3FfqDQY1Qlrg/cm3MllomNYNh/igE7HlZof+HSvpMjIOl9ytS0mja1a17zVYZKfShgkz1I+yXye7Lq549hiSeE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774889139; c=relaxed/simple; bh=IpNnA9s1KINuamNfFsS2gV/eEu/pI6jxdZ/6/nT+doI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QwKoda7+HMPFFtZEp4HEzIAqez9wLVpjqGRnELDu4qphxnaGx6qjnbRczzzHpSVEnd5S+msMQ/nMJf+ITX9LM3H87yQPfJ7MLVhc+faCj+EuWSA/VvF8e2DOZCo8D7pQBBJRr6oXKmLzmE/i2FcaUATFixugBb4gAXATEr5LkTc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b=LUUIu0Nn; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b="LUUIu0Nn" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2adff872068so19432725ad.1 for ; Mon, 30 Mar 2026 09:45:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20230601.gappssmtp.com; s=20230601; t=1774889136; x=1775493936; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=BwE++Vqw+CySglw+oPVi7SkePVFEszmRECwetM66l0k=; b=LUUIu0NnPlqE2N6oFk9t68bzUuF/WGQ46GYjp/96iytW8uH1U+ElD8HGdhBpUqHzE0 SVYLQR3kd1yiH2vS3Jh1taoFYUI+Uv8HJ943nKTDUpfnWmCKW2OiSeibmIV9F8A7KbJB omg3/kOpSdBX4WPX/49q+PgCMvt4Est6ljAKXDT9735B6QsOl2LF5CSDYJCbnfejABs9 ivPeE76fx3mRjix5/8nWUkjxqtDvjskmwxRh/W+TzR36ocXQLn/J+KiuirqFZRbGHJM8 JqbL638lreTaVI0Tfua4xM+FzSqTJ4DNl742AiWzjqFAMG0J69j22DshZZe7iec8EKeN LZJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774889136; x=1775493936; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BwE++Vqw+CySglw+oPVi7SkePVFEszmRECwetM66l0k=; b=eRXuOHyJrDLMs91/BLj4Va3UwPubmqa1PNDTokWH0RipwjvRb18zGSPxOd9CLARCwK nxkeWnX+ja7tJIbXjshvp9wGd+h3Nkkld9VjqYWg30YP3S9YZbgK0BMbR67ydnBg2fLA LchTbzryD9etyCX5vIOtMiXZNFZUbltluqge2ZIMBC+xWxEVyo20t8Hp/wZXWfSDaCMN YTwmgmGfFKJi3kL+Sf04+H/ryERs8lRetVOB9LciDmws3FOqaakoFJdq/9rYBq+4exd7 tjiNQpjawQinoLD+R8CmqTc93ZjTv4C2JBLI09PmRu/r7+mYx+JkYxakQW8vWXlVWwSk 9vqg== X-Forwarded-Encrypted: i=1; AJvYcCWTlCaEp93cMsmMWEIWGB3WFhGvU8RY8Bbe65m9obyM/kpmmKRBzWkyNogV/MZjMb+g2m7hMGsph/PiO9o=@vger.kernel.org X-Gm-Message-State: AOJu0YyyneXFIdQCwlR9cB5JYnizkt+9V9cvVMfbAk9/jsV7dh9N8Sl3 ozg9i/eHq4a5PbQ+uTGMqIfoWZ8a22ybcqe3nXh3NVSHae+g3CP2ZhrsUPuUULOzIpA= X-Gm-Gg: ATEYQzx0vAXGueRf+aRCu69uM+TMpex+WzjIcAMhVd2+pSxurGPSFzxuvWaDhcUWpoe LcQ8/tgiHWGruHSsCVpQhefBRWMG+I1Kijsxpze2lh1ZAgLIgC5l0tONhq/S7mk1MWblbARRo+X pmjbgsim4Y9grbY1yC7XmZl0RgvGXzN0hSW9+tRjYEpzLr08n5aw/tyc5/34yDvREu9h8BzFqG6 Tfx4a5pqqx2ooviGu86506tsOf5Wkp/Bnq6vL9H9lh9nVRk2Lz82v8SnBDf4x9Cnksff4lkPH/2 g8MMWJ9SWK6XmZjvUuA9k9CpyLujDR6EoO+IruMFIAUEpY5+lAWYkXW7cqz1m6OkpjI+mUIgp5h hkw8IUoEN73l9SQRcKW3L08OegtYKf+epf7foEeTFTX50cNHnqY+QZdvD4PKq7+yVa2O66WgoO0 jISOyYEf6kwZf+u7c= X-Received: by 2002:a17:903:22d2:b0:2b2:58c7:2ce1 with SMTP id d9443c01a7336-2b258c733d1mr25360975ad.36.1774889135767; Mon, 30 Mar 2026 09:45:35 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:43::]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b242765d3esm109007305ad.47.2026.03.30.09.45.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 09:45:35 -0700 (PDT) Date: Mon, 30 Mar 2026 09:45:34 -0700 From: Joe Damato To: Jakub Kicinski Cc: netdev@vger.kernel.org, Michael Chan , "David S. Miller" , Eric Dumazet , Paolo Abeni , Richard Cochran , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , andrew+netdev@lunn.ch, horms@kernel.org, pavan.chebbi@broadcom.com, linux-kernel@vger.kernel.org, leon@kernel.org, bpf@vger.kernel.org Subject: Re: [net-next v6 07/12] net: bnxt: Add boilerplate GSO code Message-ID: Mail-Followup-To: Joe Damato , Jakub Kicinski , netdev@vger.kernel.org, Michael Chan , "David S. Miller" , Eric Dumazet , Paolo Abeni , Richard Cochran , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , andrew+netdev@lunn.ch, horms@kernel.org, pavan.chebbi@broadcom.com, linux-kernel@vger.kernel.org, leon@kernel.org, bpf@vger.kernel.org References: <20260326235238.2940471-1-joe@dama.to> <20260326235238.2940471-8-joe@dama.to> <20260329151230.7acacbb9@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260329151230.7acacbb9@kernel.org> On Sun, Mar 29, 2026 at 03:12:30PM -0700, Jakub Kicinski wrote: > On Thu, 26 Mar 2026 16:52:26 -0700 Joe Damato wrote: > > @@ -891,6 +891,7 @@ struct bnxt_sw_tx_bd { > > u8 is_ts_pkt; > > u8 is_push; > > u8 action; > > + u8 is_sw_gso; > > unsigned short nr_frags; > > nit: maybe group the is_* together, IOW move new fields before @action? Sure, will do for the v7. Thanks for the review.