From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE5883BED16 for ; Tue, 31 Mar 2026 09:59:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774951159; cv=none; b=MKnHoKEqRgbq39lyBnjZY3o3SHUTBaq8HTIxPf80t3QHH4Y5tG86B+rBFKnOaOk5Q9hZETNxMG7xP4sA4SVuy+/QRnhjOtgWnN3i8DWMHhkH8c6xPTDZDsCMVqPdVBLPoWKmw/hQRNH545dolD9zkfGSPmIhtu7h8Z5Z8hvQxtM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774951159; c=relaxed/simple; bh=K67fp/R3crNHryaqNc/qaMyLhGOxVzxXxCmNqZMjqKk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R0JOr1RTYgcRTuIeTfJYmTtp5uXTc4rP4epXiILzQNiJ7EWinfnfJTz0J976/wlzbLUJrz/om6pjjiiBY+gzOe7fCrsvRZiZxqTaAcD+U6g5y9QDoiPcGwwtsd+EMCOwKAsbSZSKsUVKJR+SXxCZ6UC7wy+XMBqVggcDOPXlJiI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=N2fZHeKf; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VmPALYMD; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="N2fZHeKf"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VmPALYMD" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62V5SH9d2408168 for ; Tue, 31 Mar 2026 09:59:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=tYVdhzyN/PgBq2nHkZ289xfo K00phIoatD6dXYcn2sM=; b=N2fZHeKfG5auWv2C0vp9w8f1qmx9IzwqdS/6uh0U OBBdLq2V+cjwOLuCLrXIJGPDKXjzCpeAh8335To92rTc+o39RmEYuto2GO8hIpwh LyoLlWWhOGtrR0VfQL5Cvaojb0HoUO0e7KWBb5Kp8CyJIc1/Q34RXME3Fq5PBVmj HQYD4XKV7KAaN4fwbZtojCXpEBSaCilTJa3+MX/ZHUtH5UAZUv6CCYllnreIrP49 lRAsjEB14XVj5h1gj6govHOzbR4U8noRvNLn1wbs/H76gPdqTbQ2HfIzkamj+fje KmYsRogvClMEVCs214bSueHvuRGUDHi+Mw1wRjHHggU6TA== Received: from mail-dl1-f71.google.com (mail-dl1-f71.google.com [74.125.82.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d80hethma-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 31 Mar 2026 09:59:16 +0000 (GMT) Received: by mail-dl1-f71.google.com with SMTP id a92af1059eb24-12721cd1a2aso2302129c88.1 for ; Tue, 31 Mar 2026 02:59:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774951156; x=1775555956; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tYVdhzyN/PgBq2nHkZ289xfoK00phIoatD6dXYcn2sM=; b=VmPALYMDuWZ1BramO6QIklApf0ABOzh1vO+qgmXhdhunNcnsTG8L5PTpWk5qDX3m4I 6r2dCxynF3qA2k5NX5fG2k0qUWDcqWS0OwTa7pslTPk13JjHY+HccOSJMZvdaV45zhmw 0L2x5mNHBscCMnPe78US/K3yQpnoSZFIjusYhl4SnJk6SRthP7GfeUUqd+Xzilyp8jh1 zi1mvrKVaiPfyYDbTmd330iBiXNdMWy+RFxZtRUzz9IjpuPh1ZVEBXpcbuJBz9+6eG12 373jyqZCzgLuGdl3SlOpLovg/P582iLoyeTlXvZI4wYg1vm8MqSjbOJFbNPUt4WqA8vh VnJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774951156; x=1775555956; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tYVdhzyN/PgBq2nHkZ289xfoK00phIoatD6dXYcn2sM=; b=BzyBROrRqIKIBbtCn4BwZ6XB3ufuZ6o5su30skjGItkI8xgGlrgZROtZoXtkfzVnhc o7mYwcoRjjUdxN9aHdDKoN7IwOdmHqiftA4wPvmE69ayTNwkW3l/Yy3n+GQwJKhDZXRo t76oHgmtELxnlx01zMq13t4ZMLiktyi2NRPtuyVbUBCkXByPqFeFcVYDHfy8kcD1R+7x 4ie1znEfbfUXU0k2lAp6Ehiqt103FbC3ZEQOWtzx9ZlFoHOjnLhf9cxLhIqbOy7HX1ef ZFH7Ukk9/jCoSunXIVo2bMjt5P8AChmqmdCCP9+bGeWPe6Ab4ExzOLBdTUt7J3E/h5S0 ARcQ== X-Forwarded-Encrypted: i=1; AJvYcCWLkSKcauJBhIldkuHlCNXCdrW4uIA1ODQ03yjD+uSOEgIGJV0doc3pbkQmmzN9Le0pgjQoWM7AQ2rmWzg=@vger.kernel.org X-Gm-Message-State: AOJu0Yyoa5jKBRuW8Xf+VhaGU9RmyhI4iWLxLgIkVD9ku0bBIQ6dYjB3 5vIurHDKiilAWMrNkqURevot84DmrLYgJB6LTes+qL5poSZX7LH/lgmnktZM3zNNZSCZjdKM+we BZGk0oLHHggvFKU1NLixOjA446ZLajYnAz2u/ebxn4ogTQSI1vi574kbqLo2atfFwnh8= X-Gm-Gg: ATEYQzy9ACzFM2jVtSzIk8iR+KHkDuwKVRpaL0InifZGmiHHBf4siLmKf5/GlU+cGjT hcGSpq6TkE7jMfP77F33tQFYAgD3hWVD0PivR8mSQJ5jIhIxX1vHcX/zcpSYTFLaZeVSbWTBFF1 mpZzxPODgIzSz0P6LZoN7EvJNiwVInU3ape/rvxLa/8x3TujIMjiPSAWnzdaBCdovr58FZ4kp5V 0K591PC7UL/njuhhhxYNh+Qk7e8IyDrwbCt/7bQDbyCczT03vLi8tCcgU44EUodVfqlsW7Yri0q t8/pNU5Xdh2Vo82fUvfSrYzY8zWCPvRt5w06v/Bv+YeFoiDLOaIsc4+nol0OKeXxQhIbJqjdjuC /dXRUQL2Lw4Wm2PBNzXmCkQf8/7NKEje1bg2gCYx7TD1U4aHou7xwvh5u8kkrkNbz4kVp X-Received: by 2002:a05:7022:914:b0:11d:f440:b743 with SMTP id a92af1059eb24-12ab28451acmr9612928c88.7.1774951155506; Tue, 31 Mar 2026 02:59:15 -0700 (PDT) X-Received: by 2002:a05:7022:914:b0:11d:f440:b743 with SMTP id a92af1059eb24-12ab28451acmr9612897c88.7.1774951154745; Tue, 31 Mar 2026 02:59:14 -0700 (PDT) Received: from hu-qianyu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12aba581027sm15063809c88.4.2026.03.31.02.59.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 02:59:14 -0700 (PDT) Date: Tue, 31 Mar 2026 02:59:12 -0700 From: Qiang Yu To: Dmitry Baryshkov Cc: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/5] phy: qcom: qmp-pcie: Add Gen5 8-lanes mode for Glymur Message-ID: References: <20260323-glymur_gen5x8_phy_0323-v2-0-ce0fc07f0e52@oss.qualcomm.com> <20260323-glymur_gen5x8_phy_0323-v2-4-ce0fc07f0e52@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Authority-Analysis: v=2.4 cv=Gb0aXAXL c=1 sm=1 tr=0 ts=69cb9af4 cx=c_pps a=JYo30EpNSr/tUYqK9jHPoA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=kj9zAlcOel0A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=56H2F1Fm8OXBRpAn5E4A:9 a=CjuIK1q_8ugA:10 a=Fk4IpSoW4aLDllm1B1p-:22 X-Proofpoint-GUID: gEUu0xMbMXqRzflYf93Qfkr2wJGBSuTM X-Proofpoint-ORIG-GUID: gEUu0xMbMXqRzflYf93Qfkr2wJGBSuTM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMxMDA5NSBTYWx0ZWRfX5bUqqxKpavJC BdzvXryCwwNR84TO6VPcfFbHOC/6rpB9UFMcQKgEPeOLjoiA3k/Le/HTtMTmB0cC3wvskvodx5H kmKDT6CjECsv3bVwv4xkcPSNIfeIUqECZTOvgYsjAJ8h/vCgkN0C2tGs6e0KRD3e5Qees+GilpD /VNUFbElLMq3mMz4OoUxtRzM7Mvu6Q9REZm6FjxcmqBoKkjjZalZpgGQDyivs+W/kNHn6/ywEbC vPWgcioFLhpzMA7rv93zVlz6gwHXIVLuZNawlHd/AuayJIRCldbIDey+roujG4dpKZNSppsY+9U nPigla8lYsv5Z55sHgUPI1QNkIxhZd2VMdF7iMmm8GPOSbjdMtePlAzA0PFIxubMnTOW//fWh2i H4H29urs8W2hVk3tCtUKURuETAOslFSyiAo8qbB0AeB/yLr5nM0SQvxZ4LpuSIJBi9jORKmzhHi LdKkya0olOjr+D1wGPg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-31_02,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 adultscore=0 spamscore=0 bulkscore=0 malwarescore=0 clxscore=1015 suspectscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603310095 On Tue, Mar 24, 2026 at 11:23:19PM +0200, Dmitry Baryshkov wrote: > On Mon, Mar 23, 2026 at 12:15:31AM -0700, Qiang Yu wrote: > > The third PCIe controller on Glymur SoC supports 8-lane operation via > > bifurcation of two PHYs (each requires separate power domian, resets and > > aux clk). > > > > Add dedicated reset/no_csr reset list ("phy_b", "phy_b_nocsr") and > > clock ("phy_b_aux") required for 8-lane operation. Introduce new > > glymur_qmp_gen5x8_pciephy_cfg configuration to enable PCIe Gen5 x8 mode. > > > > Signed-off-by: Qiang Yu > > --- > > drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 30 +++++++++++++++++++++++++++++- > > 1 file changed, 29 insertions(+), 1 deletion(-) > > > > @@ -4705,6 +4713,23 @@ static const struct qmp_phy_cfg glymur_qmp_gen4x2_pciephy_cfg = { > > .phy_status = PHYSTATUS_4_20, > > }; > > > > +static const struct qmp_phy_cfg glymur_qmp_gen5x8_pciephy_cfg = { > > + .lanes = 8, > > + > > + .offsets = &qmp_pcie_offsets_v8_50, > > + > > + .reset_list = glymur_pciephy_reset_l, > > + .num_resets = ARRAY_SIZE(glymur_pciephy_reset_l), > > + .nocsr_reset_list = glymur_pciephy_nocsr_reset_l, > > + .num_nocsr_resets = ARRAY_SIZE(glymur_pciephy_nocsr_reset_l), > > Just for my understanding. If it was not the NOCSR case and had to > program the registers, would we have needed to program anything in the > PCIe3B space? The PCIe3B PHY registers need to be programmed. But we don't need to do it explicitly because there are also broadcast registers: writing to these registers will automatically write the same offset and value to both PHY ports simultaneously. - Qiang Yu > > > + .vreg_list = qmp_phy_vreg_l, > > + .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), > > + > > + .regs = pciephy_v8_50_regs_layout, > > + > > + .phy_status = PHYSTATUS_4_20, > > +}; > > + > > static void qmp_pcie_init_port_b(struct qmp_pcie *qmp, const struct qmp_phy_cfg_tbls *tbls) > > { > > const struct qmp_phy_cfg *cfg = qmp->cfg; > > @@ -5483,6 +5508,9 @@ static const struct of_device_id qmp_pcie_of_match_table[] = { > > }, { > > .compatible = "qcom,glymur-qmp-gen5x4-pcie-phy", > > .data = &glymur_qmp_gen5x4_pciephy_cfg, > > + }, { > > + .compatible = "qcom,glymur-qmp-gen5x8-pcie-phy", > > + .data = &glymur_qmp_gen5x8_pciephy_cfg, > > }, { > > .compatible = "qcom,ipq6018-qmp-pcie-phy", > > .data = &ipq6018_pciephy_cfg, > > > > -- > > 2.34.1 > > > > -- > With best wishes > Dmitry