From: Christoph Hellwig <hch@infradead.org>
To: Deepanshu Kartikey <kartikey406@gmail.com>
Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+d31a3b77e5cba96b9f69@syzkaller.appspotmail.com,
axboe@kernel.dk
Subject: Re: [PATCH] splice: prevent deadlock when splicing a file to itself
Date: Tue, 31 Mar 2026 08:10:58 -0700 [thread overview]
Message-ID: <acvkAuq4_cWmegC7@infradead.org> (raw)
In-Reply-To: <20260320130615.1109449-1-kartikey406@gmail.com>
On Fri, Mar 20, 2026 at 06:36:15PM +0530, Deepanshu Kartikey wrote:
> Fix this by checking if the input and output files share the
> same inode before proceeding, returning -EINVAL if they do.
> This mirrors the existing check in do_splice() for the
> pipe-to-pipe case where ipipe == opipe.
While restricting splice to be between difference inodes sounds like a
nice simplification, I'm not sure we can add it 20 years after the
syscall was added.
next prev parent reply other threads:[~2026-03-31 15:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 13:06 Deepanshu Kartikey
2026-03-31 8:51 ` Deepanshu Kartikey
2026-03-31 9:33 ` Christian Brauner
2026-03-31 13:32 ` Jens Axboe
2026-03-31 15:10 ` Christoph Hellwig [this message]
2026-03-31 15:15 ` Jens Axboe
2026-03-31 15:21 ` Christoph Hellwig
2026-03-31 15:24 ` Jens Axboe
2026-04-01 8:08 ` Jan Kara
2026-04-01 8:32 ` Deepanshu Kartikey
2026-04-01 10:47 ` Jan Kara
2026-04-01 10:59 ` Deepanshu Kartikey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acvkAuq4_cWmegC7@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=kartikey406@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+d31a3b77e5cba96b9f69@syzkaller.appspotmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®