From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2201F37C92D for ; Tue, 31 Mar 2026 21:11:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774991496; cv=none; b=j2nwy22j84G82UMjJhGwJF7lWzLGw4jky01gsPmYBGeZqzplfwvlhBxDXCJ/zgSrcVQmPI2OhY2b/w/EbGp9HaBBk8Iec3GS0rFM94AqyZ6nv/lTGctr8h1+9tcQIRQBkjfezPV1AYwLdpAS/c5Zoh9nEQskmL902smhGY5CfKY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774991496; c=relaxed/simple; bh=FWRC3fOXOYfrSoAOEpVCTCqjxvELujNq8j/OczlXMas=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ld1BR8WRVNxNjlENgfuZXeoFN/budOibloEcWxauR0ZXBnxwvwuP9aF2yjT1Hz4/hv5kiG3xLCTE46XvGbc56lvzAk7eCIy9Bo6JGRXIZNcBE/KP+lCedJhpxO2eGj7In/XlAUqEJ3Gw+zgenEEdtCDRInxHpW8k4I3TE9IsvPs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b=htBThJpk; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b="htBThJpk" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-827270d50d4so5398512b3a.3 for ; Tue, 31 Mar 2026 14:11:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20230601.gappssmtp.com; s=20230601; t=1774991494; x=1775596294; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=aRLI2nmGdFJjDdlaJeIJBPkgXFafuXmLsFAn4yY0FP0=; b=htBThJpkMhWXfbpNxX60+Z1D9MokrG9caZA4OwLF6mLVKfF/Of9Z8Wtoo6eYdbdX3o uU6TLWFV/I310JTWXq/qHEgeDhko62Qyoej1cQt8KDJfwTq0OQCpWd6A6jwuPE1GBdfh 9CN8xgJHNMKppn0a4HOI2XJsnZcnkFnUjeHNTYpebMddWjrMes+l3vDU5gAT9Fj1Sqb3 dA4tzlUAF2qd8b/7olXhZtpnkv+OHD7YCXSbEfXSjzg2+OEY7KpZIrgI3ra3AOomY5Vn yPE935/yFWMNGBXo6+nuwrV6dRkRZ8wsRY3DAuZNP5BFWy2GID2pNHvG3CZYDxQ50VMN iFZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774991494; x=1775596294; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aRLI2nmGdFJjDdlaJeIJBPkgXFafuXmLsFAn4yY0FP0=; b=e58wgrMPBRd7H1dzc73slH7QGV/bz9DNpcTcenZ32mlDpEQGud1BmKKyA0RqW7d6c9 D2h+Ct/BGxcGVoUDK3FxNW+HhGRwBWftpaPP528fBzqtQhYP6QyoXjTC8Yu4X4UBJOyZ fnRkY9UZrzKHUNFQBcGpLUK9Wkrg+tVOwh2pBGr+rzPuGQdStCNCsJn2wupO53Yegwha 9s3v83ICoCe5PHpkU2u0yoRzjGmuVvFgekIV7n+6/zN5W7jANJQuLbBs5/iJ9rj3/swh HPjCRZ1NN8AbKgBycCCVsOz6h/mL/aReT0JdGUU9jqtE3eMFK3Jdq86ah4LIfXhFIawm hldQ== X-Forwarded-Encrypted: i=1; AJvYcCXKvleVohrjk5bZeUs6aCQgUtXmdRXeXDWhcfQ3OmjUwFcrqbqNoKZBRNoKNnEiugu/EXFqCC1gl+Vd5EE=@vger.kernel.org X-Gm-Message-State: AOJu0YwHas3zZ3HbwptVsY+Ts9/7rMPZUmz1TY7ZKon7aG4jjxeUB1qx w9RNyVH9cs2VhBCjP0PKzYTy7V9ifqlUsC2+0t1+EgO3WmlsnoU3o4N9ian5tMoYY5s= X-Gm-Gg: ATEYQzw6zMP31Y7ZmrPYhhBlQQkywdlW0bOQhkWGXb10PPq1DYQ1EvdO5oOvmmeg1YD RSq/DJqVwSsDW77B0m6hzkFDXyzdPmir1/SQHzKitohx5eGYAZrk0WzikOM6KisXjlFZPhw47ot aj8Kck2GkDi35FrEJPz95PlNzXNEwAkD7VqlXW5UnsEkfdn+ZGfmUROSkWGyYlH4AE0Bj/U2vYX IeVSUwtlB43JCHV7Z3Oi7G4GpTqV5XYyDyQ3ZZURfNPr9vJyWF1MFUnuiu7OAXgKsQJAH0RSJlc 0+fEJjEzbJzyHONfmCzPPmdYLpczaJOD1fxqg9Qqo/FpREaTIWxBn24Au9hHA6oRN/rVfB7V47U N3w5BsqLhj/mEL8BWFeCfV9DU2JVM9IO/+RAlp5lhLHoLtCdncVoyZsDK3UOKqy1jhXJ3pzWJsS 2pLmgr X-Received: by 2002:a05:6a00:1951:b0:827:343a:a1ef with SMTP id d2e1a72fcca58-82ce8aead3cmr1033738b3a.52.1774991494490; Tue, 31 Mar 2026 14:11:34 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:44::]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca85ef1bfsm11111542b3a.44.2026.03.31.14.11.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 14:11:34 -0700 (PDT) Date: Tue, 31 Mar 2026 14:11:33 -0700 From: Joe Damato To: Jakub Kicinski Cc: netdev@vger.kernel.org, Michael Chan , "David S. Miller" , Eric Dumazet , Paolo Abeni , andrew+netdev@lunn.ch, horms@kernel.org, pavan.chebbi@broadcom.com, linux-kernel@vger.kernel.org, leon@kernel.org Subject: Re: [net-next v6 08/12] net: bnxt: Implement software USO Message-ID: Mail-Followup-To: Joe Damato , Jakub Kicinski , netdev@vger.kernel.org, Michael Chan , "David S. Miller" , Eric Dumazet , Paolo Abeni , andrew+netdev@lunn.ch, horms@kernel.org, pavan.chebbi@broadcom.com, linux-kernel@vger.kernel.org, leon@kernel.org References: <20260326235238.2940471-1-joe@dama.to> <20260326235238.2940471-9-joe@dama.to> <20260329152016.27646fab@kernel.org> <20260330165357.31a30b68@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260330165357.31a30b68@kernel.org> On Mon, Mar 30, 2026 at 04:53:57PM -0700, Jakub Kicinski wrote: > On Mon, 30 Mar 2026 09:53:33 -0700 Joe Damato wrote: > > > > + bp->tx_wake_thresh); > > > > > > Is tx_wake_thresh larger than the max USO even for smallest ring size? > > > > Yes, it is. > > > > Maybe its worth adding a comment in the code somewhere to make > > this more clear? Not sure where would be an appropriate place, but maybe > > bnxt_init_tx_rings? > > Hm, as long as BNXT_MIN_TX_DESC_CNT is updated I don't think we need > any bespoke comments I am hesitant to update BNXT_MIN_TX_DESC_CNT because it affects all hardware, including devices that do USO in hardware. It may not matter in practice since I would be bumping it from 19 to 210, but we could just leave it as is and let fix_features and init_tx_rings deal with ring size (as they do now). IDK. Feels "safer" (but maybe less clear) to leave it as is. WDYT?