From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C538F41B36F for ; Tue, 31 Mar 2026 21:14:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774991654; cv=none; b=OGfQwu6JnnM9SGbDK1hEknjCktR9W5pAvpcZ534eCPiS8A7cQ0sb8Qpj/8tVTEsZKhFCTb/BtiqwnJz5paRCd3g7C+zOTz80Z687nrcpYdbxnYxy+hce/2XzCPNrXnFweeVTJTrUaFCC6z+T0uYIZRVCYyw774rQle+1Earurm8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774991654; c=relaxed/simple; bh=RodyypEEjn5xc2xKGLUHgsXuF5/nuAgh5MDTpI7TEK4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IFW1arOlpYN1PxqEKEoCakQs3sp6Q+uu6x6IMwsBXqEbI1HyF6vFDNabz4B9dslVk3DErZrSy3+kMWLk6sHzh7WctHBBuMREZTkT+tEhdmoteSNSwKuF8B8DczGOQKwvy2AW0nEGvvCSoOkgNNt39Oi+NVsuTvb72rr7frS2Wgw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b=Sto3VEtO; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b="Sto3VEtO" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-82cd9d0eceaso993539b3a.3 for ; Tue, 31 Mar 2026 14:14:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20230601.gappssmtp.com; s=20230601; t=1774991651; x=1775596451; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=mPsDMKl966SWuogi2uoY2AaXGVDeLc7Y72W3efu4G/s=; b=Sto3VEtOLPeN+FSQWKuPf0/8+DX6zN4/VMq3ogS5DTYnWFhUlIZKj04G9C/1TwDX0A IWVJHzMrvGOZuF3u7uZfDlKAI0Q2SKUXCYjSOiZ2nfTnHzZenhPUbt/D52sDwcbxP5oD xgdrORSxMf99k73BbWf6Fl6Ofz3ZiHlm739eMcck8ictMk77w4vEFZIYayIkY8+a4k9I z7Qu2yinWO6qAWPt5wEfeyjPIZzsokBhVO0PHoe3k7Vj/Yqq6tQNTgiK3aCV0ctRw+vA wjOUL0nf9UFrdGnQYazB9tPmu38rDM30wtL6eNHI62JixqM71h+pE7qmvibXBGkkrOzT M3hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774991651; x=1775596451; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mPsDMKl966SWuogi2uoY2AaXGVDeLc7Y72W3efu4G/s=; b=sso+S/CYVlzHzwx+XhDcYo4piMBloSDwZ5HZvXtP9yMz6aJ4urPq6ij5yzFKTanTXK kTWYsy+EAeAkexITLSgKbcU2EN1Mrg0h0hwY5ORSnMG+VBZPkUPIPhKP+2EUeQ6UYj02 lptwIO3itbLsN1ZbNWK+AuQYzTb4D+9xvqzp046g3gLP4hXUqH5ICxkkwX1dO5ww45na d4kUyuv3euOTe7yeQ9ybuvlsvnIZFevW07QzJhNGy6fHC5YlPS6pk6uQ77Dog01zrMBY IcbfQBNZ5gcIGs+EhLJIIdpEAEwwapxjU5HUZHQMCosSCwpy9F1bS6nTMku9WjTwGVDb E8Vg== X-Forwarded-Encrypted: i=1; AJvYcCXIYHIpGbvNk7Qze0m84lrHQaCmIhVZIP8NtXMi+JwSQ5N8M0YjdxKHXxevsUFv3Ze24rurC5P3jr9q+3E=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6ZM9lDaVRCggggjI+wnIi8U5jD1OWIi1+anLrV9udUqi4F4jn mCgIiHsoDakApsvNUu3kFpr7rf3gA5b4JX+hMWmJuD7XOfVE75gUgC9Hn2UirioikvQ= X-Gm-Gg: ATEYQzzWLoJsRJgxb23GlPFPbef9wfhIRJmfR0+Ee9L58FxjG65BHKf2R4I5sVVWJY+ 7P59WWtzydJymf4m1OLu+18Rzjzr1lFWV0gaJuxMFYAfd+VPBBxlKc6SUibJQ6GuhdFC1PpJxUn NcgEc3xr4JXFyzkr31UaqcJt3K7iEQxF8KPjBuVPahrSum4+qLJk+8hmR7phC5qnDkXfmfhbVXp 0dQcoeIDCExMhycb86W2HxNtChfs5/016EAXn01vA7m+bM9wuodV6BxCT09YzmP3C7IoVRNRMKd DVGbcMujLvfERu2zCWYuU9CX3581mk2FIhzp6N98k92sVMjE2qXIzFW544U2Z8UbKryE8nnvs93 9fwYsPC1YV+mlvaE8Np5xEdSa2MaHxmKTsRBM+fwmKJjljMWf2FX29gnWqFIEmakA4hbi5iBYqT AudyDbt+gCR+U= X-Received: by 2002:a05:6a00:4195:b0:827:3d52:5d1a with SMTP id d2e1a72fcca58-82ce86d78a1mr1034418b3a.0.1774991651111; Tue, 31 Mar 2026 14:14:11 -0700 (PDT) Received: from localhost ([2a03:2880:2ff::]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca849849fsm13712725b3a.26.2026.03.31.14.14.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 14:14:10 -0700 (PDT) Date: Tue, 31 Mar 2026 14:14:09 -0700 From: Joe Damato To: Jakub Kicinski Cc: netdev@vger.kernel.org, Michael Chan , "David S. Miller" , Eric Dumazet , Paolo Abeni , andrew+netdev@lunn.ch, horms@kernel.org, pavan.chebbi@broadcom.com, linux-kernel@vger.kernel.org, leon@kernel.org Subject: Re: [net-next v6 09/12] net: bnxt: Add SW GSO completion and teardown support Message-ID: Mail-Followup-To: Joe Damato , Jakub Kicinski , netdev@vger.kernel.org, Michael Chan , "David S. Miller" , Eric Dumazet , Paolo Abeni , andrew+netdev@lunn.ch, horms@kernel.org, pavan.chebbi@broadcom.com, linux-kernel@vger.kernel.org, leon@kernel.org References: <20260326235238.2940471-1-joe@dama.to> <20260326235238.2940471-10-joe@dama.to> <20260330165748.2edb501a@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260330165748.2edb501a@kernel.org> On Mon, Mar 30, 2026 at 04:57:48PM -0700, Jakub Kicinski wrote: > On Thu, 26 Mar 2026 16:52:28 -0700 Joe Damato wrote: > > @@ -4645,6 +4687,10 @@ static int bnxt_init_tx_rings(struct bnxt *bp) > > > > bp->tx_wake_thresh = max_t(int, bp->tx_ring_size / 2, > > BNXT_MIN_TX_DESC_CNT); > > + if (!(bp->flags & BNXT_FLAG_UDP_GSO_CAP) && > > + (bp->dev->features & NETIF_F_GSO_UDP_L4)) > > + bp->tx_wake_thresh = max_t(int, bp->tx_wake_thresh, > > + BNXT_SW_USO_MAX_DESCS); > > > > for (i = 0; i < bp->tx_nr_rings; i++) { > > struct bnxt_tx_ring_info *txr = &bp->tx_ring[i]; > > @@ -13832,6 +13878,11 @@ static netdev_features_t bnxt_fix_features(struct net_device *dev, > > if ((features & NETIF_F_NTUPLE) && !bnxt_rfs_capable(bp, false)) > > features &= ~NETIF_F_NTUPLE; > > > > + if ((features & NETIF_F_GSO_UDP_L4) && > > + !(bp->flags & BNXT_FLAG_UDP_GSO_CAP) && > > + bp->tx_ring_size < 2 * BNXT_SW_USO_MAX_DESCS) > > + features &= ~NETIF_F_GSO_UDP_L4; > > + > > if ((bp->flags & BNXT_FLAG_NO_AGG_RINGS) || bp->xdp_prog) > > features &= ~(NETIF_F_LRO | NETIF_F_GRO_HW); > > > > @@ -13877,6 +13928,15 @@ static int bnxt_set_features(struct net_device *dev, netdev_features_t features) > > int rc = 0; > > bool re_init = false; > > > > + if (!(bp->flags & BNXT_FLAG_UDP_GSO_CAP)) { > > + if (features & NETIF_F_GSO_UDP_L4) > > + bp->tx_wake_thresh = max_t(int, bp->tx_wake_thresh, > > + BNXT_SW_USO_MAX_DESCS); > > + else > > + bp->tx_wake_thresh = max_t(int, bp->tx_ring_size / 2, > > + BNXT_MIN_TX_DESC_CNT); > > Adding extra handling for min ring size all over the place looks a bit > messy. Can you factor something out of this logic? Could add something like: static int bnxt_min_tx_desc_cnt(struct bnxt *bp) { if (!(bp->flags & BNXT_FLAG_UDP_GSO_CAP) && (bp->dev->features & NETIF_F_GSO_UDP_L4)) return BNXT_SW_USO_MAX_DESCS; return BNXT_MIN_TX_DESC_CNT; } and then when setting the tx_wake_thresh, it becomes: bp->tx_wake_thresh = max_t(int, bp->tx_ring_size / 2, bnxt_min_tx_desc_cnt(bp)); and fix_features can use the same helper. Question then is just do we still want to bump BNXT_MIN_TX_DESC_CNT (as per your previous comment)?