From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f51.google.com (mail-dl1-f51.google.com [74.125.82.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38CD9345740 for ; Tue, 31 Mar 2026 17:22:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774977758; cv=none; b=QovW2tZXaoFpMGErhxwcSifHtJNotd6kF9mpQ4u95OOZGTc4Gy2zrmy38dFARKPj9jntTCLFdi9qXmKTTImoQ23AJB6x/5GFO/b2In4GQdGloRHDF625N24disU1GTQiRHMq4SiLVUYTfogTXij8nLU0a33FDmGyQ0Llyiw5oxA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774977758; c=relaxed/simple; bh=pcywMolBn0oP7rzSAhDoY4rho/BcYShbzBlVdZn27fw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZMPqnaNZgMKOYz4gxXjX4PQhEw8RhnJRkgw0frJ2/CQC/mlpLgGtvs5loUJgADXfuOp4wVZLp5euMR10QXAJxFGr0j9fqd4C3OrflOu9/pTTSU0AOG6zMiteg7w1pBq2I375J8ASlj8/U5OknxRK6yDzilNr//RoZtD4OpmDkB8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=wbinvd.org; spf=pass smtp.mailfrom=wbinvd.org; dkim=pass (2048-bit key) header.d=wbinvd.org header.i=@wbinvd.org header.b=D5VFnsxk; arc=none smtp.client-ip=74.125.82.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=wbinvd.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wbinvd.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=wbinvd.org header.i=@wbinvd.org header.b="D5VFnsxk" Received: by mail-dl1-f51.google.com with SMTP id a92af1059eb24-1274204434bso82628c88.1 for ; Tue, 31 Mar 2026 10:22:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wbinvd.org; s=wbinvd; t=1774977756; x=1775582556; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=buMcd7BiSqQWL605PmrRNw833KvkdK7h99i/7i+pigQ=; b=D5VFnsxkWVrEPg0Nku93b41U+OL3Dhj95CrJBJKh2LqW6np6usWgZJw7g/WELPsHB5 ACSRIteb4iPDdij8NqLLQXW4T4cmGN+G7TElTuC19jsNgV0KDtScypO/5XCvWfjqbBww aVaCuBTaekiCin/WRgSYPaSa7c30EMKo5Dw3CnAE1ty9Q9Jvrp3ngORBRPzEgeZipVHW UlE9bTqzJUqkJTHxU2ohe3YwifiixNLzgx+VVTFOMqdeEEkcmD4zRx05JnX2VudE6SWO RNgbKSMroIlXfsJFsqJUPcEwipOX85Vb/x2A03Sn9LJQwBZgYzOhk4bX5y9V5Hd3TsMG /Wgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774977756; x=1775582556; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=buMcd7BiSqQWL605PmrRNw833KvkdK7h99i/7i+pigQ=; b=G0uViLAblinB6ipuyuW8Lxgnbr/g1ZJJ3oj0DzKdS8tlkK07YWbr0FCLNLg1IoyDts Jq1eWBkwASGatRVOR02FoEPWfHWAmZqZDL/mn+f+DO5pY+y1ONwClHsaNmSxp6A1m6f4 26XodTp0x2ou9ATXlr5/LCIl3Lt1J+w5AuBEAk8zuTc/mEnaZdu6AnNnSosNVTHfixnL 8xSfI/lOysMb/EQOpdIJO276/nQJkrWHe17+J4BZNTGO6LW31NJc/im2MEaTf5n41W+k 6fdEQV/ADY1bYzxZaRQBoAWHBfGwnkj1dC7WUW2dNOfT2FTVjJw3/VRgpzAv9Mn2z1Zi oxwg== X-Gm-Message-State: AOJu0Yy1cZQ4TCQPgJ82L/jGbYRgtGuo6DEcVzXvmfHMQKJqk+2Wf+JZ 6YvTn/QPCFzI5esz0UZu3+rug4dXd7bYt7bm+TQKE/I8hXXWhTthvmH2ujXg1BSyl1rI1BqRXFG 10Kr0WQ44OQ== X-Gm-Gg: ATEYQzw6volwxVfDwbFv7h/2bPt4qlpyKdj+rL8jtXxi27CBbL79tuNeCG/jVvv2ljq pgn2EWekYAjKxNDM4Pf6xILhvF1uw3nN3YDOt+qfe1fkX4LT1SZg2eJAU22aPgvl1QVIWjsNMF7 XcEp7L0ATgQIGPvlvkc11ONSToiDLKIFgJJRzUEc1tVvyfD2SK/MdnTTnPTVQCAtQP5wcwQaTkj 4XP3Dxf6g1xZQM1vD+YNZd3uCCYtnJLlV3O3y/6FH+vQr+8M9MWi8Y+0P+n17nLPe8JXTMajTw6 csz5qtEDQ3e0jlMH9WjAObVcmhUsd5IFOaXkeX1cx8egNA7/LpbN06gh7POuMc30GqDdpgFpjdk 9ZzofcGvWUbyMNBCBawsfB0aD3xqQZ7ijYkNBZUDQDn1vl+U0XmJBDkRMfq6iVp3ydPZfmg6A4z SehEyOpziFNCT17SmAW7LiHYuKQA== X-Received: by 2002:a05:7022:ea26:b0:12a:6b26:8618 with SMTP id a92af1059eb24-12be67b2c52mr99319c88.2.1774977756148; Tue, 31 Mar 2026 10:22:36 -0700 (PDT) Received: from mozart.vkv.me ([2001:5a8:468b:d015:36de:b209:4884:3260]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12ab97cb08csm17170946c88.3.2026.03.31.10.22.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 10:22:35 -0700 (PDT) Date: Tue, 31 Mar 2026 10:22:33 -0700 From: Calvin Owens To: linux-kernel@vger.kernel.org Cc: linux-perf-users@vger.kernel.org, x86@kernel.org, Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Thomas Gleixner , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: Re: [PATCH 2/2] perf: Don't throttle based on NMI watchdog events Message-ID: References: <685061daed5b505ef604835b602e0202531f2315.1774969692.git.calvin@wbinvd.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <685061daed5b505ef604835b602e0202531f2315.1774969692.git.calvin@wbinvd.org> On Tuesday 03/31 at 08:25 -0700, Calvin Owens wrote: > @@ -663,6 +666,17 @@ void perf_sample_event_took(u64 sample_len_ns) > if (avg_len <= max_len) > return; > > + /* > + * Very infrequent events like the perf counter hard watchdog > + * can trigger spurious throttling: skip throttling if the prior > + * NMI got here more than one second before this NMI began. > + */ > + now = local_clock(); > + delta = now - __this_cpu_read(last_throttle_clock); > + __this_cpu_write(last_throttle_clock, now); > + if (delta - sample_len_ns > NSEC_PER_SEC) > + return; Bah, Sashiko caught something obvious I missed: https://sashiko.dev/#/patchset/cover.1774969692.git.calvin%40wbinvd.org >> When the outer handler completes, its sample_len_ns (total execution >> time) will be strictly greater than delta (time since the inner >> handler finished). This guarantees delta < sample_len_ns, causing the >> subtraction to underflow to a massive positive value. >> >> The condition > NSEC_PER_SEC will then evaluate to true, and the outer >> handler will erroneously skip the perf throttling logic. Should this >> check be rewritten to avoid subtraction, perhaps by using if (delta > >> sample_len_ns + NSEC_PER_SEC)? The solution it proposed makes sense to me. > __report_avg = avg_len; > __report_allowed = max_len; > > -- > 2.47.3 >