From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 915DB395DAA for ; Wed, 15 Apr 2026 13:50:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776261028; cv=none; b=A5y3n+VXC6NNyR2Ae3XlgCv2MudZ9wJEdq8fZ8RVhU3tJ+qv/4If2wlNzNGTEcDXNRcwNUegOo8em7m2XQhVfAnr+DRz/LGjhZ5E9wBMBBxM0PaLR04Fruxs5QYN/XyidtAfrd36uWbt3Oqyw1SfeS6MwywdsO4vtEnpXFZTI40= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776261028; c=relaxed/simple; bh=eVNrw32cdCvsLSD61G9JKcU5GmtqCrVfszu08tUS68k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TDCtZEZ64+LIIKvEEahAfVFyLGXE/O8Cqcob/U7y6xZCGc0pZxaY2s1oXMvobwotC7q5/x0TIe2g7uOTI+99eyqJ0V2IxugNlF1NlCvbzu15q55TDtlRG/ZwIOYiOfjX1OzJ0j8cOqH3bWVLD5hfTiuBBT+NJsb8AOSl7tzDO94= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O+TVCkY0; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O+TVCkY0" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-488af9fdaa7so47716735e9.1 for ; Wed, 15 Apr 2026 06:50:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776261026; x=1776865826; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=g79BUYEA9YLVd9gvOkb8IdbY0UtoN0HAYMseG9etvGg=; b=O+TVCkY0NtumX0MrCWOhjfrFhpTT7saaAOe06NIJg5zDdL+44/3sZWckhduzZgI/WY VFxdjfrWd7J3uXz6bEw+LsCGxQQfVsMevNY4KcHiwcwa5NQWcHZ8UDOLeFB90tD8TNYz UX43NNIk7pNYfPwQzxpAo7RuZbNPlhvcVRxgxxG/KTSxaWu/09nSsj9c9BDs0aGikJQd 1NeYnXPWuCgPwEA3EP89pqywPve2vXvkbxMJRU6yygrHwwZZEUrb28wLqYemXNKDwgqN xhjEXat0mKGNk5V9eKP2WgstFfQZFDuADOSGsNsZ/MKvO1iJWa1POErPkuIvIc1aXGyy kmpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776261026; x=1776865826; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g79BUYEA9YLVd9gvOkb8IdbY0UtoN0HAYMseG9etvGg=; b=MncxIHJmPYonjEFiCwhLJeXtRC9n7WOedDLUzepolg6SgaINFY0tcVGNGetw6ARxVK ukThcD6J4mlSTlcq/qOVClLLH3peIYB1fzjPe+jebiT0TltuJ2oGS6fgHWG23AetIBQl 6qNmqR1U1iINrMPjhoQ6op5g50moDflw58EgsorxkSPqW6XQuSrQxPvpupTLC3x9EXtN FltL5WFQyyD/g4yc1bQhlCGD6zEzu3UJdJwG9pcwS4jHaaS9AuJe8mZK2AWNsnxQab/4 UG55jlc42WYjPMQzzHHg0CLRlvm8p8NPf2MjBnLgmsVLjAeCya7MBwLJU5IpLpukx3/M Waaw== X-Forwarded-Encrypted: i=1; AFNElJ/714wSK6Il5m4vby06HBHcV/R+WUWVuVa7rtgJsxwQ3hcZuTxzKRWH8H7Xc0xdui7kB6aTyGD8Ki68kvI=@vger.kernel.org X-Gm-Message-State: AOJu0YwpLbPav3zTXgj76xhk8wOjwmSPW28Frb44/tykH9KdNal1WXDM ynvVIPQm7wxDNIR+Ri4HnTcYZ7owbt/5RsbFIEwoVp8SmZKiJUuOXrlI X-Gm-Gg: AeBDietuPyKpgRhJqGKS0hc3jhvPpgItLwcxJbf0//qYeq4XGIMRWXmF3oL2y44geNa CQvInqdymXxLAV49iHGpaTDX8Hx7uWKdnQOorGm0uf2+oj+W62Fi9jhoEnp+46433tYQspM6pFR 97zHp90jCXglIA/DXP+jx653uifSA+fjws4nArVDnBNWthJjv8i7fhUJYaKPQdRsHeivKJwPvMx r8jsa8KuvCrTn6Ltl4yJUk92cCPfCJcJFcFBt8onNlzA59pRUPhv7PwTummp+zKj9iuIBFvXEV3 iZkQqtQK95xkuufShyGyuFhpSU6zHriKnLRw39BZAcEonucCm6PJBzQ5J79q8h1emkHk481AcOl UPUAghiwYbFBqt7tOcY/eyYZ4Wraa29ehBy0Ut4utGHOG3h1RlgrBdunSOMrwrihFjQ+gPvYF9L BitnEC6vAx0sky/GFkyAVvpKtx/BJndw== X-Received: by 2002:a05:600c:8591:b0:488:a824:fe04 with SMTP id 5b1f17b1804b1-488d6abe9e4mr219085585e9.26.1776261025568; Wed, 15 Apr 2026 06:50:25 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f0ec6d2dsm20410085e9.30.2026.04.15.06.50.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 06:50:24 -0700 (PDT) Date: Wed, 15 Apr 2026 16:50:21 +0300 From: Dan Carpenter To: luka.gejak@linux.dev Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3] staging: rtl8723bs: fix remote heap info disclosure and OOB reads Message-ID: References: <20260415133726.23515-1-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260415133726.23515-1-luka.gejak@linux.dev> On Wed, Apr 15, 2026 at 03:37:26PM +0200, luka.gejak@linux.dev wrote: > From: Luka Gejak > > When building an association request frame, the driver iterates over > the ies received from the ap. In three places, the driver trusts the > attacker-controlled pIE->length without validating that it meets the > minimum expected size for the respective ie. > > For WLAN_EID_HT_CAPABILITY, this causes an oob read of adjacent heap > memory which is then transmitted over the air (remote heap information > disclosure). For WLAN_EID_VENDOR_SPECIFIC, it causes two separate oob > reads: one when checking the 4-byte oui, and another when copying the > 14-byte wps ie. > > Fix these issues by adding explicit length checks and returning a > failure if the length is insufficient. For HT_CAPABILITY, also clamp > the length passed to rtw_set_ie() to the struct size. > > Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") > Cc: stable@vger.kernel.org > Signed-off-by: Luka Gejak > --- > Changes in v3: > - Switched to fail-fast handling for malformed IEs in issue_assocreq(). > - Fixed HT capability path to use structure-sized output length in rtw_set_ie(). > - Updated commit message to reflect all oob read cases. > > Changes in v2: > - Refactored rtw_set_ie() alignment to follow "open parenthesis" style. > - Allowed the line length to exceed 100 characters for better readability as requested by Greg KH. > > drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c > index 5f00fe282d1b..3d44bc36532d 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c > +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c > @@ -2929,6 +2929,9 @@ void issue_assocreq(struct adapter *padapter) > > switch (pIE->element_id) { > case WLAN_EID_VENDOR_SPECIFIC: > + if (pIE->length < 4) > + goto exit; Oh huh. I was more thinking about an upper bound, but yeah we need a both. Anyway, what should the upper bound be? regards, dan carpenter