From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8014732D0F5 for ; Wed, 15 Apr 2026 14:26:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776263176; cv=none; b=c+cJEc1V57E4NY2TMhw2HRq3cNZ1mEnQOYRAW8Aa1PHJDnzfTVrqBSgTaLO8WD4+1Fm15r51MxaL1x1zRJpAD2sf5SKdy90c0LRhGE3W3YpXeWBBivQnjk/718HpGpfkoz7i4rDZzdIBY8CuTwcMgVF+trHVqFIfndKcMuHi+ko= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776263176; c=relaxed/simple; bh=V9FnfRjNkKK4hWVizzC8EoWoKNwrk1jrtgIntD8T7vU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=V566KMDFMbX3raqKhhlSIQlGIIlgN8ZZaYPuSYOx6hIwjm64jcxG/cttxgT6S0Y4bi/AXSqiRae8ZCU8vVcw2ZNr20YbvxGx9PNa/STQEtccJTHYN8kX3BV0ItDVaWtT4tBSMwSIQy72ojaf5ek43fRcEHJnotN6JMu3vqLQsv8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=K9Z5GKFB; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="K9Z5GKFB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1776263175; x=1807799175; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=V9FnfRjNkKK4hWVizzC8EoWoKNwrk1jrtgIntD8T7vU=; b=K9Z5GKFBn5OtTzbRxTBudfLbPBaW0MEtU7odB8uhUpe3WQzsXGGqvnBL tpcpVK11xVcnSW9wMiMHekyQeOF+Jb7o583xZlobIlvrgTOafMPKjfkiZ Y3XzngaE0gIVMiI8WYpxP2HcNWKKL/RLWRPH3NC6hKXgiw3Sd4znCeNQZ EiXLtIKkgNQkJN0BPdUtFXdWNfpoytDmAGeH0L5Lyy8Z4g6KdUaBqmvzr +622YQEuVcgHETQyAnXc+1bvk4HaJsOyvAzi+GXjImUt/4T/MDsYcI85T vYOH8XgHlD8edSG9xa8QwHnJlfy/4648CyxeJ28l7DFMM4H91zPP5o9xN w==; X-CSE-ConnectionGUID: vsz8a2bGQ4CH5SOY3ABGDw== X-CSE-MsgGUID: 6UHG0jvkSBKAb57Y0EsdhA== X-IronPort-AV: E=McAfee;i="6800,10657,11760"; a="102699893" X-IronPort-AV: E=Sophos;i="6.23,179,1770624000"; d="scan'208";a="102699893" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2026 07:26:14 -0700 X-CSE-ConnectionGUID: KRmf6356Q+qZWYn71KIxMA== X-CSE-MsgGUID: luQVx9hNTjOAUoe5AwoIeg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,179,1770624000"; d="scan'208";a="234826330" Received: from rvuia-mobl.ger.corp.intel.com (HELO localhost) ([10.245.244.34]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2026 07:26:11 -0700 Date: Wed, 15 Apr 2026 17:26:08 +0300 From: Andy Shevchenko To: David Gow Cc: Ingo Molnar , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, Andy Shevchenko , Arnd Bergmann , Nikolay Borisov , "H . Peter Anvin" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/boot/e820: Re-enable fallback if e820 table is empty Message-ID: References: <20260415003021.1543723-1-david@davidgow.net> <5eed2487-4ccc-46d1-9227-46d729087505@davidgow.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5eed2487-4ccc-46d1-9227-46d729087505@davidgow.net> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, Apr 15, 2026 at 09:50:32PM +0800, David Gow wrote: > Le 15/04/2026 à 4:51 PM, Andy Shevchenko a écrit : > > On Wed, Apr 15, 2026 at 08:30:18AM +0800, David Gow wrote: ... > > > struct boot_e820_entry *entry = entries; > > > + /* If there aren't any entries, we'll want to fall-back to another source. */ > > > + if (!nr_entries) > > > + return -1; > > > > Can we return -ENODATA or -ENOENT here? > > Sounds like a good idea. The previous code (like this) used -1 for both > "there are no entires" and "there are entries which look bogus". Maybe we > should replace the latter with -EINVAL, too. Maybe, but is it related to (coupled with) this change? If not, we can do it later if needed. -- With Best Regards, Andy Shevchenko