From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 520ADC433E6 for ; Sat, 30 Jan 2021 20:48:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1BBE764E17 for ; Sat, 30 Jan 2021 20:48:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232216AbhA3Usa (ORCPT ); Sat, 30 Jan 2021 15:48:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:52628 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230517AbhA3Us2 (ORCPT ); Sat, 30 Jan 2021 15:48:28 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id BE19464E0E; Sat, 30 Jan 2021 20:47:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612039668; bh=bLI+ZNwZ/Px1wCi6hAgk4/4culKMpmswS9uXcxraxYg=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=CLiYs4yeKmz/ahstkrgtQsBiQkWseA6roT+zDTfPndAuKeoJRdfdF7/edA1Xtb2Qx Rn5U5twSSATBFNMN4vtcJKtYewLbabTYWv30YnQlMDZuZ8bZHtyIhM7rqPFeiRJaPG YKSHpNAHMhcZ2JeoRfNV4EkHZxLv500f4QSBbheqvShnmOc8TReBm2MvjPJoGusQxx GhwI2jAx5mhBR+tJw5oqzxh5mhJdZo6ZJiDvAHhZ4eWM9sNglWHERrgLZOCxdrjzVp xRn+DhNwduxNUp2e2uJU+EI01mvU1PrD7byhVpsPuC0pG7R7WZJugxdSyzYloLP13u mulDXXspf9PNg== Message-ID: Subject: Re: [PATCH v2] tpm_tis: Add missing tpm_request/relinquish_locality calls From: Jarkko Sakkinen To: Lukasz Majczak , Guenter Roeck , James Bottomley Cc: Tj , Dirk Gouders , Peter Huewe , Jason Gunthorpe , linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, Radoslaw Biernacki , Marcin Wojtas , Alex Levin Date: Sat, 30 Jan 2021 22:47:43 +0200 In-Reply-To: <464454f440df67d3470e67ff0386bbc306d07dac.camel@kernel.org> References: <20210123014247.989368-1-lma@semihalf.com> <20210128130753.1283534-1-lma@semihalf.com> <464454f440df67d3470e67ff0386bbc306d07dac.camel@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.38.3 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2021-01-30 at 22:40 +0200, Jarkko Sakkinen wrote: > On Thu, 2021-01-28 at 14:07 +0100, Lukasz Majczak wrote: > > There is a missing call to tpm_request_locality before the call to > > the tpm_get_timeouts() and tpm_tis_probe_irq_single(). As the current > > approach might work for tpm2, it fails for tpm1.x - in that case > > call to tpm_get_timeouts() or tpm_tis_probe_irq_single() > > without locality fails and in turn causes tpm_tis_core_init() to fail. > > Tested on Samsung Chromebook Pro (Caroline). > >=20 > > Signed-off-by: Lukasz Majczak >=20 > Is it possible that you test against linux-next and see if any > problems still arise? I've applied the locality fixes from James. Also one nit: if any problems still persist, please add a snippet from klog to your commit message. /Jarkko