From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B97D31DD9B for ; Thu, 16 Oct 2025 09:52:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760608342; cv=none; b=UdXY1bq2IC6JGuPtSadd7C48oK4dMaGBZIX16Gmptr+NADqRJ/DFNCIGhM0YNZu+NDZ7jPu7EYwwaDHrW+l9tB7xOhWAUyEvkui/d4Me7iVSxTf4i7N+cF+xcAplNEMqornKjP63gHEQPCzpKsuWhVoNMzOeLhANIFeCIC6YbNo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760608342; c=relaxed/simple; bh=jE2GoX19eyhmDAzyJNkgxtQN6Hq02Z1VjLQd8iVTPAM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZDwTM7kxh8HAwwDBx4j1wjiPY9jCj8nnXAyYXQ8ycAeZZrBre7Um6rOP4RF5LKuuUkckbRaULWa5Uxalhk+15sCgWYlVhbr4Y8wATy6uztRqXnUIv26njTDOtRRzVrN6ODqlgvy03GWqwPfsTWCjc2HAmayPyegLQl+5pfVNo3k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JoUTjwmf; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JoUTjwmf" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-580585075aeso93672e87.2 for ; Thu, 16 Oct 2025 02:52:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760608329; x=1761213129; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jn4dZoKK26RuIY2MUwW65nuRqIMdpVV2Qu/kLcTzIEE=; b=JoUTjwmfP6jWMtxLJ31VW4DUdqWdZAzEXyHedVQHXPHsvLhmcHEG0yM24AU81jCq/B n8mL2ghF4Jv3j9zz4d7Mn0cDsFu5hNthEpWimSV5Cjhkh0Rlu9GQ5vndEzxk7yAt+t/V BLvpONm5VTDEF0JCiswwbsJdl8usxQK/A9hBwa9s1zKY+NmU8jXS7lcNZIHnUizeKErv LAS3gAD1Jtt1yMmJ8O/lsfTLqctnY2SEwiweOiEPfHmQjn8TdEtNpUE03zRhuY63U4P9 HPJuXx3etp55tQbclfZVDQIX91ZbroaFSeqAMHqDhdG4J6B0tFXPz+OoASqWYKhQrxKy 4R+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760608329; x=1761213129; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jn4dZoKK26RuIY2MUwW65nuRqIMdpVV2Qu/kLcTzIEE=; b=A+sRFB0W4TI/VDkMJvqBkYUvuSu6vgI0bhWKaxmHitLu4iQWe4EjxGakimjImjQ9q+ JZtN+QZNnkR2gOPtmqUHotCpTBrfVNOlekASQGm89tXDvc0qPDOR7VJqiuEjHrGb9j74 fwcsuPVVo8232Or4BUExKvMlDsHq7r90pdd0/0EDtteLg9eu1YVvGQQgeObEH/USS8Ts r5U5vV9fekCAaWv7vsr75ZCtIt4xlI3kF5e+Gl/74LMU00ZfRf5a0a8Ex152IVQ+cy+k dBc7yKEF2eynqijbAB/Kbi5UBWjKONnpTF3z+B3EgWT+t/BfztTk2PgZHH3PtLl4pg6n 2HRg== X-Forwarded-Encrypted: i=1; AJvYcCVpk/ygrLQCkYCKV3rykOcPEz0aVPpHdkTuEDStzchiv4nvwMYDSbZJ1cie5ebGW4B/JBFPEwinWhmDogw=@vger.kernel.org X-Gm-Message-State: AOJu0YxGFsKfyyzuVQdY8RHHl1NswGzk2vN6EISbvc966ZXo/lQwuEQF t+SDvWo2CNc6P+Gi5nkccQ50qlnYd/sgx7WllLF7ZBXUiuqhJ6F0GSAb5lI8ZfadBSc= X-Gm-Gg: ASbGncubA0kEU+cOq/tA+Nlfd2Ev1ACjq7OQdXqftdXDceJadzMw3L08WtYzTjYlYxT Kt+81y9L6gxzh0Q4zqdZGWdpdWwRe73LZHSMVQ0RthgfFIQ8TKANQr7ACvrM8ohJOb18M2k/q8g qD8TXpAQva0HHOBwMmMnrQ8kryqOt5GTgTG87p034d88Wp1dhQ+hYzFjbndcG6jpS9TsJybJD4C rR0MaFCCzEUsvN1QZGfmccy+l2CH2S1VgRL0g/c7lghxay/ThL25yVkBxVanocFW86gW39wzHwC xZrD0but5HCwPryOumN1KiDIFeb88NtU1AN/YeIAPjRl5/J+Ep2tjm/YH6h9GUfPUMOtKJiG+OZ fd1CMjXNjXi/tu0Rwp5xsY8jvzbY5+h9N0U2979nkxBGSf9gXBjmPxmgEckgaIElxJBVNwTt2/3 7of7JxiUMO3XN/BkVYIlL4KzC+5gjO/N1QWLOFVv11NLugWR+jgXupCfeNLFA= X-Google-Smtp-Source: AGHT+IHGrMqF/SxK/b9Eusc1EmuTMX1oF3LiG7gqz6PSDdypVz3evm0d5vIiv9I+NCKFDiLfXQtkSg== X-Received: by 2002:a05:651c:2224:b0:36c:ebb0:820c with SMTP id 38308e7fff4ca-37609e72b63mr40963831fa.7.1760608328682; Thu, 16 Oct 2025 02:52:08 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3762e77ea1fsm54348501fa.3.2025.10.16.02.52.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Oct 2025 02:52:08 -0700 (PDT) Message-ID: Date: Thu, 16 Oct 2025 12:52:07 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/2] arm64: dts: qcom: qcs8300: Add support for camss Content-Language: ru-RU To: Krzysztof Kozlowski , Vikram Sharma , mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, hverkuil-cisco@xs4all.nl, cros-qcom-dts-watchers@chromium.org, catalin.marinas@arm.com, will@kernel.org Cc: linux-arm-kernel@lists.infradead.org, quic_svankada@quicinc.com, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio , bryan.odonoghue@linaro.org References: <20251015130130.2790829-1-quic_vikramsa@quicinc.com> <20251015130130.2790829-3-quic_vikramsa@quicinc.com> <8966ddaf-9c10-4626-a4cc-36efd3fc93e2@kernel.org> From: Vladimir Zapolskiy In-Reply-To: <8966ddaf-9c10-4626-a4cc-36efd3fc93e2@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/16/25 08:59, Krzysztof Kozlowski wrote: > On 15/10/2025 20:49, Vladimir Zapolskiy wrote: >> On 10/15/25 16:01, Vikram Sharma wrote: >>> Add changes to support the camera subsystem on the QCS8300. >>> >>> Reviewed-by: Konrad Dybcio >>> Reviewed-by: Bryan O'Donoghue >>> Signed-off-by: Vikram Sharma >>> --- >>> arch/arm64/boot/dts/qcom/qcs8300.dtsi | 171 ++++++++++++++++++++++++++ >>> 1 file changed, 171 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300.dtsi b/arch/arm64/boot/dts/qcom/qcs8300.dtsi >>> index 8d78ccac411e..acd475555115 100644 >>> --- a/arch/arm64/boot/dts/qcom/qcs8300.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/qcs8300.dtsi >>> @@ -4769,6 +4769,177 @@ videocc: clock-controller@abf0000 { >>> #power-domain-cells = <1>; >>> }; >>> >>> + camss: isp@ac78000 { >>> + compatible = "qcom,qcs8300-camss"; >>> + >>> + reg = <0x0 0xac78000 0x0 0x1000>, >>> + <0x0 0xac7a000 0x0 0xf00>, >>> + <0x0 0xac7c000 0x0 0xf00>, >>> + <0x0 0xac84000 0x0 0xf00>, >>> + <0x0 0xac88000 0x0 0xf00>, >>> + <0x0 0xac8c000 0x0 0xf00>, >>> + <0x0 0xac90000 0x0 0xf00>, >>> + <0x0 0xac94000 0x0 0xf00>, >>> + <0x0 0xac9c000 0x0 0x2000>, >>> + <0x0 0xac9e000 0x0 0x2000>, >>> + <0x0 0xaca0000 0x0 0x2000>, >>> + <0x0 0xacac000 0x0 0x400>, >>> + <0x0 0xacad000 0x0 0x400>, >>> + <0x0 0xacae000 0x0 0x400>, >>> + <0x0 0xac4d000 0x0 0xf000>, >>> + <0x0 0xac60000 0x0 0xf000>, >>> + <0x0 0xac85000 0x0 0xd00>, >>> + <0x0 0xac89000 0x0 0xd00>, >>> + <0x0 0xac8d000 0x0 0xd00>, >>> + <0x0 0xac91000 0x0 0xd00>, >>> + <0x0 0xac95000 0x0 0xd00>; >>> + reg-names = "csid_wrapper", >>> + "csid0", >> >> The list of 'reg-names' is not alphanumerically sorted, this is a newly >> introduced sorting order pattern of CAMSS 'reg' property values. > > Please stop inventing ad-hoc or fake rules. There is no such sorting > pattern for this property, which I expressed multiple times. Last time > you claimed there is some sorting by "values", now this. > The sorting order above does not resemble the order present on other CAMSS devices, which is the alphanumerical sorting order. The same order is supposed to be kept. -- Best wishes, Vladimir