From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31163C77B72 for ; Mon, 17 Apr 2023 07:45:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230304AbjDQHpN (ORCPT ); Mon, 17 Apr 2023 03:45:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229658AbjDQHpC (ORCPT ); Mon, 17 Apr 2023 03:45:02 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F37C358E; Mon, 17 Apr 2023 00:44:44 -0700 (PDT) Received: from [IPV6:2001:b07:2ed:14ed:c5f8:7372:f042:90a2] (unknown [IPv6:2001:b07:2ed:14ed:c5f8:7372:f042:90a2]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id AD2346602F91; Mon, 17 Apr 2023 08:44:41 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1681717482; bh=4ju2sjdECGeN8KyDD+a8vUNcwUjOKUkgswflyYi99Wg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=md97EAfMLICLqvYW/f+XUwyoMyVlvKHug1PQ/NPDtwv+z02yXSSAB24+d5spuEXxG OMYX1Gt2+6g6KY/ZvjT5sQ/TQaGoQtjZFPLuQdAOW5RC/IO0eelyn/5eeOgZ5+SRDh zKl1F5FCEZSyBAWVq3Td3sl0pH3wbh6IqdsCL/oRw2mM9ln1izz8BA+rdnamGIJFTL +QckzYq0H5ePOVfjZ24MhoV95jSxUwF0rXH7VtLxh0Z48j1DTZGN13FkYqVwXxvmk4 aeQ57ikMa3pS1XWYHJIKEKSZ9F7bJxT9BJ0HVBtjksrzvwIT4sEnAyZ8bVhR/M/1yb +jH9qa2cndHKQ== Message-ID: Date: Mon, 17 Apr 2023 09:44:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] media: mediatek: vcodec: Move a variable assignment behind condition checks in vdec_vp9_slice_single_decode() Content-Language: en-US To: Markus Elfring , kernel-janitors@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, Andrew-CT Chen , Ezequiel Garcia , Guo Zhengkui , Hans Verkuil , Haowen Bai , Matthias Brugger , Mauro Carvalho Chehab , Mingjia Zhang , Tiffany Lin , Xiaoyong Lu , Yunfei Dong Cc: cocci@inria.fr, LKML References: <40c60719-4bfe-b1a4-ead7-724b84637f55@web.de> <1a11455f-ab57-dce0-1677-6beb8492a257@web.de> From: AngeloGioacchino Del Regno In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 14/04/23 20:30, Markus Elfring ha scritto: > Date: Fri, 14 Apr 2023 20:07:01 +0200 > > The address of a data structure member was determined before > a corresponding null pointer check in the implementation of > the function “vdec_vp9_slice_single_decode”. > > Thus avoid the risk for undefined behaviour by moving the assignment > for the variable “pfc” behind some condition checks. > > This issue was detected by using the Coccinelle software. > > Fixes: b0f407c19648ae9110c932c91d6e1b9381ec0aeb ("media: mediatek: vcodec: add vp9 decoder driver for mt8186") > Signed-off-by: Markus Elfring Reviewed-by: AngeloGioacchino Del Regno