From: Paolo Abeni <pabeni@redhat.com>
To: Roger Quadros <rogerq@kernel.org>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
vladimir.oltean@nxp.com
Cc: horms@kernel.org, s-vadapalli@ti.com, srk@ti.com,
vigneshr@ti.com, p-varis@ti.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] net: ethernet: ti: am65-cpsw-qos: Add Frame Preemption MAC Merge support
Date: Tue, 19 Sep 2023 15:13:35 +0200 [thread overview]
Message-ID: <ad0a961c523aa50f25380b339e1cb6f50109a5fe.camel@redhat.com> (raw)
In-Reply-To: <20230918095346.91592-1-rogerq@kernel.org>
On Mon, 2023-09-18 at 12:53 +0300, Roger Quadros wrote:
> Add driver support for viewing / changing the MAC Merge sublayer
> parameters and seeing the verification state machine's current state
> via ethtool.
>
> As hardware does not support interrupt notification for verification
> events we resort to polling on link up. On link up we try a couple of
> times for verification success and if unsuccessful then give up.
>
> The Frame Preemption feature is described in the Technical Reference
> Manual [1] in section:
> 12.3.1.4.6.7 Intersperced Express Traffic (IET – P802.3br/D2.0)
>
> Due to Silicon Errata i2208 [2] we set limit min IET fragment size to 124.
>
> [1] AM62x TRM - https://www.ti.com/lit/ug/spruiv7a/spruiv7a.pdf
> [2] AM62x Silicon Errata - https://www.ti.com/lit/er/sprz487c/sprz487c.pdf
>
> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> ---
> drivers/net/ethernet/ti/am65-cpsw-ethtool.c | 150 ++++++++++++
> drivers/net/ethernet/ti/am65-cpsw-nuss.c | 2 +
> drivers/net/ethernet/ti/am65-cpsw-nuss.h | 5 +
> drivers/net/ethernet/ti/am65-cpsw-qos.c | 240 ++++++++++++++++----
> drivers/net/ethernet/ti/am65-cpsw-qos.h | 104 +++++++++
> 5 files changed, 454 insertions(+), 47 deletions(-)
>
> Changelog:
>
> v3:
> - Rebase on top of v6.6-rc1 and mqprio support [1]
I'm unsure if this will require a rebase for the next revision of the
mqprio support. Anyhow the two patches are related, it's probably
better bundle them in a series so that the dep is straight-forward.
When reposting, please insert the target tree in the subject profix
(net-next in this case).
Thanks!
Paolo
next prev parent reply other threads:[~2023-09-19 13:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 9:53 Roger Quadros
2023-09-19 13:13 ` Paolo Abeni [this message]
2023-09-20 7:20 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad0a961c523aa50f25380b339e1cb6f50109a5fe.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p-varis@ti.com \
--cc=rogerq@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®