From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E58DC76188 for ; Wed, 5 Apr 2023 12:23:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237948AbjDEMXX (ORCPT ); Wed, 5 Apr 2023 08:23:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237438AbjDEMXS (ORCPT ); Wed, 5 Apr 2023 08:23:18 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39F1246B2; Wed, 5 Apr 2023 05:23:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=lU7svaiswKHSynUrMk/7luYxKwuxn6hkYss2TudorTE=; b=5WuK6jgb2zcW+n3daLQ3QLR4DT 9y+T9eU6neOC7QhRU+JNbiBsfC6LjALDRSO1uxX8PNa2qHkUPtB9u7dJ81m+zINHEmaY6ru7BH2Q3 hF/Tgqcazu3qTO/hmaxlY+g+aVaKa3yRx0Kqpy3Sojzh5iY1zgbc3EZ1oFFZjoY1bNi8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1pk2AB-009WBV-DM; Wed, 05 Apr 2023 14:22:55 +0200 Date: Wed, 5 Apr 2023 14:22:55 +0200 From: Andrew Lunn To: Marco Felsch Cc: Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Florian Fainelli , Broadcom internal kernel review list , Richard Cochran , Radu Pirea , Shyam Sundar S K , Yisen Zhuang , Salil Mehta , Jassi Brar , Ilias Apalodimas , Iyappan Subramanian , Keyur Chudgar , Quan Nguyen , "Rafael J. Wysocki" , Len Brown , Rob Herring , Frank Rowand , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 06/12] net: phy: add phy_device_atomic_register helper Message-ID: References: <20230405-net-next-topic-net-phy-reset-v1-0-7e5329f08002@pengutronix.de> <20230405-net-next-topic-net-phy-reset-v1-6-7e5329f08002@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230405-net-next-topic-net-phy-reset-v1-6-7e5329f08002@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > To bundle the phy firmware parsing step within phx_device.c the commit > copies the required code from fwnode_mdio.c. After we converterd all > callers of fwnode_mdiobus_* to this new API we can remove the support > from fwnode_mdio.c. Why bundle the code? Why not call it in fwnode_mdio.c? The bundling in this patch makes it harder to see the interesting part of this patch, how the reset is handled. That is what this whole patchset is about, so you want the review focus to be on that. Andrew