From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA3DB327C1C for ; Fri, 28 Nov 2025 12:09:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764331755; cv=none; b=IIUyt+BzL7ybCTRLtvpXFBhFTXuoujoUqbm7aq34qTo6ViErj1mnWxCA/vIztnArznvlafjbaHxf1HPdp3Mfo0SPi3l6U1r895m6uhjHr+JBWBXOQwGHwAi6uEDWq9Nm3KGwgu1w7GE2ueKgALeXwWtxQwDq+zbiBjA5wt+rgdk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764331755; c=relaxed/simple; bh=X1HS5RlkUvR5Mf8gx702VBsaC1MZAXNBdmskBGMUR0M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jBtlg4mefDiw6Ans99D+TdCDbhWotlu9QDd2Pj09BWm5ahJUmRsqBkW/sPErG4k7A2ddiSi+12MrLWgvMUx29aKWzlN3DgvHpxvnFJwOnCKVu+XDEVmKKAiTEhpJbCkp6LOgCIp5xioPctUiTMPIzG72w0kvMdD5VLIkx/Y882M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Oj0wD+NB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bZ3gEkA2; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Oj0wD+NB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bZ3gEkA2" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AS8rpdg3989835 for ; Fri, 28 Nov 2025 12:09:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= oKr4XY9THa4Qu8ZVXHA8oIuhhADCzAa7liI6QcgD5Bg=; b=Oj0wD+NBsJfLG7kS rgz8ucAmAqBVj2irLdvWim0gmgDBwSzu++UOBfdAZrRouzbL8fUOHV0GG5xa8y/Z gQsnNdNIwV+dcUIk76tnVDcvpraFjGZoqEvgToT8Je9V89991MX+JGQw3W7RyOcJ m0VPn7sTll5B7FiJSBSIQl377H8qS0bOA53KYClZ3XYS7pjUtmquEKxvxDlDr6J6 WZVWBjZv2vubGY1UXbp+yyBck2AFMb5xMEnYqgfXKm6BK18aY7S80DGKn/2S/BhI o946jj8nhZWdkmXvY79m2awy8O6/6YjqO9UM68mQDnz0Lxk7ZWIfl2A5MOzOM7vP 9ZdvZw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aq8mm8h9y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 28 Nov 2025 12:09:09 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4edaa289e0dso7230591cf.3 for ; Fri, 28 Nov 2025 04:09:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764331749; x=1764936549; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oKr4XY9THa4Qu8ZVXHA8oIuhhADCzAa7liI6QcgD5Bg=; b=bZ3gEkA2azsXUqHwBB+MyR6D4ZDe5Yxba6Ps5hYY+zAqLwfMVew+/B7n0VmxKlGa08 3J9cgeMECU8p9zVgU4DNedDRfRXWQtpqOWnb+R9t7OJGJdMetwaPOl1UUCloHdfuo07t KD8xWedETYo17Eb1lv9PXUU/cdqN9yg0PjQp7h/60u8hm0s+dVcieyJ0BmqK9kCW7ysD Xx7ZG1o5Sj9gr4Z5mb0ksQbkUas8SwrmMMZyX1rpUWcnmxn+kricgqn4JGSPt8WO7h71 BK8pBlN0oxas+XNKBBnDK6ZZx42r1JqKlwGzLFIFNwlcRfWUaWklazLsNy3oCgfv+sdc AqcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764331749; x=1764936549; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oKr4XY9THa4Qu8ZVXHA8oIuhhADCzAa7liI6QcgD5Bg=; b=Lcvj+ShoPUrS3zBh44g8M3cQz0dUnlr6p7rYqvfz+eHzIQXi+cl64fFc/px3K9j0Cb NquA565TwYoflH4cp+KDiSdmOnzm3hyP6Ebdalj87Z9m5cQksMFiU46PPwcxQrwrIGqD 0SflbiFESNl6QEiYbM4F27TcKKtPQfskPvvJFVP9BfBSLdcarKEcAnLPs8iUwhcXDTwl iksb5uKFvJACBbEToeI7pbgK3sXypOp0KoYs/BhlzJ0ucKF3D7OhHwOozAm+dQK12/Ms Ys1EGKoXH8tnOX7o+lp05uqhI9fmnm16Xwe0gb0gF/b1nrrSmuKNxUkIxNwFyAnHGI4x dLMA== X-Forwarded-Encrypted: i=1; AJvYcCXS0NjdhrlUg1czQyfMTg4EOpxyNT7eMvuKtAJGR9s0tZ8lAoRP6rXZynDsVihkl2HLv4X6T5VkzeTQpM8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7sR/Xo6znHvitRjPYOswTJPO3bmmFnW4ylCHNjuPTfZ0UJxZ7 YxWbk0yGYr3JTUIkqXzymLmFGNLTRE8s2bCvXeCD1HzDdODQwhOjrNsImhF/IYXPEHlQrfsiCQN Bha+PKvf9wIgoAqp/mlzf2p1DvRJKNT3xOLRGGd3ZfC+6Kud7M6qtsAykTU3P5/CESOg= X-Gm-Gg: ASbGncu7nQCeu3RwRJSGyZ9r3tgDp3EHrj8XnHsk5bFRSo/WwJv4NnC1W8fKmJ4o9iL BJ1UxNnvU4+lCOm18eyAe+V3ZjH6xhDv/jYFYpymOyMBEXSFCJ23nvBkWLfA6VjquJ9KTS/a4lK kyF21vaV61jJKVGw0pPKnpl+z0n2hajWgkr/F4VWp19CyW1wp6Kvb1ST/Puaml7ufroAiYKtZo/ 59kFxn3svXB99xyD1LG6t4Wok24Mx/Gu6MMqLxlOkbzbf2gTrRd3mDwgDwhR43VJLQL7yd4aIph NsUUWdnXeKISr47n9MKd9l7Ob/dBwD1MEf4SEtsreDLOybY/ONPEIbzwjhNZMyJnBfnLgLIetZs ylEZ9PfJqwTaRd38K2vpZVCiPJVNXoXtfiqGGJy7nemJbSkvHrEioXUn/hMpEJjQqqss= X-Received: by 2002:a05:622a:1108:b0:4ed:a574:64cb with SMTP id d75a77b69052e-4ee58850982mr276238751cf.3.1764331748308; Fri, 28 Nov 2025 04:09:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IHAlY7BCtEp8q1QrNP4N2hl0KDcfWriM03Y+3OtjNiiPI9HSZHAnlbAIOL1EnnUjZgYWinnMQ== X-Received: by 2002:a05:622a:1108:b0:4ed:a574:64cb with SMTP id d75a77b69052e-4ee58850982mr276238361cf.3.1764331747902; Fri, 28 Nov 2025 04:09:07 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f5162d49sm421867666b.14.2025.11.28.04.09.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Nov 2025 04:09:07 -0800 (PST) Message-ID: Date: Fri, 28 Nov 2025 13:09:04 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 05/11] crypto: qce - Remove unused ignore_buf To: Bartosz Golaszewski Cc: Vinod Koul , Jonathan Corbet , Thara Gopinath , Herbert Xu , "David S. Miller" , Udit Tiwari , Daniel Perez-Zoghbi , Md Sadre Alam , Dmitry Baryshkov , dmaengine@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, Bartosz Golaszewski References: <20251128-qcom-qce-cmd-descr-v9-0-9a5f72b89722@linaro.org> <20251128-qcom-qce-cmd-descr-v9-5-9a5f72b89722@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: wa4XW50L1_EURKps-OyHF5FAJdKXTlvV X-Proofpoint-GUID: wa4XW50L1_EURKps-OyHF5FAJdKXTlvV X-Authority-Analysis: v=2.4 cv=Cvqys34D c=1 sm=1 tr=0 ts=692990e5 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=jrMBgjXTAAAA:20 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=ENz42x8E23rwaKT2S0YA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=cvBusfyB2V15izCimMoJ:22 a=bA3UWDv6hWIuX7UZL3qL:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI4MDA4OCBTYWx0ZWRfXzOhtNO11y5rx tOw8fT0p1WDgnnZBBAuaSVN2HUtlxLw51DRBeMvu+TasHy9+CMlncZYX/oadqv0fNaoqMcMBQPQ /0gc0be7iADNRmQwE1vtSTNeb8ndwn5V4CfVVvqPOTFW9msB1ePePtrDOBRZz4SNM9YaqZCoDNw DTPpUX7liCRisC1vtuRm2gWEDEGCEEjecrvKQVddp25VLs2dpuYXfhvluDtOBGrp/3pbBmx/Bna Gp0ea2TKTdXsDMaZ6HYDBNOgfYiINtiwBZLhLWO14DP6ej6DY514auKtNVxL/3JscdEQQBCFjUJ SoB1bSzBOgDFmgmDpNIlQ5cg94YbS6Ks6KVjoLTb6km+95JUPeaqEoAG+eBFPrdZOEaeWxBdM6m H0mBp6mzk59MEPxwUCQpu3Yu2cxtSQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-28_03,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511280088 On 11/28/25 1:05 PM, Bartosz Golaszewski wrote: > On Fri, Nov 28, 2025 at 1:02 PM Konrad Dybcio > wrote: >> >> On 11/28/25 12:44 PM, Bartosz Golaszewski wrote: >>> From: Bartosz Golaszewski >>> >>> It's unclear what the purpose of this field is. It has been here since >>> the initial commit but without any explanation. The driver works fine >>> without it. We still keep allocating more space in the result buffer, we >>> just don't need to store its address. While at it: move the >>> QCE_IGNORE_BUF_SZ definition into dma.c as it's not used outside of this >>> compilation unit. >> >> It's apparently used downstream, at a glance to work around some oddities >> >> https://github.com/cupid-development/android_kernel_xiaomi_sm8450/blob/lineage-22.2/drivers/crypto/msm/qce50.c >> > > Thanks. This driver is very far from upstream. :) > > I think it's still safe to remove it. Seems so! Konrad