Re: [PATCH v6 2/3] drm: panel: nt36672a: Add support for novatek nt35596s panel

[David Heidelberg <david@ixit.cz>]

On 15/09/2025 03:29, Dmitry Baryshkov wrote:
> On Sat, Sep 13, 2025 at 09:19:48PM +0200, David Heidelberg via B4 Relay wrote:
>> From: Molly Sophia <mollysophia379@gmail.com>
>>
>> Novatek NT35596s is a generic DSI IC that drives command and video mode
>> panels.
>> Currently add support for the LCD panel from JDI connected with this IC,
>> as found on Xiaomi Mi Mix 2S phones.
> 
> Why are you adding it to the existing driver rather than adding a new
> one?

Hello, originally it started as a standalone driver (see v2 patchset), 
but got merged due to similarities.

v2 patchset:
https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg404290.html

If it's desired, I can switch it back to the standalone driver.

> 
>>
>> Signed-off-by: Molly Sophia <mollysophia379@gmail.com>
>> Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>>   drivers/gpu/drm/panel/Kconfig                  |   7 +-
>>   drivers/gpu/drm/panel/panel-novatek-nt36672a.c | 225 ++++++++++++++++++++++++-
>>   2 files changed, 222 insertions(+), 10 deletions(-)
>>
>>   
>>   MODULE_AUTHOR("Sumit Semwal <sumit.semwal@linaro.org>");
>> -MODULE_DESCRIPTION("NOVATEK NT36672A based MIPI-DSI LCD panel driver");
>> +MODULE_AUTHOR("Molly Sophia <mollysophia379@gmail.com>");
> 
> ??

What's wrong with it?

David

> 
>> +MODULE_DESCRIPTION("NOVATEK NT36672A/NT35596S based MIPI-DSI LCD panel driver");
>>   MODULE_LICENSE("GPL");
>>
>> -- 
>> 2.51.0
>>
>>
> 

-- 
David Heidelberg