From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E2FC1DDC37 for ; Thu, 16 Jan 2025 11:34:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737027251; cv=none; b=GDg7kfJBigUjncDWtwXpn/c+JwErUHrofjmnffJ7kR/s4Mbgzaj+mUylW579kiHXo8hCQ320IQunfkaFxZ+bM8cJ/o9XXS3KgvV1Yjv71DkIOvLme1q08yybRrlCZ4YpIjocdmTeho3pyxEKte83ITyd0vEj4ktXZ/5iHKgPIT8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737027251; c=relaxed/simple; bh=hXneXuQ61cYntgNn/sssniG0GrUQ4hSFAcED56KHbH8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=R0pEP2AK3SqWSNmtF2HWFa5CbQ+LxmMOb9ftJsMTPmWFHV4ixG1mhzo3F7klMoI/vTWJP8FqNCuUnqcahvF7T9pHvrAZZ+ash63ZijSvuvBzYnk5M5qAOzYaERGwAIA2hxAA6ax83ZOG0D1Kw+6LtEcYhni3SxjQ9WEU0SH5yRE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tweaklogic.com; spf=pass smtp.mailfrom=tweaklogic.com; dkim=pass (2048-bit key) header.d=tweaklogic.com header.i=@tweaklogic.com header.b=SBylZs2J; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tweaklogic.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tweaklogic.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tweaklogic.com header.i=@tweaklogic.com header.b="SBylZs2J" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2156e078563so9400925ad.2 for ; Thu, 16 Jan 2025 03:34:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tweaklogic.com; s=google; t=1737027248; x=1737632048; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7YktfQbK04MmcrLOtepFIXUYlByhE6kzjeLH7SfhVzM=; b=SBylZs2J7hpeLVZwrZt16G7iExemqMiAuJSLkmccRPiEG9QoNUYsGVJehBMyyERSN2 46/R66vz6hudpyjQEAT5R36uHBV53ne4UTuf5JcYEoB2HwlGlvu4H168ONvfF/Tptxfr 5V/pMeotn8F7iAIMLdqHTQ6vwg46bq4TNUgodwmjZrdK66uvwSvTo72auwOIZQn2aop3 JD4nFxk8nOi5MYX4QTbbEyEabaoK0+cJXBl0sEwBZ+FhEfv+FpkOolgRBWB2nm/w0xAp mLfEmRLHstZyJ/e/9rwzNVMkQLhyLTM02v5wpxaFWZHl40VnsPONSpL6clacJ3wX4Wb7 KmRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737027248; x=1737632048; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7YktfQbK04MmcrLOtepFIXUYlByhE6kzjeLH7SfhVzM=; b=vNSCWoGRDjTjOwTTAhiNH/d6lTLHLBDsmmvpFiEsXF/5dIlobGI3kYEz4ygayOZcGu RiuGqtyNy+Pnb9R9h9+RoQdUFzzeXgBsBB3H0ruMoROzLj4yP2uyjo+LTgjL2/YsZcjQ 33P8hcZpB/i++4JG1symGRP7RW+g06vZCjhElFZ8JGZOYgMhNXGwYPabrP3pNtt/0YRw XiePs7t6QpYIDlbip4kLActxcbtpHVWcgf53TeQferXub+M3sx0PNHTCPUtGY/9GHUwh UnWMr5ce+TpybMG3r/Yp8n86BqzzAka4mBySSEVJpTVj3OmUAw0L+TUwtBGMrlnIFOJR szYg== X-Forwarded-Encrypted: i=1; AJvYcCV/vCYES1JALtHQ1/MPD45XbKzF8AUukaJJAoAl2kXC4lpm6b6hHzxwT7Z72BdfRda+XTN2h3jwvZ/xpvc=@vger.kernel.org X-Gm-Message-State: AOJu0YwmULBFSrj73mLVnQEK7H5nm4Z3Rt+eCmjrkTmQ4YsbM2dQuKk0 JaV5dRzt6D1ce+3lqctNgoe8364YyR8jhW0+UE8KNNznorm9OoIA70VNOAwaodM= X-Gm-Gg: ASbGncu/wH8AQMgmzQcUkBheFjQIu2NW/KmWFXkdFk6rmEbvNplAJ53Gi5zAawoHsdx MQ2Qi382WbbI1VEmVwJFjK+4feZgyDwuH5UcYdKEM2SQLZxQW64XmtgoC1LvqZ7uwNKS+adXzYL Pnvlsky7jpy72JnE/FcyMsjzoTtQd+ZM2SWMCeV+TGJUEM4K4xPa5h/rNOo3zeUzcVpZy5WwXxB PpvMNJioAwedcXGPBH2YiW2K9QaSrKVnC/bhG0nIEdMJJekdjD8bz5WoKwfztiJ1uU8HZyN984K X-Google-Smtp-Source: AGHT+IHn0LVg8saEn8D4DZWe1zUwgh/bi1Q+v/D6XJ0zjNhEGPRiwLuR9bIWFuiS8tWZKmN8T2HC6A== X-Received: by 2002:a05:6a00:858b:b0:728:8c17:127d with SMTP id d2e1a72fcca58-72d21f2da93mr50495307b3a.8.1737027247871; Thu, 16 Jan 2025 03:34:07 -0800 (PST) Received: from [192.168.50.161] ([180.150.112.66]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-a317b761b9asm11387383a12.12.2025.01.16.03.34.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jan 2025 03:34:07 -0800 (PST) Message-ID: Date: Thu, 16 Jan 2025 22:04:01 +1030 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] iio: light: apds9306: fix max_scale_nano values To: Javier Carrasco , Jonathan Cameron , Lars-Peter Clausen Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Cameron , stable@vger.kernel.org References: <20250112-apds9306_nano_vals-v1-1-82fb145d0b16@gmail.com> Content-Language: en-US From: Subhajit Ghosh In-Reply-To: <20250112-apds9306_nano_vals-v1-1-82fb145d0b16@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12/1/25 10:38, Javier Carrasco wrote: > The two provided max_scale_nano values must be multiplied by 100 and 10 > respectively to achieve nano units. According to the comments: > > Max scale for apds0306 is 16.326432 → the fractional part is 0.326432, > which is 326432000 in NANO. The current value is 3264320. > > Max scale for apds0306-065 is 14.09721 → the fractional part is 0.09712, > which is 97120000 in NANO. The current value is 9712000. > > Update max_scale_nano initialization to use the right NANO fractional > parts. > > Cc: stable@vger.kernel.org > Fixes: 620d1e6c7a3f ("iio: light: Add support for APDS9306 Light Sensor") > Signed-off-by: Javier Carrasco > --- > drivers/iio/light/apds9306.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/light/apds9306.c b/drivers/iio/light/apds9306.c > index 69a0d609cffc91cc3daba160f309f511270be385..5ed7e17f49e76206609aba83c85e8144c536d17d 100644 > --- a/drivers/iio/light/apds9306.c > +++ b/drivers/iio/light/apds9306.c > @@ -108,11 +108,11 @@ static const struct part_id_gts_multiplier apds9306_gts_mul[] = { > { > .part_id = 0xB1, > .max_scale_int = 16, > - .max_scale_nano = 3264320, > + .max_scale_nano = 326432000, > }, { > .part_id = 0xB3, > .max_scale_int = 14, > - .max_scale_nano = 9712000, > + .max_scale_nano = 97120000, > }, > }; > > > --- > base-commit: 577a66e2e634f712384c57a98f504c44ea4b47da > change-id: 20241218-apds9306_nano_vals-d880219a82f2 > > Best regards, Hi Javier, You are correct. From iio_gts_linearize() function in industrialio-gts-helper.c *lin_scale = (u64)scale_whole * (u64)scaler + (u64)(scale_nano / (NANO / scaler)); where "scaler" equals NANO (1000000000UL) I tested it, no issues. The values did not deviate much as this is nano scale. Tested-by: subhajit.ghosh@tweaklogic.com Regards, Subhajit Ghosh