From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-pcmcia@lists.infradead.org
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 4/4] pcmcia: pd6729: Combine substrings for six messages
Date: Mon, 15 May 2017 14:30:08 +0200 [thread overview]
Message-ID: <ad220bb8-63ef-fcdf-c39f-8da5ce7a242a@users.sourceforge.net> (raw)
In-Reply-To: <07cd817c-3045-72d8-34e2-e81b73efc291@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 15 May 2017 13:50:52 +0200
The script "checkpatch.pl" pointed information out like the following.
WARNING: quoted string split across lines
Thus fix the affected source code places.
Prefer usage of the macros "pr_err" and "pr_info" over
the interface "printk".
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/pcmcia/pd6729.c | 25 ++++++++++++-------------
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/drivers/pcmcia/pd6729.c b/drivers/pcmcia/pd6729.c
index b3422119820a..841f413c0d03 100644
--- a/drivers/pcmcia/pd6729.c
+++ b/drivers/pcmcia/pd6729.c
@@ -183,8 +183,7 @@ static irqreturn_t pd6729_interrupt(int irq, void *dev)
while (1) {
loopcount++;
if (loopcount > 20) {
- printk(KERN_ERR "pd6729: infinite eventloop "
- "in interrupt\n");
+ pr_err("infinite event loop in interrupt\n");
break;
}
@@ -348,8 +347,8 @@ static int pd6729_set_socket(struct pcmcia_socket *sock, socket_state_t *state)
break;
default:
dev_dbg(&sock->dev,
- "pd6729_set_socket called with invalid VCC power "
- "value: %i\n", state->Vcc);
+ "%s called with invalid VCC power value: %i\n",
+ __func__, state->Vcc);
return -EINVAL;
}
@@ -369,8 +368,9 @@ static int pd6729_set_socket(struct pcmcia_socket *sock, socket_state_t *state)
reg |= I365_VPP1_12V;
break;
default:
- dev_dbg(&sock->dev, "pd6729: pd6729_set_socket called with "
- "invalid VPP power value: %i\n", state->Vpp);
+ dev_dbg(&sock->dev,
+ "%s called with invalid VPP power value: %i\n",
+ __func__, state->Vpp);
return -EINVAL;
}
@@ -597,8 +597,7 @@ static u_int pd6729_isa_scan(void)
int i;
if (irq_mode == 1) {
- printk(KERN_INFO "pd6729: PCI card interrupts, "
- "PCI status changes\n");
+ pr_info("PCI card interrupts, PCI status changes\n");
return 0;
}
@@ -641,15 +640,15 @@ static int pd6729_pci_probe(struct pci_dev *dev,
}
if (!pci_resource_start(dev, 0)) {
- dev_warn(&dev->dev, "refusing to load the driver as the "
- "io_base is NULL.\n");
+ dev_warn(&dev->dev,
+ "refusing to load the driver as the io_base is NULL.\n");
ret = -ENOMEM;
goto err_out_disable;
}
- dev_info(&dev->dev, "Cirrus PD6729 PCI to PCMCIA Bridge at 0x%llx "
- "on irq %d\n",
- (unsigned long long)pci_resource_start(dev, 0), dev->irq);
+ dev_info(&dev->dev,
+ "Cirrus PD6729 PCI to PCMCIA Bridge at 0x%llx on irq %d\n",
+ (unsigned long long)pci_resource_start(dev, 0), dev->irq);
/*
* Since we have no memory BARs some firmware may not
* have had PCI_COMMAND_MEMORY enabled, yet the device needs it.
--
2.13.0
prev parent reply other threads:[~2017-05-15 12:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 12:25 [PATCH 0/4] PCMCIA-PD6729: Adjustments for four function implementations SF Markus Elfring
2017-05-15 12:26 ` [PATCH 1/4] pcmcia: pd6729: Use kcalloc() in pd6729_pci_probe() SF Markus Elfring
2017-05-15 12:27 ` [PATCH 2/4] pcmcia: pd6729: Delete an error message for a failed memory allocation " SF Markus Elfring
2017-05-15 12:29 ` [PATCH 3/4] pcmcia: pd6729: Add the macro "pr_fmt" SF Markus Elfring
2017-05-15 12:30 ` SF Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad220bb8-63ef-fcdf-c39f-8da5ce7a242a@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®