mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nitin Rawat <quic_nitirawa@quicinc.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	<martin.petersen@oracle.com>, <jejb@linux.ibm.com>
Cc: <andersson@kernel.org>, <konrad.dybcio@linaro.org>,
	<linux-arm-msm@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <quic_cang@quicinc.com>
Subject: Re: [PATCH 13/13] scsi: ufs: qcom: Initialize cycles_in_1us variable in ufs_qcom_set_core_clk_ctrl()
Date: Tue, 5 Dec 2023 22:03:29 +0530	[thread overview]
Message-ID: <ad241353-e6ad-d57f-6c71-888a484ba721@quicinc.com> (raw)
In-Reply-To: <20231201151417.65500-14-manivannan.sadhasivam@linaro.org>



On 12/1/2023 8:44 PM, Manivannan Sadhasivam wrote:
> In case the "core_clk_unipro" clock is not provided, "cycles_in_1us"
> variable will be used as uninitialized. So initialize it with 0.
> 
> Issue reported by Smatch tool:
> 
> drivers/ufs/host/ufs-qcom.c:1336 ufs_qcom_set_core_clk_ctrl() error: uninitialized symbol 'cycles_in_1us'.
> drivers/ufs/host/ufs-qcom.c:1341 ufs_qcom_set_core_clk_ctrl() error: uninitialized symbol 'cycles_in_1us'.
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>   drivers/ufs/host/ufs-qcom.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 590a2c67cf7d..208543a62d43 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -1296,7 +1296,7 @@ static int ufs_qcom_set_core_clk_ctrl(struct ufs_hba *hba, bool is_scale_up)
>   	struct ufs_qcom_host *host = ufshcd_get_variant(hba);
>   	struct list_head *head = &hba->clk_list_head;
>   	struct ufs_clk_info *clki;
> -	u32 cycles_in_1us;
> +	u32 cycles_in_1us = 0;
>   	u32 core_clk_ctrl_reg;
>   	int err;
>   

Reviewed-by: Nitin Rawat <quic_nitirawa@quicinc.com>

      reply	other threads:[~2023-12-05 16:33 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-01 15:14 [PATCH 00/13] scsi: ufs: qcom: Minor code cleanups Manivannan Sadhasivam
2023-12-01 15:14 ` [PATCH 01/13] scsi: ufs: qcom: Use clk_bulk APIs for managing lane clocks Manivannan Sadhasivam
2023-12-06 18:08   ` Andrew Halaney
2023-12-01 15:14 ` [PATCH 02/13] scsi: ufs: qcom: Fix the return value of ufs_qcom_ice_program_key() Manivannan Sadhasivam
2023-12-01 17:49   ` Abel Vesa
2023-12-01 15:14 ` [PATCH 03/13] scsi: ufs: qcom: Fix the return value when platform_get_resource_byname() fails Manivannan Sadhasivam
2023-12-06 18:11   ` Andrew Halaney
2023-12-01 15:14 ` [PATCH 04/13] scsi: ufs: qcom: Remove superfluous variable assignments Manivannan Sadhasivam
2023-12-06 18:15   ` Andrew Halaney
2023-12-01 15:14 ` [PATCH 05/13] scsi: ufs: qcom: Remove the warning message when core_reset is not available Manivannan Sadhasivam
2023-12-06 18:36   ` Andrew Halaney
2023-12-07  5:18     ` Manivannan Sadhasivam
2023-12-07 13:50       ` Andrew Halaney
2023-12-01 15:14 ` [PATCH 06/13] scsi: ufs: qcom: Export ufshcd_{enable/disable}_irq helpers and make use of them Manivannan Sadhasivam
2023-12-01 20:27   ` Bart Van Assche
2023-12-01 15:14 ` [PATCH 07/13] scsi: ufs: qcom: Fail ufs_qcom_power_up_sequence() when core_reset fails Manivannan Sadhasivam
2023-12-06 18:41   ` Andrew Halaney
2023-12-07  5:26     ` Manivannan Sadhasivam
2023-12-01 15:14 ` [PATCH 08/13] scsi: ufs: qcom: Check the return value of ufs_qcom_power_up_sequence() Manivannan Sadhasivam
2023-12-06 18:43   ` Andrew Halaney
2023-12-07  8:27   ` Nitin Rawat
2023-12-01 15:14 ` [PATCH 09/13] scsi: ufs: qcom: Remove redundant error print for devm_kzalloc() failure Manivannan Sadhasivam
2023-12-07  8:36   ` Nitin Rawat
2023-12-01 15:14 ` [PATCH 10/13] scsi: ufs: qcom: Use dev_err_probe() to simplify error handling of devm_gpiod_get_optional() Manivannan Sadhasivam
2023-12-06 18:52   ` Andrew Halaney
2023-12-01 15:14 ` [PATCH 11/13] scsi: ufs: qcom: Remove unused ufs_qcom_hosts struct array Manivannan Sadhasivam
2023-12-06 18:54   ` Andrew Halaney
2023-12-07  5:31     ` Manivannan Sadhasivam
2023-12-07 13:46       ` Andrew Halaney
2023-12-07  8:43   ` Nitin Rawat
2023-12-01 15:14 ` [PATCH 12/13] scsi: ufs: qcom: Sort includes alphabetically Manivannan Sadhasivam
2023-12-05 16:35   ` Nitin Rawat
2023-12-01 15:14 ` [PATCH 13/13] scsi: ufs: qcom: Initialize cycles_in_1us variable in ufs_qcom_set_core_clk_ctrl() Manivannan Sadhasivam
2023-12-05 16:33   ` Nitin Rawat [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad241353-e6ad-d57f-6c71-888a484ba721@quicinc.com \
    --to=quic_nitirawa@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=jejb@linux.ibm.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=martin.petersen@oracle.com \
    --cc=quic_cang@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®