From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D14621218A for ; Fri, 25 Oct 2024 14:47:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729867625; cv=none; b=h5UsEMilb5+L8RptBpwtSNasVZuiMDqfSk0A/8Ot8Uxv29uymRA9ngBfmCLl47yBeAHgvaSHMMsNE0Aogp3htnWnKJhyS2az7nGuVrgZNAoz/G+YRCHZNXCpJu8EY5/vB3EepCMVJosV8Pb7xgbDtMDihwkUTLpxsv69ARXRVPk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729867625; c=relaxed/simple; bh=Uzkr6q47eov0IbRLSpaLxWzPtpQ7YKN5vQ+eSXa1cIg=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=L9KnYcv5AdIyuLTmYiABk9KJSb9/PrfFcIe1O+nk9Go5/2PGVzqNuDMf2v+kMVi/ItCLM74QumPlOFVoCtbQv8Yhs/yOlycqZuytX+FANa0hYsnkzGSoDnViPGmwaHPAoSQHRN8u3EcvT6bk1qD3YxlnARairEQVNM5LZIdgAi0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t4LaZ-0000em-Lb; Fri, 25 Oct 2024 16:46:55 +0200 Received: from lupine.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::4e] helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1t4LaY-000NuE-22; Fri, 25 Oct 2024 16:46:54 +0200 Received: from pza by lupine with local (Exim 4.96) (envelope-from ) id 1t4LaY-000BjX-1o; Fri, 25 Oct 2024 16:46:54 +0200 Message-ID: Subject: Re: linux-next: build warning after merge of the reset tree From: Philipp Zabel To: Rob Herring , Herve Codina Cc: Stephen Rothwell , Linux Kernel Mailing List , Linux Next Mailing List Date: Fri, 25 Oct 2024 16:46:54 +0200 In-Reply-To: References: <20241025110919.64b1cffb@canb.auug.org.au> <20241025082817.28056f52@bootlin.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Fr, 2024-10-25 at 08:44 -0500, Rob Herring wrote: > On Fri, Oct 25, 2024 at 1:28=E2=80=AFAM Herve Codina wrote: > >=20 > > Hi all, > >=20 > > On Fri, 25 Oct 2024 11:09:19 +1100 > > Stephen Rothwell wrote: > >=20 > > > Hi all, > > >=20 > > > After merging the reset tree, today's linux-next build (x86_64 > > > allmodconfig) produced this warning: > > >=20 > > > drivers/misc/lan966x_pci.dtso:34.23-40.7: Warning (interrupts_propert= y): /fragment@0/__overlay__/pci-ep-bus@0/oic@e00c0120: Missing interrupt-pa= rent > > >=20 > > > Introduced by commit > > >=20 > > > 185686beb464 ("misc: Add support for LAN966x PCI device") > > >=20 > >=20 > > This warning is normal. > > interrupt-parent is not present in the oic node. This was discussed in > > https://lore.kernel.org/all/CAL_Jsq+je7+9ATR=3DB6jXHjEJHjn24vQFs4Tvi9= =3DvhDeK9n42Aw@mail.gmail.com/ >=20 > We can't have warnings especially in things outside of arch/. Doesn't > matter why. >=20 > The choices to fix are: >=20 > - Override DTC_FLAGS in drivers/misc/. You can set DTC_FLAGS_lan966x_pci >=20 > - Disable the check in dtc for overlays. We've done this for other cases. >=20 > - Add enough info into the overlay to avoid the warnings. This might > mean the overlay has to be applied up one node level. It is > duplicating a few things which are in the base tree. This is my > preference because it makes the overlay stand on its own. We'll have > the same issue with dtschema checks too if we don't do this. I see four more warnings that look like false positives to me: drivers/misc/lan966x_pci.dtso:42.22-46.7: Warning (simple_bus_reg): /fragme= nt@0/__overlay__/pci-ep-bus@0/cpu_clk: missing or empty reg/ranges property drivers/misc/lan966x_pci.dtso:48.22-52.7: Warning (simple_bus_reg): /fragme= nt@0/__overlay__/pci-ep-bus@0/ddr_clk: missing or empty reg/ranges property drivers/misc/lan966x_pci.dtso:54.22-58.7: Warning (simple_bus_reg): /fragme= nt@0/__overlay__/pci-ep-bus@0/sys_clk: missing or empty reg/ranges property drivers/misc/lan966x_pci.dtso:18.15-165.5: Warning (avoid_unnecessary_addr_= size): /fragment@0/__overlay__: unnecessary #address-cells/#size-cells with= out "ranges", "dma-ranges" or child "reg" property Setting DTC_FLAGS_lan966x_pci :=3D -Wno-interrupts_property -Wno-simple_bus_reg -Wn= o-avoid_unnecessary_addr_size silences them all. regards Philipp